fix EXR problems and others caused by MSVC v143

Author: devshgraphicsprogramming

include/nbl/core/memory/new_delete.h

@@ -103,7 +103,7 @@ struct NBL_API AlignedWithAllocator
 #define _NBL_DELETE(_obj)                                       nbl::core::impl::AlignedWithAllocator<typename std::remove_reference<typename std::remove_pointer<decltype(_obj)>::type>::type,_NBL_DEFAULT_ALLOCATOR_METATYPE<typename std::remove_reference<typename std::remove_pointer<decltype(_obj)>::type>::type> >::delete_(_obj)
 
 #define _NBL_NEW_ARRAY(_obj_type,count)                         nbl::core::impl::AlignedWithAllocator<_obj_type,_NBL_DEFAULT_ALLOCATOR_METATYPE<_obj_type> >::new_array(count,_NBL_DEFAULT_ALIGNMENT(_obj_type))
-#define _NBL_DELETE_ARRAY(_obj,count)                           nbl::core::impl::AlignedWithAllocator<typename std::remove_reference<typename std::remove_pointer<decltype(_obj)>::type>::type,_NBL_DEFAULT_ALLOCATOR_METATYPE<typename std::remove_reference<typename std::remove_pointer<decltype(_obj)>::type>::type> >::delete_array(_obj,count)
+#define _NBL_DELETE_ARRAY(_obj,count)                           nbl::core::impl::AlignedWithAllocator<typename std::remove_reference_t<typename std::remove_pointer_t<decltype(_obj)>>,_NBL_DEFAULT_ALLOCATOR_METATYPE<typename std::remove_reference_t<typename std::remove_pointer_t<decltype(_obj)>>> >::delete_array(_obj,count)
 
 //! Extra Utility Macros for when you don't want to always have to deduce the alignment but want to use a specific allocator
 //#define _NBL_ASSERT_ALLOCATOR_VALUE_TYPE(_obj_type,_allocator_type)     static_assert(std::is_same<_obj_type,_allocator_type::value_type>::value,"Wrong allocator value_type!")

include/nbl/video/IPhysicalDevice.h

@@ -720,7 +720,7 @@ class NBL_API2 IPhysicalDevice : public core::Interface, public core::Unmovable
 namespace std
 {
     template<>
-    struct std::hash<nbl::video::IPhysicalDevice::SFormatImageUsages::SUsage>
+    struct hash<nbl::video::IPhysicalDevice::SFormatImageUsages::SUsage>
     {
         inline uint32_t operator()(const nbl::video::IPhysicalDevice::SFormatImageUsages::SUsage& i) const
         {
@@ -739,7 +739,7 @@ namespace std
     };
 
     template<>
-    struct std::hash<nbl::video::IPhysicalDevice::SFormatBufferUsages::SUsage>
+    struct hash<nbl::video::IPhysicalDevice::SFormatBufferUsages::SUsage>
     {
         inline uint32_t operator()(const nbl::video::IPhysicalDevice::SFormatBufferUsages::SUsage& b) const
         {

src/nbl/asset/interchange/CImageWriterOpenEXR.cpp

@@ -114,7 +114,7 @@ namespace nbl::asset::impl
 constexpr uint8_t availableChannels = 4;
 
 template<typename ilmType>
-bool createAndWriteImage(std::array<ilmType*, availableChannels>& pixelsArrayIlm, const asset::ICPUImage* image, system::IFile* _file)
+bool createAndWriteImage(std::array<ilmType*,availableChannels>& pixelsArrayIlm, const asset::ICPUImage* image, system::IFile* _file)
 {
 	const auto& creationParams = image->getCreationParameters();
 	auto getIlmType = [&creationParams]()
@@ -142,7 +142,8 @@ bool createAndWriteImage(std::array<ilmType*, availableChannels>& pixelsArrayIlm
 		channelPixelsPtr = _NBL_NEW_ARRAY(ilmType, width * height);
 
 	const auto* data = reinterpret_cast<const uint8_t*>(image->getBuffer()->getPointer());
-	auto writeTexel = [&creationParams,&data,&pixelsArrayIlm](uint32_t ptrOffset, const core::vectorSIMDu32& texelCoord) -> void
+	// have to use `std::function` cause MSVC is borderline retarded and feel the need to instantiate separate Lambda types for each reference!?
+	auto writeTexel = std::function([&creationParams,&data,&pixelsArrayIlm](uint32_t ptrOffset, const core::vectorSIMDu32& texelCoord) -> void
 	{
 		assert(texelCoord.w==0u && texelCoord.z==0u);
 
@@ -154,7 +155,7 @@ bool createAndWriteImage(std::array<ilmType*, availableChannels>& pixelsArrayIlm
 			ilmType channelPixel = *(reinterpret_cast<const ilmType*>(texelPtr) + channelIndex);
 			*(pixelsArrayIlm[channelIndex] + ptrStyleIlmShiftToDataChannelPixel) = channelPixel;
 		}
-	};
+	});
 
 	using StreamToEXR = CRegionBlockFunctorFilter<decltype(writeTexel),true>;
 	typename StreamToEXR::state_type state(writeTexel,image,nullptr);

src/nbl/asset/interchange/COBJMeshFileLoader.cpp

@@ -99,6 +99,7 @@ asset::SAssetBundle COBJMeshFileLoader::loadAsset(system::IFile* _file, const as
 	};
     core::unordered_multiset<pipeline_meta_pair_t,hash_t,key_equal_t> pipelines;
 
+	// TODO: map the file whenever possible
     std::string fileContents;
     fileContents.resize(filesize);
 	char* const buf = fileContents.data();
@@ -142,6 +143,7 @@ asset::SAssetBundle COBJMeshFileLoader::loadAsset(system::IFile* _file, const as
     core::vector<std::string> submeshMaterialNames;
     core::vector<uint32_t> vtxSmoothGrp;
 
+	// TODO: handle failures much better!
 	constexpr const char* NO_MATERIAL_MTL_NAME = "#";
 	bool noMaterial = true;
 	bool dummyMaterialCreated = false;