Skip to content

Commit 68c8123

Browse files
committed
removed create from lambertian, delta dis bc they do nothing
1 parent d4c61bd commit 68c8123

File tree

4 files changed

+0
-56
lines changed

4 files changed

+0
-56
lines changed

include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,6 @@ struct SDeltaDistribution
3333

3434
NBL_CONSTEXPR_STATIC_INLINE BxDFClampMode _clamp = BxDFClampMode::BCM_MAX;
3535

36-
struct SCreationParams {};
37-
using creation_type = SCreationParams;
38-
39-
static this_t create()
40-
{
41-
this_t retval;
42-
// nothing here, just keeping in convention with others
43-
return retval;
44-
}
45-
static this_t create(NBL_CONST_REF_ARG(creation_type) params)
46-
{
47-
return create();
48-
}
49-
5036
spectral_type eval(NBL_CONST_REF_ARG(sample_type) _sample, NBL_CONST_REF_ARG(isotropic_interaction_type) interaction)
5137
{
5238
return hlsl::promote<spectral_type>(0);

include/nbl/builtin/hlsl/bxdf/reflection/lambertian.hlsl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,6 @@ struct SLambertian
3434

3535
NBL_CONSTEXPR_STATIC_INLINE BxDFClampMode _clamp = BxDFClampMode::BCM_MAX;
3636

37-
struct SCreationParams {};
38-
using creation_type = SCreationParams;
39-
40-
static this_t create()
41-
{
42-
this_t retval;
43-
// nothing here, just keeping in convention with others
44-
return retval;
45-
}
46-
static this_t create(NBL_CONST_REF_ARG(creation_type) params)
47-
{
48-
return create();
49-
}
50-
5137
spectral_type eval(NBL_CONST_REF_ARG(sample_type) _sample, NBL_CONST_REF_ARG(isotropic_interaction_type) interaction)
5238
{
5339
return hlsl::promote<spectral_type>(_sample.getNdotL(_clamp) * numbers::inv_pi<scalar_type>);

include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,20 +33,6 @@ struct SDeltaDistribution
3333

3434
NBL_CONSTEXPR_STATIC_INLINE BxDFClampMode _clamp = BxDFClampMode::BCM_MAX;
3535

36-
struct SCreationParams {};
37-
using creation_type = SCreationParams;
38-
39-
static this_t create()
40-
{
41-
this_t retval;
42-
// nothing here, just keeping in convention with others
43-
return retval;
44-
}
45-
static this_t create(NBL_CONST_REF_ARG(creation_type) params)
46-
{
47-
return create();
48-
}
49-
5036
spectral_type eval(NBL_CONST_REF_ARG(sample_type) _sample, NBL_CONST_REF_ARG(isotropic_interaction_type) interaction)
5137
{
5238
return hlsl::promote<spectral_type>(0);

include/nbl/builtin/hlsl/bxdf/transmission/lambertian.hlsl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,6 @@ struct SLambertian
3535

3636
NBL_CONSTEXPR_STATIC_INLINE BxDFClampMode _clamp = BxDFClampMode::BCM_ABS;
3737

38-
struct SCreationParams {};
39-
using creation_type = SCreationParams;
40-
41-
static this_t create()
42-
{
43-
this_t retval;
44-
// nothing here, just keeping convention with others
45-
return retval;
46-
}
47-
static this_t create(NBL_CONST_REF_ARG(creation_type) params)
48-
{
49-
return create();
50-
}
51-
5238
spectral_type eval(NBL_CONST_REF_ARG(sample_type) _sample, NBL_CONST_REF_ARG(isotropic_interaction_type) interaction)
5339
{
5440
return hlsl::promote<spectral_type>(_sample.getNdotL(_clamp) * numbers::inv_pi<scalar_type> * 0.5);

0 commit comments

Comments
 (0)