@@ -46,7 +46,7 @@ bool IGPUCommandBuffer::checkStateBeforeRecording(const core::bitflag<queue_flag
4646bool IGPUCommandBuffer::begin (const core::bitflag<USAGE> flags, const SInheritanceInfo* inheritanceInfo)
4747{
4848 // Using Vulkan 1.2 VUIDs here because we don't want to confuse ourselves with Dynamic Rendering being core
49- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00049
49+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00049
5050 if (m_state == STATE::RECORDING || m_state == STATE::PENDING)
5151 {
5252 m_logger.log (" Failed to begin command buffer: command buffer must not be in RECORDING or PENDING state." , system::ILogger::ELL_ERROR);
@@ -57,7 +57,7 @@ bool IGPUCommandBuffer::begin(const core::bitflag<USAGE> flags, const SInheritan
5757 const auto physDev = getOriginDevice ()->getPhysicalDevice ();
5858 if (m_level==IGPUCommandPool::BUFFER_LEVEL::PRIMARY)
5959 {
60- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-02840
60+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-02840
6161 if (flags.hasFlags (USAGE::ONE_TIME_SUBMIT_BIT|USAGE::SIMULTANEOUS_USE_BIT))
6262 {
6363 m_logger.log (" Failed to begin command buffer: a primary command buffer must not have both USAGE::ONE_TIME_SUBMIT_BIT and USAGE::SIMULTANEOUS_USE_BIT set." , system::ILogger::ELL_ERROR);
@@ -76,14 +76,14 @@ bool IGPUCommandBuffer::begin(const core::bitflag<USAGE> flags, const SInheritan
7676 }
7777 else if (inheritanceInfo)
7878 {
79- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00052
79+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00052
8080 if (inheritanceInfo->queryFlags .hasFlags (QUERY_CONTROL_FLAGS::PRECISE_BIT) && (!inheritanceInfo->occlusionQueryEnable /* || TODO: precise occlusion queries limit/feature*/ ))
8181 {
8282 m_logger.log (" Failed to begin command buffer: Precise Occlusion Queries cannot be used!" , system::ILogger::ELL_ERROR);
8383 return false ;
8484 }
8585 }
86- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00051
86+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-vkBeginCommandBuffer-commandBuffer-00051
8787 else
8888 {
8989 m_logger.log (" Failed to begin command buffer: a secondary command buffer requires an inheritance info structure!" , system::ILogger::ELL_ERROR);
@@ -98,15 +98,15 @@ bool IGPUCommandBuffer::begin(const core::bitflag<USAGE> flags, const SInheritan
9898 return false ;
9999 }
100100
101- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00053
102- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00054
101+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00053
102+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00054
103103 if (!inheritanceInfo || !inheritanceInfo->renderpass || !inheritanceInfo->renderpass ->isCompatibleDevicewise (this ) || inheritanceInfo->subpass <inheritanceInfo->renderpass ->getSubpassCount ())
104104 {
105105 m_logger.log (" Failed to begin command buffer: a secondary command buffer must have valid inheritance info with a valid renderpass." , system::ILogger::ELL_ERROR);
106106 return false ;
107107 }
108108
109- // https://vulkan.lunarg.com/doc/view /1.2.176.1/linux/1.2 -extensions/vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00055
109+ // https://registry.khronos.org/vulkan/specs /1.3 -extensions/html /vkspec.html#VUID-VkCommandBufferBeginInfo-flags-00055
110110 if (inheritanceInfo->framebuffer && !inheritanceInfo->framebuffer ->isCompatibleDevicewise (this )/* TODO: better check needed || inheritanceInfo->framebuffer->getCreationParameters().renderpass != inheritanceInfo->renderpass*/ )
111111 return false ;
112112 }
0 commit comments