ok Nabla target builds with refactored single config build options header, now need to get rid of define.h and move it to interface compile definition properties to support install usage requirements

Author: AnastaZIuk

CMakeLists.txt

@@ -161,22 +161,13 @@ if(_NBL_AVAILABLE_PHYSICAL_MEMORY_ LESS_EQUAL _NBL_DEBUG_MEMORY_CONSUPTION_WITH_
 	else()
 		set(_NBL_CMAKE_STATUS_ FATAL_ERROR)
 	endif()
-	
+
 	message(${_NBL_CMAKE_STATUS_} "Memory consumption issue detected! To protect you from compile and linker errors, please read this message.\n\nYour total physical memory is ${_NBL_TOTAL_PHYSICAL_MEMORY_} MBs, your OS is currently using ${_NBL_CURRENTLY_USED_PHYSICAL_MEMORY_} MBs and consumption of your memory with requested ${_NBL_JOBS_AMOUNT_} jobs in Debug configuration may be around ${_NBL_DEBUG_MEMORY_CONSUPTION_WITH_ALL_JOBS_} MBs. Please override '_NBL_JOBS_AMOUNT_' variable by setting it as cache variable and lower the jobs! If you want to continue anyway, please define 'NBL_MEMORY_CONSUMPTION_CHECK_SKIP' but be aware - you are doing it on your own risk of possible build failures.")
 endif()
 
 include(adjust/flags)
 include(adjust/definitions)
 
-if(WIN32)
-	set(_NBL_PLATFORM_WINDOWS_ 1)
-elseif(ANDROID)
-	set(_NBL_PLATFORM_ANDROID_ 1)
-elseif(UNIX)
-	set(_NBL_PLATFORM_LINUX_ 1)
-	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -msse4.1")
-endif()
-
 if(NBL_STATIC_BUILD)
 	unset(_NBL_SHARED_BUILD_ CACHE)
 else()
@@ -185,7 +176,7 @@ endif()
 
 option(NBL_BUILD_DPL "Enable DPL (Dynamic Parallelism Library)" OFF)
 option(NBL_PCH "Enable pre-compiled header" ON)
-option(NBL_FAST_MATH "Enable fast low-precision math" ON)
+option(NBL_FAST_MATH "Enable fast low-precision math" OFF) # the reason OFF is by default now is the var controling it at build time was set AFTER BuildConfigOptions was generated - resulting in the feature being always OFF regardless the value xD - so just for sanity, keeping the same behaviour by default
 option(NBL_BUILD_EXAMPLES "Enable building examples" ON)
 option(NBL_BUILD_MITSUBA_LOADER "Enable nbl::ext::MitsubaLoader?" OFF) # TODO: once it compies turn this ON by default!
 option(NBL_BUILD_IMGUI "Enable nbl::ext::ImGui?" ON)

cmake/common.cmake

@@ -202,45 +202,12 @@ macro(nbl_create_ext_library_project EXT_NAME LIB_HEADERS LIB_SOURCES LIB_INCLUD
 	)
 endmacro()
 
-function(nbl_get_conf_dir _OUTVAR _CONFIG)
-	string(TOLOWER ${_CONFIG} CONFIG)
-	set(${_OUTVAR} "${NBL_ROOT_PATH_BINARY}/include/nbl/config/${CONFIG}" PARENT_SCOPE)
-endfunction()
-
-macro(nbl_generate_conf_files)
-	nbl_get_conf_dir(NBL_CONF_DIR_DEBUG Debug)
-	nbl_get_conf_dir(NBL_CONF_DIR_RELEASE Release)
-	nbl_get_conf_dir(NBL_CONF_DIR_RELWITHDEBINFO RelWithDebInfo)
-
-	set(_NBL_DEBUG 0)
-	set(_NBL_RELWITHDEBINFO 0)
-
-	configure_file("${NBL_ROOT_PATH}/include/nbl/config/BuildConfigOptions.h.in" "${NBL_CONF_DIR_RELEASE}/BuildConfigOptions.h.conf")
-	file(GENERATE OUTPUT "${NBL_CONF_DIR_RELEASE}/BuildConfigOptions.h" INPUT "${NBL_CONF_DIR_RELEASE}/BuildConfigOptions.h.conf" CONDITION $<CONFIG:Release>)
-
-	set(_NBL_DEBUG 0)
-	set(_NBL_RELWITHDEBINFO 1)
-	
-	configure_file("${NBL_ROOT_PATH}/include/nbl/config/BuildConfigOptions.h.in" "${NBL_CONF_DIR_RELWITHDEBINFO}/BuildConfigOptions.h.conf")
-	file(GENERATE OUTPUT "${NBL_CONF_DIR_RELWITHDEBINFO}/BuildConfigOptions.h" INPUT "${NBL_CONF_DIR_RELWITHDEBINFO}/BuildConfigOptions.h.conf" CONDITION $<CONFIG:RelWithDebInfo>)
-
-	set(_NBL_DEBUG 1)
-	set(_NBL_RELWITHDEBINFO 0)
-
-	configure_file("${NBL_ROOT_PATH}/include/nbl/config/BuildConfigOptions.h.in" "${NBL_CONF_DIR_DEBUG}/BuildConfigOptions.h.conf")
-	file(GENERATE OUTPUT "${NBL_CONF_DIR_DEBUG}/BuildConfigOptions.h" INPUT "${NBL_CONF_DIR_DEBUG}/BuildConfigOptions.h.conf" CONDITION $<CONFIG:Debug>)
-
-	unset(NBL_CONF_DIR_DEBUG)
-	unset(NBL_CONF_DIR_RELEASE)
-	unset(NBL_CONF_DIR_RELWITHDEBINFO)
-endmacro()
-
 ###########################################
 # Nabla install rules, directory structure:
 #
-# -	$<CONFIG>/include 		(header files)
-# - $<CONFIG>/lib 			(import/static/shared libraries)
-# - $<CONFIG>/runtime 		(DLLs/PDBs)
+# -	include 				(portable header files)
+# - $<CONFIG>/lib 			(static or import shared libraries)
+# - $<CONFIG>/runtime 		(DLLs/SOs/PDBs)
 # - $<CONFIG>/exe			(executables and media)
 #
 # If $<CONFIG> == Release, then the directory structure doesn't begin with $<CONFIG>
@@ -251,9 +218,7 @@ function(nbl_install_headers_spec _HEADERS _BASE_HEADERS_DIR)
 	foreach (file ${_HEADERS})
 		file(RELATIVE_PATH dir ${_BASE_HEADERS_DIR} ${file})
 		get_filename_component(dir ${dir} DIRECTORY)
-		install(FILES ${file} DESTINATION include/${dir} CONFIGURATIONS Release COMPONENT Headers)
-		install(FILES ${file} DESTINATION debug/include/${dir} CONFIGURATIONS Debug COMPONENT Headers)
-		install(FILES ${file} DESTINATION relwithdebinfo/include/${dir} CONFIGURATIONS RelWithDebInfo COMPONENT Headers)
+		install(FILES ${file} DESTINATION include/${dir} COMPONENT Headers)
 	endforeach()
 endfunction()
 
@@ -266,19 +231,15 @@ function(nbl_install_headers _HEADERS)
 endfunction()
 
 function(nbl_install_file_spec _FILES _RELATIVE_DESTINATION)
-	install(FILES ${_FILES} DESTINATION include/${_RELATIVE_DESTINATION} CONFIGURATIONS Release COMPONENT Headers)
-	install(FILES ${_FILES} DESTINATION debug/include/${_RELATIVE_DESTINATION} CONFIGURATIONS Debug COMPONENT Headers)
-	install(FILES ${_FILES} DESTINATION relwithdebinfo/include/${_RELATIVE_DESTINATION} CONFIGURATIONS RelWithDebInfo COMPONENT Headers)
+	install(FILES ${_FILES} DESTINATION include/${_RELATIVE_DESTINATION} COMPONENT Headers)
 endfunction()
 
 function(nbl_install_file _FILES)
 	nbl_install_file_spec("${_FILES}" "")
 endfunction()
 
 function(nbl_install_dir_spec _DIR _RELATIVE_DESTINATION)
-	install(DIRECTORY ${_DIR} DESTINATION include/${_RELATIVE_DESTINATION} CONFIGURATIONS Release COMPONENT Headers)
-	install(DIRECTORY ${_DIR} DESTINATION debug/include/${_RELATIVE_DESTINATION} CONFIGURATIONS Debug COMPONENT Headers)
-	install(DIRECTORY ${_DIR} DESTINATION relwithdebinfo/include/${_RELATIVE_DESTINATION} CONFIGURATIONS RelWithDebInfo COMPONENT Headers)
+	install(DIRECTORY ${_DIR} DESTINATION include/${_RELATIVE_DESTINATION} COMPONENT Headers)
 endfunction()
 
 function(nbl_install_dir _DIR)
@@ -396,18 +357,6 @@ function(nbl_install_builtin_resources _TARGET_)
 	nbl_install_headers_spec("${_BUILTIN_RESOURCES_HEADERS_}" "${_BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY_}")
 endfunction()
 
-function(nbl_install_config_header _CONF_HDR_NAME)
-	nbl_get_conf_dir(dir_deb Debug)
-	nbl_get_conf_dir(dir_rel Release)
-	nbl_get_conf_dir(dir_relWithDebInfo RelWithDebInfo)
-	set(file_deb "${dir_deb}/${_CONF_HDR_NAME}")
-	set(file_rel "${dir_rel}/${_CONF_HDR_NAME}")
-	set(file_relWithDebInfo "${dir_relWithDebInfo}/${_CONF_HDR_NAME}")
-	install(FILES ${file_rel} DESTINATION include CONFIGURATIONS Release)
-	install(FILES ${file_deb} DESTINATION debug/include CONFIGURATIONS Debug)
-	install(FILES ${file_relWithDebInfo} DESTINATION relwithdebinfo/include CONFIGURATIONS RelWithDebInfo)
-endfunction()
-
 function(NBL_TEST_MODULE_INSTALL_FILE _NBL_FILEPATH_)
 	file(RELATIVE_PATH _NBL_REL_INSTALL_DEST_ "${NBL_ROOT_PATH}" "${_NBL_FILEPATH_}")
 	cmake_path(GET _NBL_REL_INSTALL_DEST_ PARENT_PATH _NBL_REL_INSTALL_DEST_)

include/nbl/config/BuildConfigOptions.h.in

@@ -2,23 +2,17 @@
 #define __NBL_BUILD_CONFIG_OPTIONS_H_INCLUDED__
 
 // TODO: figure out _ and _ suffixes and prefixes
-
-#cmakedefine _NBL_DEBUG
-#cmakedefine _NBL_RELWITHDEBINFO
-
-// architecture (TODO: rethink)
-#cmakedefine __NBL_COMPILE_WITH_ARM_SIMD_
+/*
+    DO NOT put any defines which are platform, toolset or architecture
+    specific, such defines go through CMake usage requirements and are
+    visible both in build & install interface, putting them in headers
+    breaks portable usage of the library
+*/
 
 // libraries
 #cmakedefine _NBL_COMPILE_WITH_GLI_
 #cmakedefine _NBL_COMPILE_WITH_OPEN_EXR_
 
-// OS
-#cmakedefine _NBL_PLATFORM_WINDOWS_
-#cmakedefine _NBL_PLATFORM_LINUX_
-#cmakedefine _NBL_PLATFORM_OSX_
-#cmakedefine _NBL_PLATFORM_ANDROID_
-
 // graphics API backend
 #cmakedefine _NBL_COMPILE_WITH_VULKAN_
 
@@ -32,10 +26,10 @@
 #cmakedefine _NBL_COMPILE_WITH_JPG_LOADER_
 #cmakedefine _NBL_COMPILE_WITH_PNG_LOADER_
 #cmakedefine _NBL_COMPILE_WITH_TGA_LOADER_
-#ifdef _NBL_COMPILE_WITH_OPEN_EXR_
+#ifdef _NBL_COMPILE_WITH_OPEN_EXR_ // ? TODO
 #cmakedefine _NBL_COMPILE_WITH_OPENEXR_LOADER_
 #endif
-#ifdef _NBL_COMPILE_WITH_GLI_
+#ifdef _NBL_COMPILE_WITH_GLI_ // ? TODO
 #cmakedefine _NBL_COMPILE_WITH_GLI_LOADER_
 #endif
 #cmakedefine _NBL_COMPILE_WITH_GLTF_LOADER_
@@ -47,10 +41,10 @@
 #cmakedefine _NBL_COMPILE_WITH_TGA_WRITER_
 #cmakedefine _NBL_COMPILE_WITH_JPG_WRITER_
 #cmakedefine _NBL_COMPILE_WITH_PNG_WRITER_
-#ifdef _NBL_COMPILE_WITH_OPEN_EXR_
+#ifdef _NBL_COMPILE_WITH_OPEN_EXR_ // ? TODO
 #cmakedefine _NBL_COMPILE_WITH_OPENEXR_WRITER_
 #endif
-#ifdef _NBL_COMPILE_WITH_GLI_
+#ifdef _NBL_COMPILE_WITH_GLI_ // ? TODO
 #cmakedefine _NBL_COMPILE_WITH_GLI_WRITER_
 #endif
 #cmakedefine _NBL_COMPILE_WITH_GLTF_WRITER_
@@ -65,12 +59,10 @@
 
 #cmakedefine _NBL_BUILD_DPL_
 
+// !
 // TODO: This has to disapppear from the main header and go to the OptiX extension header + config
 #cmakedefine OPTIX_INCLUDE_DIR "@OPTIX_INCLUDE_DIR@"
 
-// DXC compile flags
-#cmakedefine DXC_COMPILE_FLAGS "@DXC_COMPILE_FLAGS@"
-
 #if defined(_NBL_DEBUG) || defined(_NBL_RELWITHDEBINFO)
 #define _NBL_EG_PRFNT_LEVEL @_NBL_EG_PRFNT_LEVEL@
 #if _NBL_EG_PRFNT_LEVEL == 1
@@ -82,11 +74,6 @@
 #endif
 #endif
 
-#define NBL_BUILTIN_RESOURCES_DIRECTORY_PATH "@NBL_BUILTIN_RESOURCES_DIRECTORY_PATH@"
-#define SPIRV_BUILTIN_RESOURCES_DIRECTORY_PATH "@SPIRV_BUILTIN_RESOURCES_DIRECTORY_PATH@"
-#define BOOST_BUILTIN_RESOURCES_DIRECTORY_PATH "@BOOST_BUILTIN_RESOURCES_DIRECTORY_PATH@"
-#define DEVICEGEN_BUILTIN_RESOURCES_DIRECTORY_PATH "@DEVICEGEN_BUILTIN_RESOURCES_DIRECTORY_PATH@"
-
 // DLL exports
 #cmakedefine _NBL_SHARED_BUILD_
 #ifdef _NBL_SHARED_BUILD_
@@ -108,8 +95,14 @@
 #endif
 
 // any other target definitions for using Nabla as framework in another project
+
+// TODO: not this way, use CMake usage requirements!
+/*
+
 #ifndef __NBL_BUILDING_NABLA__
 #include "define.h"
 #endif // __NBL_BUILDING_NABLA__
 
+*/
+
 #endif // __NBL_BUILD_CONFIG_OPTIONS_H_INCLUDED__

include/nbl/system/ISystem.h

@@ -47,14 +47,6 @@ class NBL_API2 ISystem : public core::IReferenceCounted
                     future.set_result(value);
                 }
         };
-		
-		#ifndef NBL_EMBED_BUILTIN_RESOURCES
-        constexpr std::string_view getBuiltinResourcesDirectoryPath()
-        {
-            std::string_view retval = NBL_BUILTIN_RESOURCES_DIRECTORY_PATH;
-            return retval;
-        }
-		#endif
 
         //
         inline void addArchiveLoader(core::smart_refctd_ptr<IArchiveLoader>&& loader)

src/nbl/CMakeLists.txt

@@ -79,11 +79,21 @@ if(NBL_BUILD_ANDROID)
 	set(NBL_BUILD_MITSUBA_LOADER OFF CACHE BOOL "Android doesn't need this loader, if you want it, pay us.'" FORCE)
 endif()
 
-nbl_generate_conf_files()
+if(NBL_FAST_MATH)
+	set(__NBL_FAST_MATH 1) # this could be in BUILD_INTERFACE, the feature is header only and currently install consumer is forced to use what we used at configure time with no option to toggle it
+	# it should be called _NBL_COMPILE_WITH_FAST_MATH to let user known the lib itself was compiled with the feature and __NBL_FAST_MATH should be separate thing to let control it with install build
+endif()
+
+if(NBL_TARGET_ARCH_ARM)
+	# this should be PRIVATE or at least scoped to build interface only (as currently)
+	# list(APPEND PUBLIC_DEFINITIONS $<BUILD_INTERFACE:_NBL_TARGET_ARCH_ARM_>) # TODO: uncomment in the future
+endif()
 
-nbl_get_conf_dir(NABLA_CONF_DIR_DEBUG Debug)
-nbl_get_conf_dir(NABLA_CONF_DIR_RELEASE Release)
-nbl_get_conf_dir(NABLA_CONF_DIR_RELWITHDEBINFO RelWithDebInfo)
+set(CONFIG_DIRECOTORY "${CMAKE_CURRENT_BINARY_DIR}/include/nbl/config")
+set(CONFIG_OUTPUT "${CONFIG_DIRECOTORY}/BuildConfigOptions.h")
+configure_file("${NBL_ROOT_PATH}/include/nbl/config/BuildConfigOptions.h.in" "${CONFIG_DIRECOTORY}/.int/BuildConfigOptions.h.conf")
+file(GENERATE OUTPUT "${CONFIG_OUTPUT}" INPUT "${CONFIG_DIRECOTORY}/.int/BuildConfigOptions.h.conf")
+nbl_install_file_spec("${CONFIG_OUTPUT}" nbl/config)
 
 if (NBL_COMPILE_WITH_CUDA)
 	message(STATUS "Building with CUDA interop")
@@ -93,10 +103,6 @@ if (NBL_COMPILE_WITH_CUDA)
 	endif()
 endif()
 
-#set(_NBL_TARGET_ARCH_ARM_ ${NBL_TARGET_ARCH_ARM}) #uncomment in the future
-
-set(__NBL_FAST_MATH ${NBL_FAST_MATH})
-
 # a little bit of globbing for headers never hurt anyone
 file(GLOB_RECURSE TEMP_GLOB_RES "${NBL_ROOT_PATH}/include/*.h")
 set(NABLA_HEADERS_PUBLIC ${NABLA_HEADERS_PUBLIC} ${TEMP_GLOB_RES})
@@ -322,12 +328,7 @@ set(PUBLIC_INCLUDE_DIRS
 	${CMAKE_BINARY_DIR}/3rdparty/zlib 			# for dynamically generated zconf.h
 	${JPEG_STATIC_BINARY_DIR} 					# for dynamically generated pnglibconf.h
 	${PNG_STATIC_BINARY_DIR} 					# for dynamically generated jconfig.h
-	
-	# -> TODO: 
-	"$<$<CONFIG:DEBUG>:${NABLA_CONF_DIR_DEBUG}>"
-	"$<$<CONFIG:RELEASE>:${NABLA_CONF_DIR_RELEASE}>"
-	"$<$<CONFIG:RELWITHDEBINFO>:${NABLA_CONF_DIR_RELWITHDEBINFO}>"
-	# <-
+	${CONFIG_DIRECOTORY}						# Nabla config directory
 )
 
 # just gather all the header files and later put them into project so it's easy to search for things using IDE
@@ -358,6 +359,31 @@ else()
 	)
 endif()
 
+# from old build config template:
+# 
+# // architecture (TODO: rethink)
+# cmakedefine __NBL_COMPILE_WITH_ARM_SIMD_ 					# <- never used, and if even so - should be PRIVATE
+# 
+# // DXC compile flags
+# cmakedefine DXC_COMPILE_FLAGS "@DXC_COMPILE_FLAGS@" 		# <- never used, and if even so - should be PRIVATE
+
+# usage requirements
+set(PUBLIC_DEFINITIONS
+	# configs
+	$<$<CONFIG:Debug>:_NBL_DEBUG>
+	$<$<CONFIG:RelWithDebInfo>:_NBL_RELWITHDEBINFO>
+
+	# https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_NAME.html#system-names-known-to-cmake
+	$<$<PLATFORM_ID:Windows>:_NBL_PLATFORM_WINDOWS_>
+    $<$<PLATFORM_ID:Linux>:_NBL_PLATFORM_LINUX_>
+    $<$<PLATFORM_ID:Darwin>:_NBL_PLATFORM_OSX_>
+    $<$<PLATFORM_ID:Android>:_NBL_PLATFORM_ANDROID_>
+)
+
+target_compile_definitions(Nabla
+	PUBLIC ${PUBLIC_DEFINITIONS}
+)
+
 nbl_adjust_flags(TARGET Nabla MAP_RELEASE Release MAP_RELWITHDEBINFO RelWithDebInfo MAP_DEBUG Debug)
 nbl_adjust_definitions()
 
@@ -661,6 +687,7 @@ if(NBL_EMBED_BUILTIN_RESOURCES)
 	function(NBL_HOOK_INTERNAL_BUILTIN_RESOURCES NBL_TARGETS)	
 		foreach(NBL_TARGET IN LISTS NBL_TARGETS)
 			get_target_property(_INTERNAL_BR_OUTPUT_INCLUDE_SEARCH_DIRECTORY_ ${NBL_TARGET} BUILTIN_RESOURCES_INCLUDE_SEARCH_DIRECTORY)
+			target_compile_definitions(${NBL_TARGET} PUBLIC "$<TARGET_PROPERTY:Nabla,INTERFACE_COMPILE_DEFINITIONS>") # workaround because must use Nabla headers without linking Nabla to itself..
 			target_include_directories(${NBL_TARGET} PUBLIC "$<TARGET_PROPERTY:Nabla,INCLUDE_DIRECTORIES>")
 			target_include_directories(Nabla PRIVATE "${_INTERNAL_BR_OUTPUT_INCLUDE_SEARCH_DIRECTORY_}")
 		endforeach()
@@ -689,6 +716,14 @@ if(NBL_EMBED_BUILTIN_RESOURCES)
 	get_target_property(_BUILTIN_RESOURCES_BUNDLE_ARCHIVE_ABSOLUTE_PATH_ nblBuiltinResourceData BUILTIN_RESOURCES_BUNDLE_ARCHIVE_ABSOLUTE_PATH)
 	get_target_property(NABLA_RESOURCES_TO_EMBED_PUBLIC nblBuiltinResourceData BUILTIN_RESOURCES)
 
+	# this is only visible in cpps and should never leak to public interface
+	target_compile_definitions(Nabla
+		PRIVATE NBL_BUILTIN_RESOURCES_DIRECTORY_PATH="${NBL_BUILTIN_RESOURCES_DIRECTORY_PATH}"
+		PRIVATE SPIRV_BUILTIN_RESOURCES_DIRECTORY_PATH="${SPIRV_BUILTIN_RESOURCES_DIRECTORY_PATH}"
+		PRIVATE BOOST_BUILTIN_RESOURCES_DIRECTORY_PATH="${BOOST_BUILTIN_RESOURCES_DIRECTORY_PATH}"
+		PRIVATE DEVICEGEN_BUILTIN_RESOURCES_DIRECTORY_PATH="${DEVICEGEN_BUILTIN_RESOURCES_DIRECTORY_PATH}"
+	)
+
 	target_sources(Nabla PRIVATE 
 		${NABLA_RESOURCES_TO_EMBED_PUBLIC}
 	)
@@ -762,7 +797,6 @@ propagate_changed_variables_to_parent_scope()
 
 nbl_install_headers("${NABLA_HEADERS_PUBLIC}")
 nbl_install_file_spec("${NBL_ROOT_PATH_BINARY}/include/nbl/builtin/builtinResources.h" "nbl/builtin")
-nbl_install_config_header(BuildConfigOptions.h)
 
 if(NBL_EMBED_BUILTIN_RESOURCES)
 	nbl_install_builtin_resources(nblBuiltinResourceData)
@@ -773,10 +807,15 @@ endif()
 set_target_properties(Nabla PROPERTIES DEBUG_POSTFIX _debug)
 set_target_properties(Nabla PROPERTIES RELWITHDEBINFO_POSTFIX _relwithdebinfo)
 
+set(INSTALL_INCLUDE
+	include
+	include/nbl/config # TMP, to let #include "BuildConfigOptions.h" work
+)
+
 # target_include_directories for Nabla with PUBLIC *must not* be called after following
 target_include_directories(Nabla PUBLIC
 	"$<BUILD_INTERFACE:${PUBLIC_INCLUDE_DIRS}>"
-	"$<INSTALL_INTERFACE:include>"
+	"$<INSTALL_INTERFACE:${INSTALL_INCLUDE}>"
 )
 
 if(NBL_STATIC_BUILD)

tools/xxHash256/CMakeLists.txt

@@ -8,6 +8,7 @@ target_include_directories(${EXECUTABLE_NAME} PUBLIC
 	$<TARGET_PROPERTY:argparse,INTERFACE_INCLUDE_DIRECTORIES>
 	$<TARGET_PROPERTY:Nabla,INTERFACE_INCLUDE_DIRECTORIES> # only for xxHash256 include directory, we DO NOT want to link it nor use it
 )
+target_compile_definitions(${EXECUTABLE_NAME} PUBLIC "$<TARGET_PROPERTY:Nabla,INTERFACE_COMPILE_DEFINITIONS>") # workaround because must use Nabla headers without linking Nabla to itself..
 
 nbl_adjust_flags(MAP_RELEASE Release MAP_RELWITHDEBINFO RelWithDebInfo MAP_DEBUG Debug)
 nbl_adjust_definitions()