minor adjustments and improvements

Author: devshgraphicsprogramming

examples_tests

@@ -12,7 +12,7 @@ namespace nbl::system
 class CColoredStdoutLoggerANSI : public IThreadsafeLogger
 {
   public:
-    inline CColoredStdoutLoggerANSI(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::defaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
+    inline CColoredStdoutLoggerANSI(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::DefaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
 
   private:
     // more info about how this works: https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797

include/nbl/system/CColoredStdoutLoggerANSI.h

@@ -46,7 +46,7 @@ class NBL_API2 CColoredStdoutLoggerWin32 : public IThreadsafeLogger
 		}
 
 	public:
-		CColoredStdoutLoggerWin32(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::defaultLogMask());
+		CColoredStdoutLoggerWin32(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::DefaultLogMask());
 };
 
 #endif

include/nbl/system/CColoredStdoutLoggerWin32.h

@@ -10,7 +10,7 @@ namespace nbl::system
 class CFileLogger : public IThreadsafeLogger
 {
 	public:
-		CFileLogger(core::smart_refctd_ptr<IFile>&& _file, const bool append, const core::bitflag<E_LOG_LEVEL> logLevelMask=ILogger::defaultLogMask())
+		CFileLogger(core::smart_refctd_ptr<IFile>&& _file, const bool append, const core::bitflag<E_LOG_LEVEL> logLevelMask=ILogger::DefaultLogMask())
 			: IThreadsafeLogger(logLevelMask), m_file(std::move(_file)), m_pos(append ? m_file->getSize():0ull)
 		{
 		}

include/nbl/system/CFileLogger.h

@@ -10,7 +10,7 @@ namespace nbl::system
 class CStdoutLogger : public IThreadsafeLogger
 {
 	public:
-		CStdoutLogger(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::defaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
+		CStdoutLogger(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::DefaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
 
 	protected:
 		virtual void threadsafeLog_impl(const std::string_view& fmt, E_LOG_LEVEL logLevel, va_list args) override

include/nbl/system/CStdoutLogger.h

@@ -10,7 +10,7 @@ namespace nbl::system
 class CStdoutLoggerAndroid : public IThreadsafeLogger
 {
 	public:
-		CStdoutLoggerAndroid(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::defaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
+		CStdoutLoggerAndroid(core::bitflag<E_LOG_LEVEL> logLevelMask = ILogger::DefaultLogMask()) : IThreadsafeLogger(logLevelMask) {}
 
 	private:
 		void threadsafeLog_impl(const std::string_view& fmt, E_LOG_LEVEL logLevel, va_list args) override;

include/nbl/system/CStdoutLoggerAndroid.h

@@ -94,7 +94,7 @@ class IApplicationFramework : public core::IReferenceCounted
 
         // Some platforms are weird, and you can't really do anything with the system unless you have some magical object that gets passed to the platform's entry point.
         // Therefore the specific `CPLATFORMSystem` is uncreatable out of thin air so you need to take an outside provided one
-        virtual bool onAppInitialized(core::smart_refctd_ptr<ISystem>&& system=nullptr) {onAppInitialized_impl(std::move(system)); return true;}
+        virtual bool onAppInitialized(core::smart_refctd_ptr<ISystem>&& system=nullptr) {setSystem(std::move(system)); onAppInitialized_impl(); return true;}
         virtual bool onAppTerminated() {return true;}
 
         virtual void workLoopBody() = 0;
@@ -104,7 +104,7 @@ class IApplicationFramework : public core::IReferenceCounted
         ~IApplicationFramework() {}
 
         // DEPRECATED
-        virtual void onAppInitialized_impl(core::smart_refctd_ptr<ISystem>&& system) {assert(false);}
+        virtual void onAppInitialized_impl() {assert(false);}
         virtual void onAppTerminated_impl() {assert(false);}
 
         // for platforms with cmdline args

include/nbl/system/IApplicationFramework.h

@@ -28,7 +28,8 @@ class ILogger : public core::IReferenceCounted
 			ELL_INFO = 2,
 			ELL_WARNING = 4,
 			ELL_PERFORMANCE = 8,
-			ELL_ERROR = 16
+			ELL_ERROR = 16,
+			ELL_ALL = 31
 		};
 
 		inline void log(const std::string_view& fmtString, E_LOG_LEVEL logLevel = ELL_DEBUG, ...)
@@ -47,8 +48,9 @@ class ILogger : public core::IReferenceCounted
 			return m_logLevelMask;
 		}
 
+		NBL_API2 static core::bitflag<E_LOG_LEVEL> DefaultLogMask();
+
 	protected:
-		NBL_API2 static core::bitflag<E_LOG_LEVEL> defaultLogMask();
 
 		ILogger(core::bitflag<E_LOG_LEVEL> logLevelMask) : m_logLevelMask(logLevelMask) {}
 

include/nbl/system/ILogger.h

@@ -36,6 +36,7 @@
 #include "nbl/video/utilities/CSubpassKiln.h"
 #include "nbl/video/utilities/IUtilities.h"
 #include "nbl/video/utilities/IGPUObjectFromAssetConverter.h"
+#include "nbl/video/utilities/SPhysicalDeviceFilter.h"
 
 //VT
 //#include "nbl/video/CGPUMeshPackerV2.h"

include/nbl/video/declarations.h

@@ -47,6 +47,18 @@ namespace nbl::video
         SurfaceCompatibility* requiredSurfaceCompatibilities = nullptr;
         uint32_t requiredSurfaceCompatibilitiesCount = 0u;
 
+
+        // sift through multiple devices
+        core::set<const IPhysicalDevice*> operator()(core::SRange<const IPhysicalDevice* const> physicalDevices) const
+        {
+		    core::set<const IPhysicalDevice*> ret;
+		    for (auto& physDev : physicalDevices)
+			if (meetsRequirements(physDev))
+				ret.insert(physDev);
+            return ret;
+        }
+
+        // check one device
         bool meetsRequirements(const IPhysicalDevice * const physicalDevice) const
         {
             const auto& properties = physicalDevice->getProperties();