Merge pull request #172 from Devsh-Graphics-Programming/new_tgmath

New tgmath

Author: devshgraphicsprogramming

22_CppCompat/CIntrinsicsTester.h

@@ -0,0 +1,16 @@
+//// Copyright (C) 2023-2024 - DevSH Graphics Programming Sp. z O.O.
+//// This file is part of the "Nabla Engine".
+//// For conditions of distribution and use, see copyright notice in nabla.h
+#pragma shader_stage(compute)
+
+#include "common.hlsl"
+
+[[vk::binding(0, 0)]] RWStructuredBuffer<IntrinsicsIntputTestValues> inputTestValues;
+[[vk::binding(1, 0)]] RWStructuredBuffer<IntrinsicsTestValues> outputTestValues;
+
+[numthreads(256, 1, 1)]
+void main(uint3 invocationID : SV_DispatchThreadID)
+{
+    if(invocationID.x == 0)
+        outputTestValues[0].fillTestValues(inputTestValues[0]);
+}

22_CppCompat/CTgmathTester.h

@@ -0,0 +1,16 @@
+//// Copyright (C) 2023-2024 - DevSH Graphics Programming Sp. z O.O.
+//// This file is part of the "Nabla Engine".
+//// For conditions of distribution and use, see copyright notice in nabla.h
+#pragma shader_stage(compute)
+
+#include "common.hlsl"
+
+[[vk::binding(0, 0)]] RWStructuredBuffer<TgmathIntputTestValues> inputTestValues;
+[[vk::binding(1, 0)]] RWStructuredBuffer<TgmathTestValues> outputTestValues;
+
+[numthreads(256, 1, 1)]
+void main(uint3 invocationID : SV_DispatchThreadID)
+{
+    if(invocationID.x == 0)
+        outputTestValues[0].fillTestValues(inputTestValues[0]);
+}

22_CppCompat/ITester.h

@@ -11,6 +11,8 @@
 
 #include "app_resources/common.hlsl"
 
+#include "CTgmathTester.h"
+#include "CIntrinsicsTester.h"
 
 using namespace nbl::core;
 using namespace nbl::hlsl;
@@ -56,11 +58,31 @@ class CompatibilityTest final : public MonoDeviceApplication, public MonoAssetMa
             return false;
         if (!asset_base_t::onAppInitialized(std::move(system)))
             return false;
-    
+
+        ITester::PipelineSetupData pplnSetupData;
+        pplnSetupData.device = m_device;
+        pplnSetupData.api = m_api;
+        pplnSetupData.assetMgr = m_assetMgr;
+        pplnSetupData.logger = m_logger;
+        pplnSetupData.physicalDevice = m_physicalDevice;
+        pplnSetupData.computeFamilyIndex = getComputeQueue()->getFamilyIndex();
+
+        {
+            CTgmathTester tgmathTester;
+            pplnSetupData.testShaderPath = "app_resources/tgmathTest.comp.hlsl";
+            tgmathTester.setupPipeline<TgmathIntputTestValues, TgmathTestValues>(pplnSetupData);
+            tgmathTester.performTests();
+        }
+        {
+            CIntrinsicsTester intrinsicsTester;
+            pplnSetupData.testShaderPath = "app_resources/intrinsicsTest.comp.hlsl";
+            intrinsicsTester.setupPipeline<IntrinsicsIntputTestValues, IntrinsicsTestValues>(pplnSetupData);
+            intrinsicsTester.performTests();
+        }
+
         m_queue = m_device->getQueue(0, 0);
         m_commandPool = m_device->createCommandPool(m_queue->getFamilyIndex(), IGPUCommandPool::CREATE_FLAGS::RESET_COMMAND_BUFFER_BIT);
         m_commandPool->createCommandBuffers(IGPUCommandPool::BUFFER_LEVEL::PRIMARY, { &m_cmdbuf,1 }, smart_refctd_ptr(m_logger));
-        
 
         smart_refctd_ptr<IGPUShader> shader;
         {
@@ -211,7 +233,6 @@ class CompatibilityTest final : public MonoDeviceApplication, public MonoAssetMa
         constexpr auto StartedValue = 0;
 
         smart_refctd_ptr<ISemaphore> progress = m_device->createSemaphore(StartedValue);
-        
 
         m_cmdbuf->reset(IGPUCommandBuffer::RESET_FLAGS::RELEASE_RESOURCES_BIT);
         m_cmdbuf->begin(IGPUCommandBuffer::USAGE::ONE_TIME_SUBMIT_BIT);
@@ -562,7 +583,7 @@ void cpu_tests()
     auto zero = cross(x,x);
     auto lenX2 = dot(x,x);
     //auto z_inv = inverse(z); //busted return type conversion
-    auto mid = lerp(x,x,0.5f);
+    auto mid = nbl::hlsl::mix(x,x,float32_t3(0.5f));
     //auto w = transpose(y); //also busted
 
 
@@ -761,8 +782,8 @@ void cpu_tests()
     TEST_CMATH(fdim, 2, type) \
 
 
-    TEST_CMATH_FOR_TYPE(float32_t)
-    TEST_CMATH_FOR_TYPE(float64_t)
+    //TEST_CMATH_FOR_TYPE(float32_t)
+    //TEST_CMATH_FOR_TYPE(float64_t)
 #endif
     std::cout << "cpu tests done\n";
 }

22_CppCompat/app_resources/common.hlsl

@@ -1,5 +1,4 @@
 #include "fft_mirror_common.hlsl"
-#include "nbl/builtin/hlsl/bitreverse.hlsl"
 
 [[vk::binding(3, 0)]] Texture2DArray<float32_t2> kernelChannels;
 [[vk::binding(1, 0)]] SamplerState samplerState;

22_CppCompat/app_resources/intrinsicsTest.comp.hlsl

@@ -1,6 +1,5 @@
 #include "fft_mirror_common.hlsl"
 #include "nbl/builtin/hlsl/colorspace/encodeCIEXYZ.hlsl"
-#include "nbl/builtin/hlsl/bitreverse.hlsl"
 
 [[vk::binding(2, 0)]] RWTexture2DArray<float32_t2> kernelChannels;
 

22_CppCompat/app_resources/tgmathTest.comp.hlsl

@@ -16,7 +16,7 @@ bool Hatch::Segment::isStraightLineConstantMajor() const
 		p1 = originalBezier->P1[major], 
 		p2 = originalBezier->P2[major];
 	//assert(p0 <= p1 && p1 <= p2); (PRECISION ISSUES ARISE ONCE MORE)
-	return abs(p1 - p0) <= core::exp2(-24.0) && abs(p2 - p0) <= exp(-24);
+	return abs(p1 - p0) <= core::exp2(-24.0) && abs(p2 - p0) <= hlsl::exp(-24.0f);
 }
 
 std::array<double, 2> Hatch::Segment::intersect(const Segment& other) const