fix for nan samples

keptsecret · keptsecret · commit ab0aa1231e1f · 2025-03-17T13:56:17.000+07:00
diff --git a/31_HLSLPathTracer/app_resources/hlsl/common.hlsl b/31_HLSLPathTracer/app_resources/hlsl/common.hlsl
@@ -588,7 +588,8 @@ struct Shape<PST_RECTANGLE>
                 if (solidAngle > numeric_limits<float>::min)
                 {
                     float32_t3 sph_sample = sphUv[0] * edge0 + sphUv[1] * edge1 + offset;
-                    L = nbl::hlsl::normalize(sph_sample - origin);
+                    L = sph_sample - origin;
+                    L = hlsl::mix<float32_t3>(nbl::hlsl::normalize(L), (float32_t3)0.0, hlsl::abs<float32_t3>(L) > (float32_t3)numeric_limits<float>::min); // TODO? sometimes L is vec3(0), find cause
                     pdf = 1.f / solidAngle;
                 }
                 else

Original file line number	Diff line number	Diff line change
`@@ -588,7 +588,8 @@ struct Shape<PST_RECTANGLE>`
`588`	`588`	`if (solidAngle > numeric_limits<float>::min)`
`589`	`589`	`{`
`590`	`590`	`float32_t3 sph_sample = sphUv[0] * edge0 + sphUv[1] * edge1 + offset;`
`591`		`- L = nbl::hlsl::normalize(sph_sample - origin);`
	`591`	`+ L = sph_sample - origin;`
	`592`	`+ L = hlsl::mix<float32_t3>(nbl::hlsl::normalize(L), (float32_t3)0.0, hlsl::abs<float32_t3>(L) > (float32_t3)numeric_limits<float>::min); // TODO? sometimes L is vec3(0), find cause`
`592`	`593`	`pdf = 1.f / solidAngle;`
`593`	`594`	`}`
`594`	`595`	`else`