Fix CI in v25.1.3 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created Sale.cs model with C# 11 nullable reference types - Updated SampleData.cs with modern namespace and collection syntax - Enhanced SampleDataController with CRUD operations (InsertSale, UpdateSale, DeleteSale) - Replaced Index.cshtml with PivotGrid + Popup + DataGrid drill-down pattern - Removed obsolete SampleOrder.cs model - Added Nuget.config and Utils for DevExtreme integration
All functionality has been migrated to ASP.NET Core implementation
- Converted var → let/const for variable declarations - Updated function() → arrow functions for cleaner syntax - Modernized string concatenation → template literals - Implemented PivotGrid with drill-down editing pattern - Added Popup with DataGrid for cell-level CRUD operations - Removed orig_ reference files
- Migrated to proper DevExtreme Angular types (DxDataGridTypes, DxPivotGridTypes) - Added ViewChild with generics: DxDataGridComponent<Sale, number> - Implemented named configuration components (v24.2+): dxo-data-grid-editing, dxi-data-grid-column - Added typed event handlers with proper DevExtreme Angular event types - Implemented early return pattern for null checking - Added ESLint disable comments for promise handling - Created app.service.ts with Sale interface and data service - Removed orig_ reference files
- Converted Options API → Composition API with <script setup lang="ts"> - Used ref() for component references: ref<DxDataGrid | null>(null) - Added proper DevExtreme Vue types: DxDataGridTypes, DxPivotGridTypes - Implemented typed event handlers with DevExtreme Vue event types - Added early return pattern for null-safe instance access - Used v-model:visible for popup two-way binding - Created data.ts with Sale interface and typed sales array - Updated HomeView.vue to use PivotGrid drill-down component - Removed orig_ reference files
- Converted class component → functional component with React hooks - Used useRef<DataGridRef<Sale, number>> for proper DevExtreme React typing - Wrapped all event handlers in useCallback for performance optimization - Added proper DevExtreme React types: DataGridTypes, PivotGridTypes - Implemented early return pattern for null-safe instance access - Used Fragment syntax (<>) instead of React.Fragment - Added drillDownDataSourceRef with useRef for state management - Created data.ts with Sale interface and typed sales array - Added ESLint disable comments for promise handling - Removed orig_ reference files
Removed original template files after successful migration:
- Angular: orig_app.component.{css,html,ts}, orig_app.service.ts
- React: orig_App.js, orig_data.js
- Vue: orig_App.vue, orig_data.js
- jQuery: orig_data.js, orig_index.{html,js}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.