Remove pr_number from BotError and BotEnsureRemovedFromProject (#343)

Update snapshots

Author: jablko

src/_tests/fixtures/43960-post-close/derived.json

@@ -1,7 +1,6 @@
 {
   "type": "remove",
   "now": "2020-04-30T19:01:56.000Z",
-  "pr_number": 43960,
   "message": "PR is not active",
   "isDraft": false
 }

src/_tests/fixtures/44105/derived.json

@@ -1,7 +1,5 @@
 {
   "type": "remove",
   "now": "2020-04-28T22:49:39.000Z",
-  "pr_number": 44105,
-  "message": "PR is not active",
-  "isDraft": false
+  "message": "PR is not active"
 }

src/_tests/fixtures/44256/derived.json

@@ -1,7 +1,6 @@
 {
   "type": "remove",
   "now": "2020-04-30T19:07:55.000Z",
-  "pr_number": 44256,
   "message": "PR is not active",
   "isDraft": false
 }

src/_tests/fixtures/44290/derived.json

@@ -1,7 +1,6 @@
 {
   "type": "remove",
   "now": "2020-04-28T16:41:44.000Z",
-  "pr_number": 44290,
   "message": "PR is a draft",
   "isDraft": true
 }

src/_tests/fixtures/45982/derived.json

@@ -2,6 +2,5 @@
   "type": "error",
   "now": "2020-07-11T20:41:49.000Z",
   "message": "error parsing owners: At 1:1 : Expected /\\/\\/ Type definitions for (non-npm package )?/",
-  "pr_number": 45982,
   "author": "dasa"
 }

src/pr-info.ts

@@ -30,15 +30,13 @@ export type PopularityLevel =
 interface BotError {
     readonly type: "error";
     readonly now: Date;
-    readonly pr_number: number;
     readonly message: string;
     readonly author: string | undefined;
 }
 
 interface BotEnsureRemovedFromProject {
     readonly type: "remove";
     readonly now: Date;
-    readonly pr_number: number;
     readonly message: string;
     readonly isDraft: boolean;
 }
@@ -185,13 +183,13 @@ export async function deriveStateForPR(
     getDownloads = getMonthlyDownloadCount,
     now = new Date(),
 ): Promise<BotResult>  {
-    if (prInfo.author == null) return botError(prInfo.number, "PR author does not exist");
+    if (prInfo.author == null) return botError("PR author does not exist");
 
-    if (prInfo.isDraft) return botEnsureRemovedFromProject(prInfo.number, "PR is a draft", true);
-    if (prInfo.state !== PullRequestState.OPEN) return botEnsureRemovedFromProject(prInfo.number, "PR is not active", false);
+    if (prInfo.isDraft) return botEnsureRemovedFromProject("PR is a draft");
+    if (prInfo.state !== PullRequestState.OPEN) return botEnsureRemovedFromProject("PR is not active");
 
     const headCommit = getHeadCommit(prInfo);
-    if (headCommit == null) return botError(prInfo.number, "No head commit found");
+    if (headCommit == null) return botError("No head commit found");
 
     const author = prInfo.author.login;
     const isFirstContribution = prInfo.authorAssociation === CommentAuthorAssociation.FIRST_TIME_CONTRIBUTOR;
@@ -207,7 +205,7 @@ export async function deriveStateForPR(
     const pkgInfoEtc = await getPackageInfosEtc(
         noNullish(prInfo.files?.nodes).map(f => f.path).sort(),
         prInfo.headRefOid, fetchFile, async name => await getDownloads(name, lastPushDate));
-    if (pkgInfoEtc instanceof Error) return botError(prInfo.number, pkgInfoEtc.message);
+    if (pkgInfoEtc instanceof Error) return botError(pkgInfoEtc.message);
     const { pkgInfo, popularityLevel } = pkgInfoEtc;
 
     const reviews = getReviews(prInfo);
@@ -236,12 +234,12 @@ export async function deriveStateForPR(
         ...getCIResult(headCommit.checkSuites)
     };
 
-    function botError(pr_number: number, message: string): BotError {
-        return { type: "error", now, message, pr_number, author: prInfo.author?.login };
+    function botError(message: string): BotError {
+        return { type: "error", now, message, author: prInfo.author?.login };
     }
 
-    function botEnsureRemovedFromProject(pr_number: number, message: string, isDraft: boolean): BotEnsureRemovedFromProject {
-        return { type: "remove", now, pr_number, message, isDraft };
+    function botEnsureRemovedFromProject(message: string): BotEnsureRemovedFromProject {
+        return { type: "remove", now, message, isDraft: prInfo.isDraft };
     }
 }