DI: relax upper bound for reported long method duration #5113
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
approved these changes
Dec 5, 2025
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
Timing-based tests and CI can be a big pain. If this reoccurs, check if there's any background threads and maybe disable GC for the test duration, to make sure Ruby really doesn't decide to do the wrong things and the wrong time :)
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: df629ef | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
p-datadog
pushed a commit
that referenced
this pull request
Dec 8, 2025
* master: (523 commits) DI: relax upper bound for reported long method duration (#5113) Change development guide to use Ruby 3.4 by default (#5112) Fix exception in RC on OpenFeature::Engine absence [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19996135509 [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/19996155319 Add ruby guikld to all dsm files add DSM to codeowners feat: add process tags to traces (#5033) DEBUG-3558 DI: chunk snapshot payloads (#5086) CI: enable push_to_test_optimization unless this is a pull request from a fork fix steep checks [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19827679824 [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/19827296218 Add test to verify consumer backlog serialization with kafka_commit tag Remove one diagnostic output Install rubygems Add diagnostic steps Use default rubygems+bundler for each Ruby version Revert "Disable profiling specs for 4.0" Use git `datadog-ruby_core_source` having 4.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increases the upper bound that the "long_method" is expected to take from 1 to 4 seconds.
Motivation:
CI has a run where the method took 1.8 seconds:
https://github.com/DataDog/dd-trace-rb/actions/runs/19936903071/job/57164209793?pr=5109
Change log entry
None
Additional Notes:
How to test the change?