Skip to content

Commit 7451e84

Browse files
authored
ci: increase otel-span RSS SLOs (#14976)
## Description Memory usage on `main` is just above the threshold. This PR increases the SLO for now. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes The Span add metric/tag benchmarks also use a ton of memory, their SLOs are almost 1gb. We are probably not clearing spans from span aggregator or something between loops, meaning the amount of memory used is dependent on how many loops/iterations pyperf decides to run and not the actual memory usage of the library.
1 parent 0b0f0d3 commit 7451e84

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -799,11 +799,11 @@ experiments:
799799
- name: otelspan-add-metrics
800800
thresholds:
801801
- execution_time < 344.80 ms
802-
- max_rss_usage < 630.00 MB
802+
- max_rss_usage < 675.00 MB
803803
- name: otelspan-add-tags
804804
thresholds:
805805
- execution_time < 314.00 ms
806-
- max_rss_usage < 630.00 MB
806+
- max_rss_usage < 675.00 MB
807807
- name: otelspan-get-context
808808
thresholds:
809809
- execution_time < 92.35 ms

0 commit comments

Comments
 (0)