chore(profiling): suggestions from review

KowalskiThomas · KowalskiThomas · commit 71857933dcf1 · 2025-11-20T11:16:35.000+01:00
diff --git a/ddtrace/internal/datadog/profiling/stack_v2/echion/echion/threads.h b/ddtrace/internal/datadog/profiling/stack_v2/echion/echion/threads.h
@@ -190,10 +190,9 @@ ThreadInfo::unwind(PyThreadState* tstate)
 {
     unwind_python_stack(tstate);
     if (asyncio_loop) {
-        auto unwind_tasks_success = unwind_tasks();
-        if (!unwind_tasks_success) {
-            // If we fail, that's OK
-        }
+        // unwind_tasks returns a [[nodiscard]] Result<void>.
+        // We cast it to void to ignore failures.
+        (void)unwind_tasks();
     }
 
     // We make the assumption that gevent and asyncio are not mixed

Original file line number	Diff line number	Diff line change
`@@ -190,10 +190,9 @@ ThreadInfo::unwind(PyThreadState* tstate)`
`190`	`190`	`{`
`191`	`191`	`unwind_python_stack(tstate);`
`192`	`192`	`if (asyncio_loop) {`
`193`		`- auto unwind_tasks_success = unwind_tasks();`
`194`		`- if (!unwind_tasks_success) {`
`195`		`- // If we fail, that's OK`
`196`		`- }`
	`193`	`+ // unwind_tasks returns a [[nodiscard]] Result<void>.`
	`194`	`+ // We cast it to void to ignore failures.`
	`195`	`+ (void)unwind_tasks();`
`197`	`196`	`}`
`198`	`197`
`199`	`198`	`// We make the assumption that gevent and asyncio are not mixed`