Skip to content

Commit e444714

Browse files
committed
trim comments
1 parent 0d5bf60 commit e444714

File tree

4 files changed

+0
-15
lines changed

4 files changed

+0
-15
lines changed

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/FlagsClient.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,6 @@ interface FlagsClient {
432432

433433
val precomputeMapper = PrecomputeMapper(featureSdkCore.internalLogger)
434434

435-
// Create shared channel for state change notifications
436435
val flagStateChannel = FlagsStateChannel(
437436
subscription = DDCoreSubscription.create()
438437
)

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/FlagsStateChannel.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,10 @@ internal class FlagsStateChannel(
6363
notifyState(FlagsClientState.ERROR, error)
6464
}
6565

66-
/**
67-
* Registers a listener to receive state change notifications.
68-
*
69-
* @param listener the listener to register
70-
*/
7166
fun addListener(listener: FlagsStateListener) {
7267
subscription.addListener(listener)
7368
}
7469

75-
/**
76-
* Unregisters a previously registered listener.
77-
*
78-
* @param listener the listener to unregister
79-
*/
8070
fun removeListener(listener: FlagsStateListener) {
8171
subscription.removeListener(listener)
8272
}

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/NoOpFlagsClient.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,15 +127,13 @@ internal class NoOpFlagsClient(
127127
* @param listener Ignored listener.
128128
*/
129129
override fun addStateListener(listener: FlagsStateListener) {
130-
// No-op: listeners are not supported on NoOpFlagsClient
131130
}
132131

133132
/**
134133
* No-op implementation that ignores listener removal.
135134
* @param listener Ignored listener.
136135
*/
137136
override fun removeStateListener(listener: FlagsStateListener) {
138-
// No-op: listeners are not supported on NoOpFlagsClient
139137
}
140138

141139
/**

features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/evaluation/EvaluationsManager.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ internal class EvaluationsManager(
5151
* a valid targeting key.
5252
*/
5353
fun updateEvaluationsForContext(context: EvaluationContext) {
54-
// Transition to RECONCILING before starting the fetch operation
5554
flagStateChannel.notifyReconciling()
5655

5756
executorService.executeSafe(
@@ -83,7 +82,6 @@ internal class EvaluationsManager(
8382
{ "Successfully processed context ${context.targetingKey} with ${flagsMap.size} flags" }
8483
)
8584

86-
// Transition to READY after successful storage, or ERROR if fetch failed
8785
if (response != null) {
8886
flagStateChannel.notifyReady()
8987
} else {

0 commit comments

Comments
 (0)