Merge pull request #3030 from DataDog/aleksandr-gringauz/RUM-13071/stop-using-process-importance-app-launch

RUM-13071: Stop using process importance when distinguishing between cold and warm launches

Author: aleksandr-gringauz

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/startup/RumAppStartupDetector.kt

@@ -9,7 +9,6 @@ package com.datadog.android.rum.internal.startup
 import android.app.Application
 import com.datadog.android.core.InternalSdkCore
 import com.datadog.android.core.internal.system.BuildSdkVersionProvider
-import com.datadog.android.rum.DdRumContentProvider
 
 internal interface RumAppStartupDetector {
     interface Listener {
@@ -28,7 +27,6 @@ internal interface RumAppStartupDetector {
                 application = application,
                 buildSdkVersionProvider = BuildSdkVersionProvider.DEFAULT,
                 appStartupTimeProviderNs = { sdkCore.appStartTimeNs },
-                processImportanceProvider = { DdRumContentProvider.processImportance },
                 timeProviderNs = { System.nanoTime() },
                 listener
             )

features/dd-sdk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/startup/RumAppStartupDetectorImpl.kt

@@ -7,7 +7,6 @@
 package com.datadog.android.rum.internal.startup
 
 import android.app.Activity
-import android.app.ActivityManager
 import android.app.Application
 import android.os.Build
 import android.os.Bundle
@@ -19,7 +18,6 @@ internal class RumAppStartupDetectorImpl(
     private val application: Application,
     private val buildSdkVersionProvider: BuildSdkVersionProvider,
     private val appStartupTimeProviderNs: () -> Long,
-    private val processImportanceProvider: () -> Int,
     private val timeProviderNs: () -> Long,
     private val listener: RumAppStartupDetector.Listener
 ) : RumAppStartupDetector, Application.ActivityLifecycleCallbacks {
@@ -73,15 +71,12 @@ internal class RumAppStartupDetectorImpl(
         if (numberOfActivities == 1 && !isChangingConfigurations) {
             val processStartTimeNs = appStartupTimeProviderNs()
 
-            val processStartedInForeground =
-                processImportanceProvider() == ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND
-
             val gapNs = nowNs - processStartTimeNs
             val hasSavedInstanceStateBundle = savedInstanceState != null
             val weakActivity = WeakReference(activity)
 
             val scenario = if (isFirstActivityForProcess) {
-                if (!processStartedInForeground || gapNs > START_GAP_THRESHOLD_NS) {
+                if (gapNs > START_GAP_THRESHOLD_NS) {
                     RumStartupScenario.WarmFirstActivity(
                         initialTimeNs = nowNs,
                         hasSavedInstanceStateBundle = hasSavedInstanceStateBundle,

features/dd-sdk-android-rum/src/test/kotlin/com/datadog/android/rum/internal/startup/RumAppStartupDetectorImplTest.kt

@@ -7,8 +7,6 @@
 package com.datadog.android.rum.internal.startup
 
 import android.app.Activity
-import android.app.ActivityManager.RunningAppProcessInfo.IMPORTANCE_CACHED
-import android.app.ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND
 import android.app.Application
 import android.os.Build
 import android.os.Bundle
@@ -75,22 +73,18 @@ internal class RumAppStartupDetectorImplTest {
 
     @Test
     fun `M registerActivityLifecycleCallbacks W RumAppStartupDetector constructor`() {
-        createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        createDetector()
         verify(application).registerActivityLifecycleCallbacks(any())
         verifyNoMoreInteractions(application)
     }
 
     @Test
-    fun `M detect Cold scenario W RumAppStartupDetector {IMPORTANCE_FOREGROUND and small gap}`(
+    fun `M detect Cold scenario W RumAppStartupDetector {small gap}`(
         forge: Forge,
         @BoolForgery hasSavedInstanceStateBundle: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -115,45 +109,11 @@ internal class RumAppStartupDetectorImplTest {
     }
 
     @Test
-    fun `M detect WarmFirstActivity scenario W RumAppStartupDetector {IMPORTANCE_CACHED and small gap}`(
+    fun `M detect WarmFirstActivity scenario W RumAppStartupDetector {large gap}`(
         forge: Forge,
         @BoolForgery hasSavedInstanceStateBundle: Boolean
     ) {
-        // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_CACHED
-        )
-
-        currentTime += 3.seconds
-
-        // When
-        triggerBeforeCreated(
-            forge = forge,
-            detector = detector,
-            activity = activity,
-            hasSavedInstanceStateBundle = hasSavedInstanceStateBundle
-        )
-
-        // Then
-        listener.verifyScenarioDetected(
-            RumStartupScenario.WarmFirstActivity(
-                initialTimeNs = currentTime.inWholeNanoseconds,
-                hasSavedInstanceStateBundle = hasSavedInstanceStateBundle,
-                activity = activity.wrapWeak(),
-                appStartActivityOnCreateGapNs = 3.seconds.inWholeNanoseconds
-            )
-        )
-        verifyNoMoreInteractions(listener)
-    }
-
-    @Test
-    fun `M detect WarmFirstActivity scenario W RumAppStartupDetector {IMPORTANCE_FOREGROUND and large gap}`(
-        forge: Forge,
-        @BoolForgery hasSavedInstanceStateBundle: Boolean
-    ) {
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 6.seconds
         triggerBeforeCreated(
@@ -181,9 +141,7 @@ internal class RumAppStartupDetectorImplTest {
         @BoolForgery hasSavedInstanceStateBundle2: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -234,9 +192,7 @@ internal class RumAppStartupDetectorImplTest {
         @BoolForgery hasSavedInstanceStateBundle: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -278,9 +234,7 @@ internal class RumAppStartupDetectorImplTest {
         @BoolForgery hasSavedInstanceStateBundle2: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -325,9 +279,7 @@ internal class RumAppStartupDetectorImplTest {
         @BoolForgery hasSavedInstanceStateBundle2: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -386,9 +338,7 @@ internal class RumAppStartupDetectorImplTest {
         @BoolForgery hasSavedInstanceStateBundle3: Boolean
     ) {
         // Given
-        val detector = createDetector(
-            processImportance = IMPORTANCE_FOREGROUND
-        )
+        val detector = createDetector()
 
         currentTime += 3.seconds
 
@@ -458,14 +408,13 @@ internal class RumAppStartupDetectorImplTest {
         verifyNoMoreInteractions(listener)
     }
 
-    private fun createDetector(processImportance: Int): RumAppStartupDetectorImpl {
+    private fun createDetector(): RumAppStartupDetectorImpl {
         whenever(buildSdkVersionProvider.version) doReturn fakeBuildSdkVersion
 
         val detector = RumAppStartupDetectorImpl(
             application = application,
             buildSdkVersionProvider = buildSdkVersionProvider,
             appStartupTimeProviderNs = { 0 },
-            processImportanceProvider = { processImportance },
             timeProviderNs = { currentTime.inWholeNanoseconds },
             listener
         )