Merge pull request #2990 from DataDog/kikoveiga/RUM-10417/fix-potential-exception

RUM-10417: Handle potential StackOverflowError

Author: kikoveiga

integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/trace/TracingInterceptor.kt

@@ -169,7 +169,20 @@ internal constructor(
         throwable: Throwable?
     ) {
         if (span != null) {
-            tracedRequestListener.onRequestIntercepted(request, span, response, throwable)
+            try {
+                tracedRequestListener.onRequestIntercepted(request, span, response, throwable)
+            } catch (e: StackOverflowError) {
+                sdkCore.internalLogger.log(
+                    InternalLogger.Level.ERROR,
+                    InternalLogger.Target.USER,
+                    {
+                        "$ERROR_STACK_OVERFLOW\nRequest: ${request.method}:${request.url}"
+                    },
+                    e
+                )
+                @Suppress("ThrowingInternalException")
+                throw e
+            }
         }
     }
 
@@ -853,6 +866,11 @@ internal constructor(
                 "but you didn't register any AgentTracer.TracerAPI. " +
                 "We automatically created a local tracer for you."
 
+        internal const val ERROR_STACK_OVERFLOW =
+            "StackOverflowError detected in TracedRequestListener. " +
+                "This is likely caused by retrying the same request within the " +
+                "onRequestIntercepted callback, leading to infinite recursion."
+
         internal const val NETWORK_REQUESTS_TRACKING_FEATURE_NAME = "Network Requests"
         internal const val ALL_IN_SAMPLE_RATE: Double = 100.0
         internal const val ZERO_SAMPLE_RATE: Float = 0f

integrations/dd-sdk-android-okhttp/src/test/kotlin/com/datadog/android/okhttp/trace/TracingInterceptorTest.kt

@@ -1659,6 +1659,36 @@ internal open class TracingInterceptorTest {
         verify(mockFuture).get(1, TimeUnit.SECONDS)
     }
 
+    @Test
+    fun `M log error and rethrow W listener causes StackOverflowError`(
+        @IntForgery(min = 200, max = 600) statusCode: Int
+    ) {
+        // Given
+        whenever(mockResolver.isFirstPartyUrl(fakeUrl.toHttpUrl())).thenReturn(true)
+        stubChain(mockChain, statusCode)
+
+        whenever(
+            mockRequestListener.onRequestIntercepted(any(), any(), anyOrNull(), anyOrNull())
+        ).doAnswer { throw StackOverflowError() }
+
+        // When
+        assertThrows<StackOverflowError> {
+            testedInterceptor.intercept(mockChain)
+        }
+
+        // Then
+        val expectedMessage = "${TracingInterceptor.ERROR_STACK_OVERFLOW}\n" +
+            "Request: ${fakeRequest.method}:${fakeRequest.url}"
+
+        mockInternalLogger.verifyLog(
+            InternalLogger.Level.ERROR,
+            InternalLogger.Target.USER,
+            expectedMessage,
+            StackOverflowError::class.java,
+            mode = org.mockito.kotlin.atLeast(1)
+        )
+    }
+
     // region Internal
 
     internal fun stubChain(chain: Interceptor.Chain, statusCode: Int) {