Merge pull request #2707 from DataDog/nogorodnikov/move-top-level-functions-and-properties-060625

Move public top-level extension functions and properties from `core` module to `internal` module

Author: 0xnm

dd-sdk-android-core/api/apiSurface

@@ -192,8 +192,6 @@ interface com.datadog.android.core.InternalSdkCore : com.datadog.android.api.fea
 class com.datadog.android.core.SdkReference
   constructor(String? = null, (com.datadog.android.api.SdkCore) -> Unit = {})
   fun get(): com.datadog.android.api.SdkCore?
-fun <T> allowThreadDiskReads(() -> T): T
-fun <T> allowThreadDiskWrites(() -> T): T
 class com.datadog.android.core.UploadWorker : androidx.work.Worker
   constructor(android.content.Context, androidx.work.WorkerParameters)
   override fun doWork(): Result
@@ -290,15 +288,9 @@ fun Collection<ByteArray>.join(ByteArray, ByteArray = ByteArray(0), ByteArray =
 fun java.util.concurrent.Executor.executeSafe(String, com.datadog.android.api.InternalLogger, Runnable)
 fun java.util.concurrent.ScheduledExecutorService.scheduleSafe(String, Long, java.util.concurrent.TimeUnit, com.datadog.android.api.InternalLogger, Runnable): java.util.concurrent.ScheduledFuture<*>?
 fun java.util.concurrent.ExecutorService.submitSafe(String, com.datadog.android.api.InternalLogger, Runnable): java.util.concurrent.Future<*>?
-val NULL_MAP_VALUE: Object
 object com.datadog.android.core.internal.utils.JsonSerializer
   fun toJsonElement(Any?): com.google.gson.JsonElement
   fun Map<String, Any?>.safeMapValuesToJson(com.datadog.android.api.InternalLogger): Map<String, com.google.gson.JsonElement>
-fun Int.toHexString(): String
-fun Long.toHexString(): String
-fun java.math.BigInteger.toHexString(): String
-fun Thread.State.asString(): String
-fun Array<StackTraceElement>.loggableStackTrace(): String
 enum com.datadog.android.core.metrics.MethodCallSamplingRate
   constructor(Float)
   - ALL

dd-sdk-android-core/api/dd-sdk-android-core.api

@@ -551,11 +551,6 @@ public final class com/datadog/android/core/SdkReference {
 	public final fun get ()Lcom/datadog/android/api/SdkCore;
 }
 
-public final class com/datadog/android/core/StrictModeExtKt {
-	public static final fun allowThreadDiskReads (Lkotlin/jvm/functions/Function0;)Ljava/lang/Object;
-	public static final fun allowThreadDiskWrites (Lkotlin/jvm/functions/Function0;)Ljava/lang/Object;
-}
-
 public final class com/datadog/android/core/UploadWorker : androidx/work/Worker {
 	public static final field Companion Lcom/datadog/android/core/UploadWorker$Companion;
 	public fun <init> (Landroid/content/Context;Landroidx/work/WorkerParameters;)V
@@ -792,21 +787,6 @@ public final class com/datadog/android/core/internal/utils/JsonSerializer {
 	public final fun toJsonElement (Ljava/lang/Object;)Lcom/google/gson/JsonElement;
 }
 
-public final class com/datadog/android/core/internal/utils/MapUtilsKt {
-	public static final fun getNULL_MAP_VALUE ()Ljava/lang/Object;
-}
-
-public final class com/datadog/android/core/internal/utils/NumberExtKt {
-	public static final fun toHexString (I)Ljava/lang/String;
-	public static final fun toHexString (J)Ljava/lang/String;
-	public static final fun toHexString (Ljava/math/BigInteger;)Ljava/lang/String;
-}
-
-public final class com/datadog/android/core/internal/utils/ThreadExtKt {
-	public static final fun asString (Ljava/lang/Thread$State;)Ljava/lang/String;
-	public static final fun loggableStackTrace ([Ljava/lang/StackTraceElement;)Ljava/lang/String;
-}
-
 public final class com/datadog/android/core/metrics/MethodCallSamplingRate : java/lang/Enum {
 	public static final field ALL Lcom/datadog/android/core/metrics/MethodCallSamplingRate;
 	public static final field HIGH Lcom/datadog/android/core/metrics/MethodCallSamplingRate;

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/CoreFeature.kt

@@ -19,7 +19,6 @@ import com.datadog.android.Datadog
 import com.datadog.android.DatadogSite
 import com.datadog.android.api.InternalLogger
 import com.datadog.android.api.storage.RawBatchEvent
-import com.datadog.android.core.allowThreadDiskReads
 import com.datadog.android.core.configuration.BackPressureStrategy
 import com.datadog.android.core.configuration.BatchProcessingLevel
 import com.datadog.android.core.configuration.BatchSize
@@ -75,6 +74,7 @@ import com.datadog.android.core.internal.utils.executeSafe
 import com.datadog.android.core.internal.utils.unboundInternalLogger
 import com.datadog.android.core.persistence.PersistenceStrategy
 import com.datadog.android.core.thread.FlushableExecutorService
+import com.datadog.android.internal.utils.allowThreadDiskReads
 import com.datadog.android.ndk.internal.DatadogNdkCrashHandler
 import com.datadog.android.ndk.internal.NdkCrashHandler
 import com.datadog.android.ndk.internal.NdkCrashLogDeserializer

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/utils/MapUtils.kt

@@ -6,14 +6,6 @@
 
 package com.datadog.android.core.internal.utils
 
-// TODO RUM-373 public as hack, no other solution for now. Any?.toJsonElement relies on this
-//  particular value. Maybe create something like (class NullMap) and check identity instead?
-/**
- * Special value for missing attribute.
- */
-@Suppress("PLATFORM_CLASS_MAPPED_TO_KOTLIN", "PackageNameVisibility")
-val NULL_MAP_VALUE: Object = Object()
-
 /**
  * @return a new mutable map containing all key-value pairs from the given array of pairs.
  *

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/utils/MiscUtils.kt

@@ -7,6 +7,7 @@
 package com.datadog.android.core.internal.utils
 
 import com.datadog.android.api.InternalLogger
+import com.datadog.android.internal.utils.NULL_MAP_VALUE
 import com.datadog.android.lint.InternalApi
 import com.google.gson.JsonArray
 import com.google.gson.JsonElement

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/utils/NumberExt.kt

@@ -6,15 +6,8 @@
 
 package com.datadog.android.core.internal.utils
 
-import com.datadog.android.lint.InternalApi
-import java.math.BigInteger
 import java.nio.ByteBuffer
 
-/**
- * Radix used to convert numbers to hexadecimal strings.
- */
-internal const val HEX_RADIX: Int = 16
-
 /**
  * Converts this [Short] into a [ByteArray] representation.
  */
@@ -25,12 +18,6 @@ internal fun Short.toByteArray(): ByteArray {
     return ByteBuffer.allocate(Short.SIZE_BYTES).putShort(this).array()
 }
 
-/**
- * Converts this [Int] into hexadecimal representation.
- */
-@InternalApi
-fun Int.toHexString(): String = toString(HEX_RADIX)
-
 /**
  * Converts this [Int] into a [ByteArray] representation.
  */
@@ -41,12 +28,6 @@ internal fun Int.toByteArray(): ByteArray {
     return ByteBuffer.allocate(Int.SIZE_BYTES).putInt(this).array()
 }
 
-/**
- * Converts this [Long] into hexadecimal representation.
- */
-@InternalApi
-fun Long.toHexString(): String = toString(HEX_RADIX)
-
 /**
  * Converts this [Long] into a [ByteArray] representation.
  */
@@ -56,11 +37,3 @@ internal fun Long.toByteArray(): ByteArray {
     @Suppress("UnsafeThirdPartyFunctionCall")
     return ByteBuffer.allocate(Long.SIZE_BYTES).putLong(this).array()
 }
-
-/**
- * Converts this [BigInteger] into hexadecimal representation.
- */
-@InternalApi
-fun BigInteger.toHexString(): String {
-    return toLong().toHexString()
-}

dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/utils/ThreadExt.kt

@@ -15,9 +15,8 @@ import com.datadog.android.core.InternalSdkCore
 import com.datadog.android.core.feature.event.JvmCrash
 import com.datadog.android.core.feature.event.ThreadDump
 import com.datadog.android.core.internal.thread.waitToIdle
-import com.datadog.android.core.internal.utils.asString
-import com.datadog.android.core.internal.utils.loggableStackTrace
 import com.datadog.android.core.internal.utils.triggerUploadWorker
+import com.datadog.android.internal.utils.asString
 import com.datadog.android.internal.utils.loggableStackTrace
 import java.lang.ref.WeakReference
 import java.util.concurrent.ThreadPoolExecutor

dd-sdk-android-core/src/main/kotlin/com/datadog/android/error/internal/DatadogExceptionHandler.kt

@@ -18,7 +18,6 @@ import com.datadog.android.core.internal.HashGenerator
 import com.datadog.android.core.internal.NoOpInternalSdkCore
 import com.datadog.android.core.internal.SdkCoreRegistry
 import com.datadog.android.core.internal.Sha256HashGenerator
-import com.datadog.android.core.internal.utils.loggableStackTrace
 import com.datadog.android.internal.utils.loggableStackTrace
 import com.datadog.android.privacy.TrackingConsent
 import com.datadog.android.utils.config.ApplicationContextTestConfiguration

dd-sdk-android-core/src/test/kotlin/com/datadog/android/DatadogTest.kt

@@ -9,6 +9,7 @@ package com.datadog.android.core.internal.utils
 import com.datadog.android.api.InternalLogger
 import com.datadog.android.core.internal.utils.JsonSerializer.ITEM_SERIALIZATION_ERROR
 import com.datadog.android.core.internal.utils.JsonSerializer.safeMapValuesToJson
+import com.datadog.android.internal.utils.NULL_MAP_VALUE
 import com.datadog.android.utils.forge.Configurator
 import com.datadog.android.utils.verifyLog
 import com.datadog.tools.unit.forge.anException