chore: remove unnecessary extension_thread_stats

Author: apiarian-datadog

datadog_lambda/dogstatsd.py

@@ -62,7 +62,11 @@ def distribution(self, metric, value, tags=None, timestamp=None):
 
         >>> statsd.distribution("uploaded.file.size", 1445)
         >>> statsd.distribution("album.photo.count", 26, tags=["gender:female"])
-        >>> statsd.distribution("historic.file.count", 5, timestamp=int(datetime(2020, 2, 14, 12, 0, 0).timestamp()))
+        >>> statsd.distribution(
+        >>>     "historic.file.count",
+        >>>     5,
+        >>>     timestamp=int(datetime(2020, 2, 14, 12, 0, 0).timestamp()),
+        >>> )
         """
         self._report(metric, "d", value, tags, timestamp)
 

datadog_lambda/metric.py

@@ -16,7 +16,6 @@
 logger = logging.getLogger(__name__)
 
 lambda_stats = None
-extension_thread_stats = None
 
 flush_in_thread = os.environ.get("DD_FLUSH_IN_THREAD", "").lower() == "true"
 
@@ -129,18 +128,6 @@ def write_metric_point_to_stdout(metric_name, value, timestamp=None, tags=None):
 def flush_stats(lambda_context=None):
     lambda_stats.flush()
 
-    if extension_thread_stats is not None:
-        tags = None
-        if lambda_context is not None:
-            tags = get_enhanced_metrics_tags(lambda_context)
-            split_arn = lambda_context.invoked_function_arn.split(":")
-            if len(split_arn) > 7:
-                # Get rid of the alias
-                split_arn.pop()
-            arn = ":".join(split_arn)
-            tags.append("function_arn:" + arn)
-        extension_thread_stats.flush(tags)
-
 
 def submit_enhanced_metric(metric_name, lambda_context):
     """Submits the enhanced metric with the given name

tests/test_metric.py

@@ -44,25 +44,16 @@ def test_lambda_metric_flush_to_log_with_extension(self):
 
     @patch("datadog_lambda.metric.should_use_extension", True)
     def test_lambda_metric_timestamp_with_extension(self):
-        patcher = patch("datadog_lambda.metric.extension_thread_stats")
-        self.mock_metric_extension_thread_stats = patcher.start()
-        self.addCleanup(patcher.stop)
-
         delta = timedelta(minutes=1)
         timestamp = int((datetime.now() - delta).timestamp())
 
         lambda_metric("test_timestamp", 1, timestamp)
         self.mock_metric_lambda_stats.distribution.assert_has_calls(
             [call("test_timestamp", 1, timestamp=timestamp, tags=[dd_lambda_layer_tag])]
         )
-        self.mock_metric_extension_thread_stats.distribution.assert_not_called()
 
     @patch("datadog_lambda.metric.should_use_extension", True)
     def test_lambda_metric_datetime_with_extension(self):
-        patcher = patch("datadog_lambda.metric.extension_thread_stats")
-        self.mock_metric_extension_thread_stats = patcher.start()
-        self.addCleanup(patcher.stop)
-
         delta = timedelta(minutes=1)
         timestamp = datetime.now() - delta
 
@@ -77,20 +68,14 @@ def test_lambda_metric_datetime_with_extension(self):
                 )
             ]
         )
-        self.mock_metric_extension_thread_stats.distribution.assert_not_called()
 
     @patch("datadog_lambda.metric.should_use_extension", True)
     def test_lambda_metric_invalid_timestamp_with_extension(self):
-        patcher = patch("datadog_lambda.metric.extension_thread_stats")
-        self.mock_metric_extension_thread_stats = patcher.start()
-        self.addCleanup(patcher.stop)
-
         delta = timedelta(hours=5)
         timestamp = int((datetime.now() - delta).timestamp())
 
         lambda_metric("test_timestamp", 1, timestamp)
         self.mock_metric_lambda_stats.distribution.assert_not_called()
-        self.mock_metric_extension_thread_stats.distribution.assert_not_called()
 
     def test_lambda_metric_flush_to_log(self):
         os.environ["DD_FLUSH_TO_LOG"] = "True"
@@ -135,10 +120,6 @@ def setUp(self):
         self.mock_threadstats_flush_distributions = patcher.start()
         self.addCleanup(patcher.stop)
 
-        patcher = patch("datadog_lambda.metric.extension_thread_stats")
-        self.mock_extension_thread_stats = patcher.start()
-        self.addCleanup(patcher.stop)
-
     def test_retry_on_remote_disconnected(self):
         # Raise the RemoteDisconnected error
         lambda_stats = ThreadStatsWriter(True)
@@ -217,10 +198,6 @@ def test_flush_temp_constant_tags(self):
                 lambda_stats.thread_stats.constant_tags, original_constant_tags
             )
 
-    def test_flush_stats_without_context(self):
-        flush_stats(lambda_context=None)
-        self.mock_extension_thread_stats.flush.assert_called_with(None)
-
 
 MOCK_FUNCTION_NAME = "myFunction"