Skip to content

Commit c44c33a

Browse files
Merge branch 'main' into rithika.narayan/update-node-version
2 parents a0e12d2 + fba070d commit c44c33a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

ci/input_files/build.yaml.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ default:
2727
- apt-get install -y ca-certificates curl gnupg xxd
2828
- mkdir -p /etc/apt/keyrings
2929
- curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
30-
# We are explicitly setting the node_18.x version for the installation
30+
# We are explicitly setting the node_20.x version for the installation
3131
- echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
3232
- apt-get update
3333
- apt-get install nodejs -y

datadog_lambda/asm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ def asm_start_request(
126126

127127
request_ip = _get_request_header_client_ip(request_headers, peer_ip, True)
128128
if request_ip is not None:
129-
span.set_tag_str("http.client_ip", request_ip)
130-
span.set_tag_str("network.client.ip", request_ip)
129+
span.set_tag("http.client_ip", request_ip)
130+
span.set_tag("network.client.ip", request_ip)
131131

132132
# Encode the parsed query and append it to reconstruct the original raw URI expected by AppSec.
133133
if parsed_query:

tests/test_asm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ def test_asm_start_request_parametrized(
331331

332332
# Check IP tags were set if IP is present
333333
if expected_ip:
334-
mock_span.set_tag_str.assert_any_call("http.client_ip", expected_ip)
335-
mock_span.set_tag_str.assert_any_call("network.client.ip", expected_ip)
334+
mock_span.set_tag.assert_any_call("http.client_ip", expected_ip)
335+
mock_span.set_tag.assert_any_call("network.client.ip", expected_ip)
336336

337337

338338
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)