Skip to content

Commit 71d5408

Browse files
committed
Add merge_xray_traces.
1 parent dc320f8 commit 71d5408

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

datadog_lambda/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ class Config:
4242
"DD_INSTRUMENTATION_TELEMETRY_ENABLED", "false", as_bool
4343
)
4444
trace_enabled = _get_env("DD_TRACE_ENABLED", "true", as_bool)
45+
merge_xray_traces = _get_env("DD_MERGE_XRAY_TRACES", "false", as_bool)
4546

4647
@property
4748
def fips_mode_enabled(self):

datadog_lambda/wrapper.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
logger = logging.getLogger(__name__)
6363

6464
DD_LOGS_INJECTION = "DD_LOGS_INJECTION"
65-
DD_MERGE_XRAY_TRACES = "DD_MERGE_XRAY_TRACES"
6665
AWS_LAMBDA_FUNCTION_NAME = "AWS_LAMBDA_FUNCTION_NAME"
6766
DD_LOCAL_TEST = "DD_LOCAL_TEST"
6867
DD_TRACE_EXTRACTOR = "DD_TRACE_EXTRACTOR"
@@ -157,9 +156,6 @@ def __init__(self, func):
157156
"""Executes when the wrapped function gets wrapped"""
158157
try:
159158
self.func = func
160-
self.merge_xray_traces = (
161-
os.environ.get(DD_MERGE_XRAY_TRACES, "false").lower() == "true"
162-
)
163159
self.function_name = os.environ.get(AWS_LAMBDA_FUNCTION_NAME, "function")
164160
self.service = os.environ.get(DD_SERVICE, None)
165161
self.extractor_env = os.environ.get(DD_TRACE_EXTRACTOR, None)
@@ -311,7 +307,7 @@ def _before(self, event, context):
311307
)
312308

313309
if config.trace_enabled:
314-
set_dd_trace_py_root(trace_context_source, self.merge_xray_traces)
310+
set_dd_trace_py_root(trace_context_source, config.merge_xray_traces)
315311
if self.make_inferred_span:
316312
self.inferred_span = create_inferred_span(
317313
event, context, event_source, self.decode_authorizer_context
@@ -322,7 +318,7 @@ def _before(self, event, context):
322318
is_cold_start=is_cold_start(),
323319
is_proactive_init=is_proactive_init(),
324320
trace_context_source=trace_context_source,
325-
merge_xray_traces=self.merge_xray_traces,
321+
merge_xray_traces=config.merge_xray_traces,
326322
trigger_tags=self.trigger_tags,
327323
parent_span=self.inferred_span,
328324
span_pointers=calculate_span_pointers(event_source, event),

tests/test_config.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,15 @@ def set_env(key, value):
115115
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "1", True), # CHANGED
116116
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "0", False),
117117
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "purple", False),
118+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", None, False),
119+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "", False),
120+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "true", True),
121+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "TRUE", True),
122+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "false", False),
123+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "FALSE", False),
124+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "1", True), # CHANGED
125+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "0", False),
126+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "purple", False),
118127
)
119128

120129

0 commit comments

Comments
 (0)