Add min_cold_start_trace_duration.

Author: purple4reina

datadog_lambda/config.py

@@ -42,8 +42,13 @@ class Config:
     service = _get_env("DD_SERVICE")
     env = _get_env("DD_ENV")
 
-    add_span_pointers = _get_env("DD_BOTOCORE_ADD_SPAN_POINTERS", "true", as_bool)
     cold_start_tracing = _get_env("DD_COLD_START_TRACING", "true", as_bool)
+    min_cold_start_trace_duration = _get_env("DD_MIN_COLD_START_DURATION", 3, int)
+
+    capture_payload_max_depth = _get_env("DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH", 10, int)
+    capture_payload_enabled = _get_env("DD_CAPTURE_LAMBDA_PAYLOAD", "false", as_bool)
+
+    add_span_pointers = _get_env("DD_BOTOCORE_ADD_SPAN_POINTERS", "true", as_bool)
     enhanced_metrics_enabled = _get_env("DD_ENHANCED_METRICS", "true", as_bool)
     flush_in_thread = _get_env("DD_FLUSH_IN_THREAD", "false", as_bool)
     flush_to_log = _get_env("DD_FLUSH_TO_LOG", "false", as_bool)
@@ -59,8 +64,6 @@ class Config:
     trace_enabled = _get_env("DD_TRACE_ENABLED", "true", as_bool)
     merge_xray_traces = _get_env("DD_MERGE_XRAY_TRACES", "false", as_bool)
     trace_extractor = _get_env("DD_TRACE_EXTRACTOR")
-    capture_payload_max_depth = _get_env("DD_CAPTURE_LAMBDA_PAYLOAD_MAX_DEPTH", 10, int)
-    capture_payload_enabled = _get_env("DD_CAPTURE_LAMBDA_PAYLOAD", "false", as_bool)
     profiling_enabled = _get_env("DD_PROFILING_ENABLED", "false", as_bool)
     llmobs_enabled = _get_env("DD_LLMOBS_ENABLED", "false", as_bool)
     exception_replay_enabled = _get_env("DD_EXCEPTION_REPLAY_ENABLED", "false", as_bool)

datadog_lambda/wrapper.py

@@ -61,7 +61,6 @@
 DD_ENCODE_AUTHORIZER_CONTEXT = "DD_ENCODE_AUTHORIZER_CONTEXT"
 DD_DECODE_AUTHORIZER_CONTEXT = "DD_DECODE_AUTHORIZER_CONTEXT"
 DD_COLD_START_TRACING = "DD_COLD_START_TRACING"
-DD_MIN_COLD_START_DURATION = "DD_MIN_COLD_START_DURATION"
 DD_COLD_START_TRACE_SKIP_LIB = "DD_COLD_START_TRACE_SKIP_LIB"
 DD_REQUESTS_SERVICE_NAME = "DD_REQUESTS_SERVICE_NAME"
 DD_SERVICE = "DD_SERVICE"
@@ -151,9 +150,6 @@ def __init__(self, func):
             self.cold_start_tracing = depends_on_dd_tracing_enabled(
                 os.environ.get(DD_COLD_START_TRACING, "true").lower() == "true"
             )
-            self.min_cold_start_trace_duration = get_env_as_int(
-                DD_MIN_COLD_START_DURATION, 3
-            )
             self.local_testing_mode = os.environ.get(
                 DD_LOCAL_TEST, "false"
             ).lower() in ("true", "1")
@@ -351,7 +347,7 @@ def _after(self, event, context):
                         config.function_name,
                         following_span.start_ns,
                         trace_ctx,
-                        self.min_cold_start_trace_duration,
+                        config.min_cold_start_trace_duration,
                         self.cold_start_trace_skip_lib,
                     ).trace()
                 except Exception as e:

tests/test_config.py

@@ -176,6 +176,13 @@ def set_env(key, value):
     ("DD_CAPTURE_LAMBDA_PAYLOAD", "capture_payload_enabled", "1", True),  # CHANGED
     ("DD_CAPTURE_LAMBDA_PAYLOAD", "capture_payload_enabled", "0", False),
     ("DD_CAPTURE_LAMBDA_PAYLOAD", "capture_payload_enabled", "purple", False),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", None, 3),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "", 3),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "5", 5),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "0", 0),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "2.5", 3),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "-1", -1),
+    ("DD_MIN_COLD_START_DURATION", "min_cold_start_trace_duration", "purple", 3),
 )