chore: add .use_rustls_tls() for our reqwest client builders for added safety

Author: apiarian-datadog

bottlecap/src/bin/bottlecap/main.rs

@@ -230,12 +230,16 @@ async fn main() -> Result<()> {
     let version_without_next = EXTENSION_VERSION.split('-').next().unwrap_or("NA");
     debug!("Starting Datadog Extension {version_without_next}");
     prepare_client_provider()?;
-    let client = Client::builder().no_proxy().build().map_err(|e| {
-        Error::new(
-            std::io::ErrorKind::InvalidData,
-            format!("Failed to create client: {e:?}"),
-        )
-    })?;
+    let client = Client::builder()
+        .use_rustls_tls()
+        .no_proxy()
+        .build()
+        .map_err(|e| {
+            Error::new(
+                std::io::ErrorKind::InvalidData,
+                format!("Failed to create client: {e:?}"),
+            )
+        })?;
 
     let r = register(&client)
         .await

bottlecap/src/http_client.rs

@@ -17,6 +17,7 @@ pub fn get_client(config: Arc<config::Config>) -> reqwest::Client {
 
 fn build_client(config: Arc<config::Config>) -> Result<reqwest::Client, reqwest::Error> {
     let client = reqwest::Client::builder()
+        .use_rustls_tls()
         .timeout(Duration::from_secs(config.flush_timeout))
         // Temporarily not force http2
         // Enable HTTP/2 for better multiplexing

bottlecap/src/telemetry/client.rs

@@ -20,6 +20,7 @@ impl TelemetryApiClient {
     pub async fn subscribe(&self) -> Result<Response, Box<dyn Error>> {
         let url = base_url(TELEMETRY_SUBSCRIPTION_ROUTE)?;
         let resp = reqwest::Client::builder()
+            .use_rustls_tls()
             .no_proxy()
             .build()
             .map_err(|e| {