fix: unit test destroy script and replace shebang

Author: H0R5E

bin/destroy.ts

@@ -1,20 +1,35 @@
+#!/usr/bin/env node
+
+import * as path from 'path'
+import { fileURLToPath } from 'url'
 import { spawnSync } from 'child_process'
+
 import parseArgs from 'minimist'
 
 import { AWSAdapterProps } from '../adapter'
 
-let artifactPath = 'build'
-const argv = parseArgs(process.argv.slice(2))
-if (argv._.length) {
-  artifactPath = argv._[0]
-}
+export async function main(args: string[]): Promise<void> {
+  let artifactPath = 'build'
+  const argv = parseArgs(args.slice(2))
+  if (argv._.length) {
+    artifactPath = argv._[0]
+  }
+
+  const propsPath = path.resolve(
+    process.cwd(),
+    artifactPath,
+    '.adapterprops.json'
+  )
 
-const adapterProps: AWSAdapterProps = await import(
-  `${artifactPath}/.adapterprops.json`
-)
+  const adapterProps: AWSAdapterProps = await import(propsPath)
 
-spawnSync('pulumi', ['destroy', '-f', '-s', adapterProps.stackName!, '-y'], {
-  cwd: adapterProps.pulumiPath,
-  stdio: [process.stdin, process.stdout, process.stderr],
-  env: process.env,
-})
+  spawnSync('pulumi', ['destroy', '-f', '-s', adapterProps.stackName!, '-y'], {
+    cwd: adapterProps.pulumiPath,
+    stdio: [process.stdin, process.stdout, process.stderr],
+    env: process.env,
+  })
+}
+
+if (process.argv[1] === fileURLToPath(import.meta.url)) {
+  main(process.argv)
+}

tests/bin.destroy.test.ts

@@ -0,0 +1,97 @@
+import * as fs from 'fs'
+import * as path from 'path'
+import { spawnSync } from 'child_process'
+
+import { getTempDir } from './utils'
+
+vi.mock('child_process', async (importOriginal) => {
+  const mod: any = await importOriginal()
+  return {
+    ...mod,
+    spawnSync: vi.fn(),
+  }
+})
+
+describe('bin/destroy.ts', () => {
+  let destroy: typeof import('../bin/destroy')
+
+  beforeEach(async () => {
+    vi.resetModules()
+    destroy = await import('../bin/destroy')
+  })
+
+  afterEach(() => {
+    vi.clearAllMocks()
+    vi.resetAllMocks()
+  })
+
+  it('main (no args)', async () => {
+    const tmpDir = getTempDir()
+    const buildDir = path.join(tmpDir, 'build')
+    fs.mkdirSync(buildDir)
+
+    const propsPath = path.join(buildDir, '.adapterprops.json')
+
+    const expectedStackName = 'mock'
+    const expectedPulumiPath = 'mock/pulumi'
+    const json = JSON.stringify({
+      stackName: expectedStackName,
+      pulumiPath: expectedPulumiPath,
+    })
+    fs.writeFileSync(propsPath, json)
+
+    const spy = vi.spyOn(process, 'cwd')
+    spy.mockReturnValue(tmpDir)
+
+    const argv = ['node', 'destroy']
+    await destroy.main(argv)
+
+    fs.rmSync(tmpDir, { recursive: true })
+
+    let spawnSyncMock = <any>spawnSync
+    const args = spawnSyncMock.mock.calls[0]
+
+    expect(spawnSync).toHaveBeenCalledTimes(1)
+    expect(args).toEqual(
+      expect.arrayContaining([
+        'pulumi',
+        ['destroy', '-f', '-s', expectedStackName, '-y'],
+        expect.objectContaining({
+          cwd: expectedPulumiPath,
+        }),
+      ])
+    )
+  })
+
+  it('main (with build)', async () => {
+    const tmpDir = getTempDir()
+    const propsPath = path.join(tmpDir, '.adapterprops.json')
+
+    const expectedStackName = 'mock'
+    const expectedPulumiPath = 'mock/pulumi'
+    const json = JSON.stringify({
+      stackName: expectedStackName,
+      pulumiPath: expectedPulumiPath,
+    })
+    fs.writeFileSync(propsPath, json)
+
+    const argv = ['node', 'destroy', tmpDir]
+    await destroy.main(argv)
+
+    fs.rmSync(tmpDir, { recursive: true })
+
+    let spawnSyncMock = <any>spawnSync
+    const args = spawnSyncMock.mock.calls[0]
+
+    expect(spawnSync).toHaveBeenCalledTimes(1)
+    expect(args).toEqual(
+      expect.arrayContaining([
+        'pulumi',
+        ['destroy', '-f', '-s', expectedStackName, '-y'],
+        expect.objectContaining({
+          cwd: expectedPulumiPath,
+        }),
+      ])
+    )
+  })
+})

tests/tests.utils.test.ts

@@ -1,21 +1,18 @@
-
-
 describe('tests/utils.ts', () => {
-    let utils: typeof import('./utils')
-  
-    beforeEach(async () => {
-      vi.resetModules()
-      utils = await import('./utils')
-    })
-    
-    it.each([
-        ['dsaGS-', false],
-        ['af2-431--fdwfef', false],
-        ['32546546*-fgdasg', false],
-        ['grae0-5344-gafgar', true]
-      ])('validName(%s)', async (test, expected) => {
-        const result = utils.validName(test)
-        expect(result).toBe(expected)
-    })
+  let utils: typeof import('./utils')
+
+  beforeEach(async () => {
+    vi.resetModules()
+    utils = await import('./utils')
+  })
 
-})
+  it.each([
+    ['dsaGS-', false],
+    ['af2-431--fdwfef', false],
+    ['32546546*-fgdasg', false],
+    ['grae0-5344-gafgar', true],
+  ])('validName(%s)', async (test, expected) => {
+    const result = utils.validName(test)
+    expect(result).toBe(expected)
+  })
+})

tests/utils.ts

@@ -10,14 +10,12 @@ export class MyMocks implements Mocks {
   public resources: { [key: string]: Record<string, any> } = {}
   private noNameTest: string[] = [
     'aws:route53/record:Record',
-    'aws:s3/bucketObject:BucketObject'
+    'aws:s3/bucketObject:BucketObject',
   ]
   newResource(args: pulumi.runtime.MockResourceArgs): {
     id: string | undefined
     state: Record<string, any>
   } {
-    console.log(args.type)
-    
     if (!validName(args.name) && !this.noNameTest.includes(args.type)) {
       throw Error(`'${args.name}' is not a valid value for the name field`)
     }
@@ -61,10 +59,9 @@ export class MyMocks implements Mocks {
 }
 
 export function validName(name: string): boolean {
-  console.log(name)
   const regex_valid = new RegExp('^[A-Za-z0-9-]*(?<!-)$')
   const regex_double = new RegExp('--')
-  return regex_valid.test(name) && !(regex_double.test(name))
+  return regex_valid.test(name) && !regex_double.test(name)
 }
 
 // Convert a pulumi.Output to a promise of the same type.