Skip to content

Commit 0b5f6d7

Browse files
authored
chore: handle warnings in build pipeline (#127)
* handle warnings in build * another warning * and last one from build
1 parent d2bb973 commit 0b5f6d7

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

.github/workflows/dotnet-integration.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,16 @@ jobs:
1313
runs-on: ubuntu-20.04
1414

1515
steps:
16-
- uses: actions/checkout@v2
16+
- uses: actions/checkout@v4
1717
with:
1818
fetch-depth: 0 # depth is needed for nbgv
1919

2020
- name: Setup .NET
21-
uses: actions/setup-dotnet@v1
21+
uses: actions/setup-dotnet@v4
2222
with:
2323
dotnet-version: |
2424
6.0.x
25-
8.0.x
26-
include-prerelease: true
25+
8.0.x
2726
2827
- name: Build
2928
run: dotnet build Dapper.AOT.sln -c Debug

.github/workflows/dotnet.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,16 @@ jobs:
1313
runs-on: windows-latest
1414

1515
steps:
16-
- uses: actions/checkout@v2
16+
- uses: actions/checkout@v4
1717
with:
1818
fetch-depth: 0 # depth is needed for nbgv
1919

2020
- name: Setup .NET
21-
uses: actions/setup-dotnet@v1
21+
uses: actions/setup-dotnet@v4
2222
with:
2323
dotnet-version: |
2424
6.0.x
2525
8.0.x
26-
include-prerelease: true
2726
2827
- uses: dotnet/nbgv@master
2928
with:

test/Dapper.AOT.Test.Integration.Executables/Models/DbStringPoco.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ public class DbStringPoco
55
public const string TableName = "dbStringPoco";
66

77
public int Id { get; set; }
8-
public string Name { get; set; }
8+
public string? Name { get; set; }
99
}

test/Dapper.AOT.Test.Integration/DbStringTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ public void DbString_BasicUsage_InterceptsAndReturnsExpectedData()
3737
{
3838
var result = ExecuteInterceptedUserCode<DbStringUsage, DbStringPoco>(DbConnection);
3939

40+
Assert.NotNull(result);
4041
Assert.True(result.Id.Equals(1));
41-
Assert.True(result.Name.Equals("my-dbString", StringComparison.InvariantCultureIgnoreCase));
42+
Assert.Equal("my-dbString", result.Name);
4243
}
4344
}

0 commit comments

Comments
 (0)