Skip to content

Commit ac15e95

Browse files
authored
Update dependencies (TrySound#78)
* Use LTS Node.js in Travis * Update dependencies * Run Prettier
1 parent 7e7b386 commit ac15e95

File tree

15 files changed

+2126
-2452
lines changed

15 files changed

+2126
-2452
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
language: node_js
22
node_js:
3-
- "node"
3+
- "14"
4+
- "12"
45
- "10"
5-
- "8"

lib/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@ function transform(code) {
3232
module.exports = {
3333
encode,
3434
addXmlns,
35-
transform
35+
transform,
3636
};

lib/index.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ function applyInliner(inliner) {
1616
inliner.valueNode.nodes = [
1717
{
1818
type: "word",
19-
value: inliner.loader.svg
20-
}
19+
value: inliner.loader.svg,
20+
},
2121
];
2222
}
2323
}
@@ -35,7 +35,7 @@ module.exports = postcss.plugin(
3535
const loaders = [];
3636
const inliners = [];
3737

38-
css.walk(node => {
38+
css.walk((node) => {
3939
if (node.type === "atrule") {
4040
if (node.name === "svg-load") {
4141
try {
@@ -48,7 +48,7 @@ module.exports = postcss.plugin(
4848
parent: file,
4949
params,
5050
selectors,
51-
node
51+
node,
5252
};
5353
loaders.push(loader);
5454
loadersMap[name] = loader;
@@ -72,14 +72,14 @@ module.exports = postcss.plugin(
7272
parent: file,
7373
params,
7474
selectors: {},
75-
node
75+
node,
7676
};
7777
loaders.push(loader);
7878
inliners.push({
7979
loader,
8080
node,
8181
valueNode,
82-
parsedValue
82+
parsedValue,
8383
});
8484
}
8585
);
@@ -90,7 +90,7 @@ module.exports = postcss.plugin(
9090
loader,
9191
node,
9292
valueNode,
93-
parsedValue
93+
parsedValue,
9494
});
9595
} else {
9696
node.warn(result, `"${name}" svg is not defined`);
@@ -103,17 +103,17 @@ module.exports = postcss.plugin(
103103
}
104104
});
105105

106-
const promises = loaders.map(loader => {
106+
const promises = loaders.map((loader) => {
107107
return load(loader.id, loader.params, loader.selectors, opts)
108-
.then(code => {
108+
.then((code) => {
109109
loader.svg = code;
110110
result.messages.push({
111111
type: "dependency",
112112
file: loader.id,
113-
parent: loader.parent
113+
parent: loader.parent,
114114
});
115115
})
116-
.catch(err => {
116+
.catch((err) => {
117117
loader.error = true;
118118
loader.node.warn(result, err.message);
119119
});

lib/load.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const {
55
removeFill,
66
removeStroke,
77
applyRootParams,
8-
applySelectedParams
8+
applySelectedParams,
99
} = require("./processors.js");
1010

1111
function read(id) {
@@ -23,11 +23,11 @@ function read(id) {
2323
module.exports = function load(id, params, selectors, opts) {
2424
const processors = [
2525
removeFill(id, opts),
26-
removeStroke(id,opts),
26+
removeStroke(id, opts),
2727
applyRootParams(params),
28-
applySelectedParams(selectors)
28+
applySelectedParams(selectors),
2929
];
30-
return read(id).then(data => {
30+
return read(id).then((data) => {
3131
let code = render(data, ...processors);
3232

3333
if (opts.xmlns !== false) {

lib/parseDeclValue.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function getUrl(nodes) {
2929

3030
return {
3131
url,
32-
urlEnd
32+
urlEnd,
3333
};
3434
}
3535

@@ -101,7 +101,7 @@ function getLoader(parsedValue, valueNode) {
101101
url,
102102
params,
103103
valueNode,
104-
parsedValue
104+
parsedValue,
105105
};
106106
}
107107

@@ -114,7 +114,7 @@ function getInliner(parsedValue, valueNode) {
114114
return {
115115
name,
116116
valueNode,
117-
parsedValue
117+
parsedValue,
118118
};
119119
}
120120

@@ -123,7 +123,7 @@ module.exports = function parseDeclValue(value) {
123123
const inliners = [];
124124
const parsedValue = valueParser(value);
125125

126-
parsedValue.walk(valueNode => {
126+
parsedValue.walk((valueNode) => {
127127
if (valueNode.type === "function") {
128128
if (valueNode.value === "svg-load") {
129129
loaders.push(getLoader(parsedValue, valueNode));
@@ -135,6 +135,6 @@ module.exports = function parseDeclValue(value) {
135135

136136
return {
137137
loaders,
138-
inliners
138+
inliners,
139139
};
140140
};

lib/parseRule.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,20 @@ function parseRuleDefinition(params) {
1414
}
1515
return {
1616
name: nodes[0].value,
17-
url: nodes[2].nodes[0].value
17+
url: nodes[2].nodes[0].value,
1818
};
1919
}
2020

2121
function getRuleParams(rule) {
2222
const params = {};
2323
const selectors = {};
2424

25-
rule.each(node => {
25+
rule.each((node) => {
2626
if (node.type === "decl") {
2727
params[node.prop] = node.value;
2828
} else if (node.type === "rule") {
2929
const selector = selectors[node.selectors] || {};
30-
node.each(child => {
30+
node.each((child) => {
3131
if (child.type === "decl") {
3232
selector[child.prop] = child.value;
3333
}
@@ -38,11 +38,11 @@ function getRuleParams(rule) {
3838

3939
return {
4040
params,
41-
selectors
41+
selectors,
4242
};
4343
}
4444

4545
module.exports = {
4646
parseRuleDefinition,
47-
getRuleParams
47+
getRuleParams,
4848
};

lib/processors.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function removeFillAttrib(element) {
99
}
1010

1111
function removeFill(id, opts) {
12-
return dom => {
12+
return (dom) => {
1313
if (matchId(opts.removeFill, id)) {
1414
selectAll("[fill]", dom).forEach(removeFillAttrib);
1515
}
@@ -21,7 +21,7 @@ function removeStrokeAttrib(element) {
2121
}
2222

2323
function removeStroke(id, opts) {
24-
return dom => {
24+
return (dom) => {
2525
if (matchId(opts.removeStroke, id)) {
2626
selectAll("[stroke]", dom).forEach(removeStrokeAttrib);
2727
}
@@ -30,23 +30,23 @@ function removeStroke(id, opts) {
3030

3131
function applyParams(params) {
3232
return ({ attribs }) => {
33-
Object.keys(params).forEach(name => {
33+
Object.keys(params).forEach((name) => {
3434
attribs[name] = params[name];
3535
});
3636
};
3737
}
3838

3939
function applyRootParams(params) {
40-
return dom => {
40+
return (dom) => {
4141
applyParams(params)(selectOne("svg", dom));
4242
};
4343
}
4444

4545
function applySelectedParams(selectors) {
46-
return dom => {
46+
return (dom) => {
4747
const svg = selectOne("svg", dom);
4848

49-
Object.keys(selectors).forEach(selector => {
49+
Object.keys(selectors).forEach((selector) => {
5050
selectAll(selector, svg).forEach(applyParams(selectors[selector]));
5151
});
5252
};
@@ -56,5 +56,5 @@ module.exports = {
5656
removeFill,
5757
removeStroke,
5858
applyRootParams,
59-
applySelectedParams
59+
applySelectedParams,
6060
};

lib/render.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
const { parseDOM } = require("htmlparser2");
2-
const serialize = require("dom-serializer");
2+
const serialize = require("dom-serializer").default;
33

44
module.exports = function render(code, ...processors) {
55
const dom = parseDOM(code, { xmlMode: true });
66

7-
processors.forEach(processor => processor(dom));
7+
processors.forEach((processor) => processor(dom));
88

99
return serialize(dom);
1010
};

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,16 @@
3535
},
3636
"homepage": "https://github.com/TrySound/postcss-inline-svg",
3737
"dependencies": {
38-
"css-select": "^2.0.2",
39-
"dom-serializer": "^0.1.1",
40-
"htmlparser2": "^3.10.1",
38+
"css-select": "^3.1.0",
39+
"dom-serializer": "^1.1.0",
40+
"htmlparser2": "^5.0.1",
4141
"postcss": "^7.0.17",
4242
"postcss-value-parser": "^4.0.0"
4343
},
4444
"devDependencies": {
45-
"husky": "^2.4.1",
46-
"jest": "^24.8.0",
47-
"lint-staged": "^8.2.1",
48-
"prettier": "^1.18.2"
45+
"husky": "^4.3.0",
46+
"jest": "^26.6.1",
47+
"lint-staged": "^10.5.0",
48+
"prettier": "^2.1.2"
4949
}
5050
}

test/cases.test.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ test("should stringify all values after ast transformation", () => {
2424
background: url("data:image/svg+xml;charset=utf-8,<svg xmlns=\'http://www.w3.org/2000/svg\' id='basic'/>");
2525
`,
2626
{ from: "input.css", encode: false }
27-
).then(result => {
28-
result.root.walkDecls(decl => {
27+
).then((result) => {
28+
result.root.walkDecls((decl) => {
2929
expect(typeof decl.value).toEqual("string");
3030
});
3131
});
@@ -50,14 +50,14 @@ test("should add message about dependency", () => {
5050
background: url("data:image/svg+xml;charset=utf-8,<svg xmlns=\'http://www.w3.org/2000/svg\' id='basic'/>")
5151
`,
5252
{ from: "input.css", encode: false }
53-
).then(result => {
53+
).then((result) => {
5454
const messages = result.messages
55-
.filter(message => message.type === "dependency")
56-
.map(message => [message.file, message.parent])
55+
.filter((message) => message.type === "dependency")
56+
.map((message) => [message.file, message.parent])
5757
.sort();
5858
expect(messages).toEqual([
5959
[path.resolve("fixtures/basic-black.svg"), path.resolve("input.css")],
60-
[path.resolve("fixtures/basic.svg"), path.resolve("input.css")]
60+
[path.resolve("fixtures/basic.svg"), path.resolve("input.css")],
6161
]);
6262
});
6363
});
@@ -75,12 +75,12 @@ test("should not add message about not found dependency", () => {
7575
{ from: "input.css", encode: false },
7676
[
7777
`Can't load '${path.resolve("fixtures/not-found.svg")}'`,
78-
`Can't load '${path.resolve("fixtures/not-found.svg")}'`
78+
`Can't load '${path.resolve("fixtures/not-found.svg")}'`,
7979
]
80-
).then(result => {
80+
).then((result) => {
8181
const messages = result.messages
82-
.filter(message => message.type === "dependency")
83-
.map(message => message.file)
82+
.filter((message) => message.type === "dependency")
83+
.map((message) => message.file)
8484
.sort();
8585
expect(messages).toEqual([]);
8686
});
@@ -96,14 +96,14 @@ test("should add parent in dependency message if specified", () => {
9696
background: url("data:image/svg+xml;charset=utf-8,<svg xmlns=\'http://www.w3.org/2000/svg\' id='basic'/>")
9797
`,
9898
{ from: "fixtures/file.css", encode: false }
99-
).then(result => {
99+
).then((result) => {
100100
const messages = result.messages
101-
.filter(message => message.type === "dependency")
102-
.map(message => message.parent)
101+
.filter((message) => message.type === "dependency")
102+
.map((message) => message.parent)
103103
.sort();
104104
expect(messages).toEqual([
105105
path.resolve("fixtures/file.css"),
106-
path.resolve("fixtures/file.css")
106+
path.resolve("fixtures/file.css"),
107107
]);
108108
});
109109
});

0 commit comments

Comments
 (0)