Skip to content

Commit f7c8da4

Browse files
committed
fixup
1 parent 62b17ca commit f7c8da4

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

src/trusted/platform_qualify/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ if (ARCH STREQUAL "i686" OR ARCH STREQUAL "amd64")
2525
endif()
2626

2727
add_library(vcpuid OBJECT "arch/x86/vcpuid.c")
28+
list(APPEND VCPUID_LIBS vcpuid)
2829

2930
if (ARCH STREQUAL "i686")
3031
list(APPEND PQL_INPUTS "arch/x86_32/nacl_dep_qualify_arch.c")
@@ -47,4 +48,4 @@ elseif (ARCH STREQUAL "mips32")
4748
endif()
4849

4950
add_library(platform_qual_lib STATIC ${PQL_INPUTS})
50-
target_link_libraries(platform_qual_lib vcpuid)
51+
target_link_libraries(platform_qual_lib ${VCPUID_LIBS})

src/trusted/service_runtime/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,9 @@ elseif (ARCH STREQUAL "armhf")
317317
list(APPEND LDR_LIBS arm_validator_reporters)
318318
endif()
319319

320-
list(APPEND LDR_LIBS nccopy) # not listed in src/trusted/service_runtime/build.scons
320+
if (ARCH STREQUAL "i686" OR ARCH STREQUAL "amd64")
321+
list(APPEND LDR_LIBS nccopy) # not listed in src/trusted/service_runtime/build.scons
322+
endif()
321323

322324
if (WIN32)
323325
set(MMAP_TEST_CHECK_CC "win/mmap_test_check.cc")

src/trusted/validator_arm/CMakeLists.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,13 @@ list(APPEND GEN_TEST_LIST
4848
"gen/arm32_decode_unconditional_instructions_tests.cc"
4949
)
5050

51+
list(APPEND GEN_ACTUAL_LIST
52+
"gen/arm32_decode_actuals_1.cc"
53+
"gen/arm32_decode_actuals_1.h"
54+
"gen/arm32_decode_actuals_2.cc"
55+
"gen/arm32_decode_actuals_2.h"
56+
)
57+
5158
list(APPEND GEN_OTHER_LIST
5259
"gen/arm32_decode.cc"
5360
"gen/arm32_decode.h"
@@ -58,10 +65,7 @@ list(APPEND GEN_OTHER_LIST
5865
"gen/arm32_decode_named_bases.h"
5966
"gen/arm32_decode_named_decoder.h"
6067
# Generated ACTUAL file names.
61-
"gen/arm32_decode_actuals_1.cc"
62-
"gen/arm32_decode_actuals_1.h"
63-
"gen/arm32_decode_actuals_2.cc"
64-
"gen/arm32_decode_actuals_2.h"
68+
${GEN_ACTUAL_LIST}
6569
# Generated BASELINES file names.
6670
"gen/arm32_decode_baselines_1.cc"
6771
"gen/arm32_decode_baselines_1.h"
@@ -79,7 +83,7 @@ list(APPEND VALIDATOR_INPUTS
7983
"validator.cc"
8084
)
8185

82-
add_library(arm_validatore_core OBJECT ${VALIDATOR_INPUTS} ${GEN_TEST_LIST} ${GEN_OTHER_LIST})
86+
add_library(arm_validatore_core OBJECT ${VALIDATOR_INPUTS} ${GEN_ACTUAL_LIST})
8387

8488
add_library(ncvalidate_arm_v2 STATIC "ncvalidate.cc")
8589
target_link_libraries(ncvalidate_arm_v2 ${arm_validatore_core}) # We don't support OPTIONAL_COVERAGE_LIBS.

0 commit comments

Comments
 (0)