Migrate ROM cvar in_gameControllerAvailable

Also make sure it always really matches the state of whether gamepad
mode is being used.

Author: slipher

src/engine/client/cl_input.cpp

@@ -40,6 +40,10 @@ Maryland 20850 USA.
 #include "engine/qcommon/sys.h"
 #include "framework/CommandSystem.h"
 
+static Cvar::Cvar<bool> in_gameControllerAvailable(
+	"in_gameControllerAvailable", "whether controller is a gamepad (as opposed to joystick)",
+	Cvar::ROM, false);
+
 unsigned frame_msec;
 int      old_com_frameTime;
 
@@ -716,7 +720,7 @@ usercmd_t CL_CreateCmd()
 	CL_MouseMove( &cmd );
 
 	// get basic movement from joystick or controller
-	if ( cl_gameControllerAvailable->integer )
+	if ( in_gameControllerAvailable.Get() )
 	{
 		CL_GameControllerMove( &cmd );
 	}

src/engine/client/cl_main.cpp

@@ -95,7 +95,6 @@ cvar_t *cl_aviFrameRate;
 
 cvar_t *cl_freelook;
 cvar_t *cl_sensitivity;
-cvar_t *cl_gameControllerAvailable;
 
 cvar_t *cl_mouseAccelOffset;
 cvar_t *cl_mouseAccel;
@@ -2334,8 +2333,6 @@ void CL_Init()
 	cl_mouseAccel = Cvar_Get( "cl_mouseAccel", "0", 0 );
 	cl_freelook = Cvar_Get( "cl_freelook", "1", CVAR_ARCHIVE );
 
-	cl_gameControllerAvailable = Cvar_Get( "in_gameControllerAvailable", "0", CVAR_ROM );
-
 	// 0: legacy mouse acceleration
 	// 1: new implementation
 

src/engine/client/client.h

@@ -399,8 +399,6 @@ extern cvar_t *cl_doubletapdelay;
 extern cvar_t *cl_sensitivity;
 extern cvar_t *cl_freelook;
 
-extern cvar_t *cl_gameControllerAvailable;
-
 extern cvar_t *cl_mouseAccel;
 extern cvar_t *cl_mouseAccelOffset;
 extern cvar_t *cl_mouseAccelStyle;

src/engine/sys/sdl_input.cpp

@@ -631,11 +631,12 @@ static void IN_InitJoystick()
 		gamepad = SDL_OpenGamepad( id );
 		if ( gamepad )
 		{
-			Cvar_Set( "in_gameControllerAvailable", "1" );
 			SDL_GamepadEventsEnabled();
 		}
 	}
 
+	Cvar::SetValueForce( "in_gameControllerAvailable", gamepad ? "1" : "0" );
+
 	controllerLog.Notice( "Joystick %d opened", stickIndex );
 	controllerLog.Verbose( "Name:    %s", JoystickNameForID( id ) );
 	controllerLog.Verbose( "Axes:    %d", SDL_GetNumJoystickAxes( stick ) );