Skip to content

Commit c319055

Browse files
committed
NUKE unused GLIndirectBuffer
1 parent 2a2eac6 commit c319055

File tree

3 files changed

+13
-44
lines changed

3 files changed

+13
-44
lines changed

src/engine/renderer/Material.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -636,8 +636,8 @@ void MaterialSystem::GenerateWorldCommandBuffer() {
636636

637637
culledCommandsBuffer.BufferStorage( surfaceCommandsCount * INDIRECT_COMMAND_SIZE * MAX_VIEWFRAMES, 1, nullptr );
638638
culledCommandsBuffer.MapAll();
639-
GLIndirectBuffer::GLIndirectCommand* culledCommands = ( GLIndirectBuffer::GLIndirectCommand* ) culledCommandsBuffer.GetData();
640-
memset( culledCommands, 0, surfaceCommandsCount * sizeof( GLIndirectBuffer::GLIndirectCommand ) * MAX_VIEWFRAMES );
639+
GLIndirectCommand* culledCommands = ( GLIndirectCommand* ) culledCommandsBuffer.GetData();
640+
memset( culledCommands, 0, surfaceCommandsCount * sizeof( GLIndirectCommand ) * MAX_VIEWFRAMES );
641641
culledCommandsBuffer.FlushAll();
642642

643643
surfaceBatchesUBO.BufferData( MAX_SURFACE_COMMAND_BATCHES * SURFACE_COMMAND_BATCH_SIZE, nullptr, GL_STATIC_DRAW );
@@ -2100,9 +2100,9 @@ void MaterialSystem::RenderMaterials( const shaderSort_t fromSort, const shaderS
21002100

21012101
void MaterialSystem::RenderIndirect( const Material& material, const uint32_t viewID, const GLenum mode = GL_TRIANGLES ) {
21022102
glMultiDrawElementsIndirectCountARB( mode, GL_UNSIGNED_INT,
2103-
BUFFER_OFFSET( material.surfaceCommandBatchOffset * SURFACE_COMMANDS_PER_BATCH * sizeof( GLIndirectBuffer::GLIndirectCommand )
2103+
BUFFER_OFFSET( material.surfaceCommandBatchOffset * SURFACE_COMMANDS_PER_BATCH * sizeof( GLIndirectCommand )
21042104
+ ( surfaceCommandsCount * ( MAX_VIEWS * currentFrame + viewID )
2105-
* sizeof( GLIndirectBuffer::GLIndirectCommand ) ) ),
2105+
* sizeof( GLIndirectCommand ) ) ),
21062106
material.globalID * sizeof( uint32_t )
21072107
+ ( MAX_COMMAND_COUNTERS * ( MAX_VIEWS * currentFrame + viewID ) ) * sizeof( uint32_t ),
21082108
material.drawCommands.size(), 0 );

src/engine/renderer/Material.h

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,15 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
4343

4444
static constexpr uint32_t MAX_DRAWCOMMAND_TEXTURES = 64;
4545

46-
/* Similar to GLIndirectBuffer::GLIndirectCommand, but we always set instanceCount to 1 and baseVertex to 0,
46+
struct GLIndirectCommand {
47+
GLuint count;
48+
GLuint instanceCount;
49+
GLuint firstIndex;
50+
GLint baseVertex;
51+
GLuint baseInstance;
52+
};
53+
54+
/* Similar to GLIndirectCommand, but we always set instanceCount to 1 and baseVertex to 0,
4755
so no need to waste memory on those */
4856
struct IndirectCompactCommand {
4957
GLuint count;

src/engine/renderer/gl_shader.h

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1530,45 +1530,6 @@ class GLAtomicCounterBuffer : public GLBuffer {
15301530
}
15311531
};
15321532

1533-
class GLIndirectBuffer {
1534-
public:
1535-
struct GLIndirectCommand {
1536-
GLuint count;
1537-
GLuint instanceCount;
1538-
GLuint firstIndex;
1539-
GLint baseVertex;
1540-
GLuint baseInstance;
1541-
};
1542-
1543-
GLIndirectBuffer( const char* name ) {
1544-
}
1545-
1546-
void BindBuffer() {
1547-
glBindBuffer( GL_DRAW_INDIRECT_BUFFER, handle );
1548-
}
1549-
1550-
GLIndirectCommand* MapBufferRange( const GLsizeiptr count ) {
1551-
return (GLIndirectCommand*) glMapBufferRange( GL_DRAW_INDIRECT_BUFFER,
1552-
0, count * sizeof( GLIndirectCommand ),
1553-
GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT );
1554-
}
1555-
1556-
void UnmapBuffer() const {
1557-
glUnmapBuffer( GL_DRAW_INDIRECT_BUFFER );
1558-
}
1559-
1560-
void GenBuffer() {
1561-
glGenBuffers( 1, &handle );
1562-
}
1563-
1564-
void DelBuffer() {
1565-
glDeleteBuffers( 1, &handle );
1566-
}
1567-
1568-
private:
1569-
GLuint handle;
1570-
};
1571-
15721533
class GLCompileMacro
15731534
{
15741535
private:

0 commit comments

Comments
 (0)