Skip to content

Commit 9220f6f

Browse files
committed
NUKE unused GLUniform.GetSize()
1 parent fdb7f2a commit 9220f6f

File tree

1 file changed

+1
-53
lines changed

1 file changed

+1
-53
lines changed

src/engine/renderer/gl_shader.h

Lines changed: 1 addition & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,6 @@ class GLUniform {
343343
// In multiples of 4 bytes
344344
// FIXME: the uniform structs are actually std140 so it would be more relevant to provide std140 info
345345
const GLuint _std430BaseSize;
346-
GLuint _std430Size; // includes padding that depends on the other uniforms in the struct
347346
const GLuint _std430Alignment;
348347
GLuint _nextUniformOffset;
349348

@@ -374,7 +373,7 @@ class GLUniform {
374373
_shader->RegisterUniform( this );
375374
}
376375

377-
bool CacheValue( void* value ) {
376+
bool CacheValue( const void* value ) {
378377
uint32_t* currentValue;
379378

380379
const bool bufferUniform = ( _shader->UseMaterialSystem() && _updateType == MATERIAL_OR_PUSH )
@@ -433,10 +432,6 @@ class GLUniform {
433432
void UpdateShaderProgramUniformLocation( ShaderProgramDescriptor* shaderProgram ) {
434433
shaderProgram->uniformLocations[_locationIndex] = glGetUniformLocation( shaderProgram->id, _name.c_str() );
435434
}
436-
437-
virtual size_t GetSize() {
438-
return 0;
439-
}
440435
};
441436

442437
class GLShaderManager {
@@ -582,10 +577,6 @@ class GLUniformSampler : protected GLUniform {
582577
}
583578

584579
public:
585-
size_t GetSize() override {
586-
return sizeof( GLuint64 );
587-
}
588-
589580
void SetValue( GLuint value ) {
590581
if ( !CacheValue( &value ) ) {
591582
return;
@@ -649,11 +640,6 @@ class GLUniform1i : protected GLUniform
649640
ShaderProgramDescriptor* p = _shader->GetProgram();
650641
glUniform1i( p->uniformLocations[ _locationIndex ], value );
651642
}
652-
public:
653-
size_t GetSize() override
654-
{
655-
return sizeof( int );
656-
}
657643
};
658644

659645
class GLUniform1ui : protected GLUniform {
@@ -670,10 +656,6 @@ class GLUniform1ui : protected GLUniform {
670656
ShaderProgramDescriptor* p = _shader->GetProgram();
671657
glUniform1ui( p->uniformLocations[_locationIndex], value );
672658
}
673-
public:
674-
size_t GetSize() override {
675-
return sizeof( uint );
676-
}
677659
};
678660

679661
class GLUniform1Bool : protected GLUniform {
@@ -691,11 +673,6 @@ class GLUniform1Bool : protected GLUniform {
691673
ShaderProgramDescriptor* p = _shader->GetProgram();
692674
glUniform1i( p->uniformLocations[_locationIndex], value );
693675
}
694-
695-
public:
696-
size_t GetSize() override {
697-
return sizeof( int );
698-
}
699676
};
700677

701678
class GLUniform1f : protected GLUniform
@@ -714,11 +691,6 @@ class GLUniform1f : protected GLUniform
714691
ShaderProgramDescriptor* p = _shader->GetProgram();
715692
glUniform1f( p->uniformLocations[ _locationIndex ], value );
716693
}
717-
public:
718-
size_t GetSize() override
719-
{
720-
return sizeof( float );
721-
}
722694
};
723695

724696
class GLUniform1fv : protected GLUniform
@@ -755,11 +727,6 @@ class GLUniform2f : protected GLUniform
755727
ShaderProgramDescriptor* p = _shader->GetProgram();
756728
glUniform2f( p->uniformLocations[ _locationIndex ], v[ 0 ], v[ 1 ] );
757729
}
758-
759-
size_t GetSize() override
760-
{
761-
return sizeof( vec2_t );
762-
}
763730
};
764731

765732
class GLUniform3f : protected GLUniform
@@ -778,11 +745,6 @@ class GLUniform3f : protected GLUniform
778745
ShaderProgramDescriptor* p = _shader->GetProgram();
779746
glUniform3f( p->uniformLocations[ _locationIndex ], v[ 0 ], v[ 1 ], v[ 2 ] );
780747
}
781-
public:
782-
size_t GetSize() override
783-
{
784-
return sizeof( vec3_t );
785-
}
786748
};
787749

788750
class GLUniform4f : protected GLUniform
@@ -801,11 +763,6 @@ class GLUniform4f : protected GLUniform
801763
ShaderProgramDescriptor* p = _shader->GetProgram();
802764
glUniform4f( p->uniformLocations[ _locationIndex ], v[ 0 ], v[ 1 ], v[ 2 ], v[ 3 ] );
803765
}
804-
public:
805-
size_t GetSize() override
806-
{
807-
return sizeof( vec4_t );
808-
}
809766
};
810767

811768
class GLUniform4fv : protected GLUniform
@@ -842,11 +799,6 @@ class GLUniformMatrix4f : protected GLUniform
842799
ShaderProgramDescriptor* p = _shader->GetProgram();
843800
glUniformMatrix4fv( p->uniformLocations[ _locationIndex ], 1, transpose, m );
844801
}
845-
public:
846-
size_t GetSize() override
847-
{
848-
return sizeof( matrix_t );
849-
}
850802
};
851803

852804
class GLUniformMatrix32f : protected GLUniform {
@@ -866,10 +818,6 @@ class GLUniformMatrix32f : protected GLUniform {
866818
ShaderProgramDescriptor* p = _shader->GetProgram();
867819
glUniformMatrix3x2fv( p->uniformLocations[_locationIndex], 1, transpose, m );
868820
}
869-
public:
870-
size_t GetSize() override {
871-
return 6 * sizeof( float );
872-
}
873821
};
874822

875823
class GLUniformMatrix4fv : protected GLUniform

0 commit comments

Comments
 (0)