Skip to content

Commit 1d9b397

Browse files
committed
NUKE sseLoadVec3Unsafe()
1 parent 8b6a594 commit 1d9b397

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/engine/qcommon/q_math.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -744,9 +744,9 @@ void SetPlaneSignbits( cplane_t *out )
744744
int BoxOnPlaneSide( const vec3_t emins, const vec3_t emaxs, const cplane_t *p )
745745
{
746746
#if defined(DAEMON_USE_ARCH_INTRINSICS_i686_sse)
747-
auto mins = sseLoadVec3Unsafe( emins );
748-
auto maxs = sseLoadVec3Unsafe( emaxs );
749-
auto normal = sseLoadVec3Unsafe( p->normal );
747+
auto mins = sseLoadVec3( emins );
748+
auto maxs = sseLoadVec3( emaxs );
749+
auto normal = sseLoadVec3( p->normal );
750750

751751
auto prod0 = _mm_mul_ps( maxs, normal );
752752
auto prod1 = _mm_mul_ps( mins, normal );

src/engine/qcommon/q_shared.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1351,10 +1351,6 @@ inline vec_t VectorNormalize2( const vec3_t v, vec3_t out )
13511351
v = _mm_loadl_pi( v, (__m64 *)vec );
13521352
return v;
13531353
}
1354-
ATTRIBUTE_NO_SANITIZE_ADDRESS inline __m128 sseLoadVec3Unsafe( const vec3_t vec ) {
1355-
// Returns garbage in 4th element
1356-
return _mm_loadu_ps( vec );
1357-
}
13581354
inline void sseStoreVec3( __m128 in, vec3_t out ) {
13591355
_mm_storel_pi( (__m64 *)out, in );
13601356
__m128 v = sseSwizzle( in, ZZZZ );
@@ -1368,14 +1364,14 @@ inline vec_t VectorNormalize2( const vec3_t v, vec3_t out )
13681364
inline void TransformPoint(
13691365
const transform_t *t, const vec3_t in, vec3_t out ) {
13701366
__m128 ts = t->sseTransScale;
1371-
__m128 tmp = sseQuatTransform( t->sseRot, sseLoadVec3Unsafe( in ) );
1367+
__m128 tmp = sseQuatTransform( t->sseRot, sseLoadVec3( in ) );
13721368
tmp = _mm_mul_ps( tmp, sseSwizzle( ts, WWWW ) );
13731369
tmp = _mm_add_ps( tmp, ts );
13741370
sseStoreVec3( tmp, out );
13751371
}
13761372
inline void TransformNormalVector(
13771373
const transform_t *t, const vec3_t in, vec3_t out ) {
1378-
__m128 v = sseLoadVec3Unsafe( in );
1374+
__m128 v = sseLoadVec3( in );
13791375
v = sseQuatTransform( t->sseRot, v );
13801376
sseStoreVec3( v, out );
13811377
}

0 commit comments

Comments
 (0)