prevents removing submissions on user delete

The old foreign key was set to cascade, deleting the entire submission
when a user got deleted. This feels conceptually wrong since a
submission is connected to a team and not to a user. The user of the
team of the submission is more 'metadata' than anything else.

Author: tuupke

webapp/migrations/Version20240825115643.php

@@ -28,8 +28,6 @@ public function up(Schema $schema): void
     public function down(Schema $schema): void
     {
         $this->dropKeys();
-
-        // Reinstate the 'restrict' keys.
         $this->addKeys(false);
     }
 
@@ -41,20 +39,24 @@ public function dropKeys(): void
         $this->addSql('ALTER TABLE judging_run DROP CONSTRAINT FK_29A6E6E13CBA64F2');
         $this->addSql('ALTER TABLE judging_run DROP CONSTRAINT judging_run_ibfk_1');
         $this->addSql('ALTER TABLE judgetask DROP CONSTRAINT judgetask_ibfk_1');
+        $this->addSql('ALTER TABLE submission DROP FOREIGN KEY FK_DB055AF3F132696E');
     }
 
-    public function addKeys(bool $suffix): void
+    public function addKeys(bool $isUp): void
     {
         // foreign-keys that are related to judgehosts are set to null so that no data is lost.
-        $cascadeClause = $suffix ? 'ON DELETE CASCADE' : '';
-        $nullClause = $suffix ? 'ON DELETE SET NULL' : '';
+        $cascadeClause = $isUp ? 'ON DELETE CASCADE' : '';
+        $nullClause = $isUp ? 'ON DELETE SET NULL' : '';
 
         $this->addSql('ALTER TABLE version ADD CONSTRAINT `FK_BF1CD3C32271845` FOREIGN KEY (`langid`) REFERENCES `language` (`langid`) ' . $cascadeClause);
         $this->addSql('ALTER TABLE version ADD CONSTRAINT `FK_BF1CD3C3E0E4FC3E` FOREIGN KEY (`judgehostid`) REFERENCES `judgehost` (`judgehostid`) ' . $nullClause);
         $this->addSql('ALTER TABLE judging_run ADD CONSTRAINT `FK_29A6E6E13CBA64F2` FOREIGN KEY (`judgetaskid`) REFERENCES `judgetask` (`judgetaskid`) ' . $cascadeClause);
         $this->addSql('ALTER TABLE judging_run ADD CONSTRAINT `judging_run_ibfk_1` FOREIGN KEY (`testcaseid`) REFERENCES `testcase` (`testcaseid`) ' . $cascadeClause);
         $this->addSql('ALTER TABLE judgetask ADD CONSTRAINT `judgetask_ibfk_1` FOREIGN KEY (`judgehostid`) REFERENCES `judgehost` (`judgehostid`) ' . $nullClause);
         $this->addSql('ALTER TABLE debug_package ADD CONSTRAINT `FK_9E17399BE0E4FC3E` FOREIGN KEY (`judgehostid`) REFERENCES `judgehost` (`judgehostid`) ' . $nullClause);
+
+        $clause = $isUp ? 'ON DELETE SET NULL' : 'ON DELETE CASCADE';
+        $this->addSql('ALTER TABLE submission ADD CONSTRAINT FK_DB055AF3F132696E FOREIGN KEY (userid) REFERENCES user (userid) ' . $clause);
     }
 
     public function isTransactional(): bool

webapp/src/Entity/Submission.php

@@ -118,7 +118,7 @@ class Submission extends BaseApiEntity implements
     private Team $team;
 
     #[ORM\ManyToOne(inversedBy: 'submissions')]
-    #[ORM\JoinColumn(name: 'userid', referencedColumnName: 'userid', onDelete: 'CASCADE')]
+    #[ORM\JoinColumn(name: 'userid', referencedColumnName: 'userid', onDelete: 'SET NULL')]
     #[Serializer\Exclude]
     private ?User $user = null;