Fix all reported PHPStan errors

Author: nickygerritsen

webapp/src/Controller/API/JudgehostController.php

@@ -1656,9 +1656,7 @@ public function getJudgeTasksAction(Request $request): array
                     $judgetasks = [['type' => 'try_again']];
                 }
             }
-            if (!empty($judgetasks)) {
-                return $judgetasks;
-            }
+            return $judgetasks;
         }
 
         if ($this->config->get('enable_parallel_judging')) {

webapp/src/Controller/API/PrintController.php

@@ -15,6 +15,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Attribute\MapRequestPayload;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException;
 use Symfony\Component\Routing\Attribute\Route;
 use Symfony\Component\Security\Http\Attribute\IsGranted;

webapp/src/Controller/Jury/ProblemController.php

@@ -593,8 +593,10 @@ public function testcasesAction(Request $request, int $probId): Response
                         $content = file_get_contents($file->getRealPath());
                         if ($type === 'image') {
                             if (mime_content_type($file->getRealPath()) === 'image/svg+xml') {
+                                $originalContent = $content;
                                 $content = Utils::sanitizeSvg($content);
                                 if ($content === false) {
+                                    $imageType = Utils::getImageType($originalContent, $error);
                                     $this->addFlash('danger', sprintf('image: %s', $error));
                                     return $this->redirectToRoute('jury_problem_testcases', ['probId' => $probId]);
                                 }

webapp/src/Entity/Contest.php

@@ -936,6 +936,9 @@ public function removeLanguage(Language $language): void
         $this->languages->removeElement($language);
     }
 
+    /**
+     * @return Collection<int, Language>
+     */
     public function getLanguages(): Collection
     {
         return $this->languages;

webapp/src/Entity/Language.php

@@ -447,6 +447,9 @@ public function removeContest(Contest $contest): Language
         return $this;
     }
 
+    /**
+     * @return Collection<int, Contest>
+     */
     public function getContests(): Collection
     {
         return $this->contests;
@@ -466,6 +469,9 @@ public function removeProblem(Problem $problem): Language
         return $this;
     }
 
+    /**
+     * @return Collection<int, Problem>
+     */
     public function getProblems(): Collection
     {
         return $this->problems;

webapp/src/Entity/Problem.php

@@ -108,6 +108,9 @@ class Problem extends BaseApiEntity implements
     public const TYPE_INTERACTIVE = 8;
     public const TYPE_SUBMIT_ANSWER = 16;
 
+    /**
+     * @var array<int, string>
+     */
     private array $typesToString = [
         self::TYPE_PASS_FAIL => 'pass-fail',
         self::TYPE_SCORING => 'scoring',
@@ -292,8 +295,12 @@ public function getSpecialCompareArgs(): ?string
         return $this->special_compare_args;
     }
 
+    /**
+     * @param list<string> $types
+     */
     public function setTypesAsString(array $types): Problem
     {
+        /** @var array<string, int> $stringToTypes */
         $stringToTypes = array_flip($this->typesToString);
         $typeConstants = [];
         foreach ($types as $type) {
@@ -320,6 +327,9 @@ public function getTypesAsString(): string
         return implode(', ', $typeStrings);
     }
 
+    /**
+     * @return list<int>
+     */
     public function getTypes(): array
     {
         $ret = [];
@@ -331,6 +341,9 @@ public function getTypes(): array
         return $ret;
     }
 
+    /**
+     * @param array<int> $types
+     */
     public function setTypes(array $types): Problem
     {
         $types = array_unique($types);

webapp/src/Service/ConfigurationService.php

@@ -410,6 +410,7 @@ public function addOptions(ConfigurationSpecification $item): ConfigurationSpeci
      * identifier key/value pairs. The identifiers try to adhere to
      * https://ccs-specs.icpc.io/draft/contest_api#known-judgement-types
      *
+     * @param list<string> $groups
      * @return array<string, string>
      */
     public function getVerdicts(array $groups = ['final']): array

webapp/src/Service/DOMJudgeService.php

@@ -718,6 +718,7 @@ public function openZipFile(string $filename): ZipArchive
      * @param string      $origname The original filename as submitted by the team
      * @param string|null $language Langid of the programming language this file is in
      * @param bool        $asTeam   Print the file as the team associated with the user
+     * @return array{0: bool, 1: string}
      */
     public function printUserFile(
         string $filename,
@@ -1543,7 +1544,7 @@ public function getScoreboardZip(
     }
 
     /**
-     * @return array{'backgroundColors', array<TeamCategory>}
+     * @return array{backgroundColors: array<string>}
      */
     public function getScoreboardCategoryColorCss(): array {
         $backgroundColors = array_map(fn($x) => ( $x->getColor() ?? '#FFFFFF' ), $this->em->getRepository(TeamCategory::class)->findAll());

webapp/src/Service/ImportProblemService.php

@@ -996,7 +996,11 @@ private function searchAndAddValidator(ZipArchive $zip, ?array &$messages, strin
         return true;
     }
 
-    // Returns true iff the yaml could be parsed correctly.
+    /**
+     * Returns true iff the yaml could be parsed correctly.
+     *
+     * @param array{danger: string[], info: string[]} $messages
+     */
     public static function parseYaml(bool|string $problemYaml, array &$messages, string &$validationMode, PropertyAccessor $propertyAccessor, Problem $problem): bool
     {
         if ($problemYaml === false) {

webapp/src/Utils/Scoreboard/Scoreboard.php

@@ -31,6 +31,7 @@ class Scoreboard
      * @param TeamCategory[]   $categories
      * @param ContestProblem[] $problems
      * @param ScoreCache[]     $scoreCache
+     * @param RankCache[]      $rankCache
      */
     public function __construct(
         protected readonly Contest    $contest,