Add configuration checker to make sure all teams are in a scoring category

Author: nickygerritsen

webapp/src/Service/CheckConfigService.php

@@ -94,6 +94,7 @@ public function runAll(): array
         $teams = [
             'photos' => $this->checkTeamPhotos(),
             'affiliations' => $this->checkAffiliations(),
+            'categories' => $this->checkCategories(),
             'teamdupenames' => $this->checkTeamDuplicateNames(),
             'selfregistration' => $this->checkSelfRegistration(),
         ];
@@ -790,6 +791,34 @@ public function checkAffiliations(): ConfigCheckItem
         );
     }
 
+    public function checkCategories(): ConfigCheckItem
+    {
+        $this->stopwatch->start(__FUNCTION__);
+        /** @var Team[] $teams */
+        $teams = $this->em->getRepository(Team::class)
+                          ->createQueryBuilder('t')
+                          ->innerJoin('t.categories', 'c')
+                          ->select('t, c');
+
+        $desc = '';
+        $result = 'O';
+        foreach ($teams as $team) {
+            if (!$team->getScoringCategory()) {
+                $result = 'W';
+                $desc .= sprintf("  - Team `t%d` (%s) does not belong to any scoring category\n", $team->getTeamid(), $team->getName());
+            }
+        }
+
+        $desc = $desc ?: 'Everything OK';
+
+        $this->stopwatch->stop(__FUNCTION__);
+        return new ConfigCheckItem(
+            caption: 'Team categories',
+            result: $result,
+            desc: $desc
+        );
+    }
+
     public function checkTeamDuplicateNames(): ConfigCheckItem
     {
         $this->stopwatch->start(__FUNCTION__);