Test the right thing

make clean should remove what was created by make all
make distclean should remove what was created by configure

Author: vmcj

.github/jobs/configure-checks/distclean.bats

@@ -266,13 +266,47 @@ build_default() {
     setup_helper
     run run_configure
     assert_success
-    #run make all
-    #if [ "$distro_id" = "ID=fedora" ]; then
-    #    # Because compiling fails
-    #    assert_failure
-    #else
-    #    assert_success
-    #fi
+    after_files=$(find . -type f)
+    filtered_files=()
+    for af in $after_files; do
+        if [[ ! "${before_files[*]}" =~ "${af}" ]]; then
+            filtered_files+=($af)
+            echo "# Lost $af" >&3
+        fi
+    done
+    run make distclean
+    assert_success
+    after_clean_files=$(find . -type f)
+    # Files which were there to begin with should
+    # still be there.
+    for bf in $before_files; do
+        if [[ ! "${after_clean_files[*]}" =~ "${bf}" ]]; then
+            run echo "Wrongly removed: $bf, existed in original tarball but was removed after 'distclean'"
+            refute_line "Wrongly removed: $bf, existed in original tarball but was removed after 'distclean'"
+        fi
+    done
+    # Files which we now find should have been there in the beginning.
+    for af in $after_clean_files; do
+        if [[ ! "${before_files[*]}" =~ "${af}" ]]; then
+            run echo "Wrongly kept: $af, didn't exist in original tarball but was kept after 'distclean'"
+            refute_line "Wrongly kept: $af, didn't exist in original tarball but was kept after 'distclean'"
+        fi
+    done
+}
+
+
+@test "make clean removes all generated files" {
+    docs_required_install &>/dev/zero
+    setup_helper
+    run run_configure
+    assert_success
+    run make all
+    if [ "$distro_id" = "ID=fedora" ]; then
+        # Because compiling fails
+        assert_failure
+    else
+        assert_success
+    fi
     after_files=$(find . -type f)
     # Find the new files not in the tarball
     #echo "# Working with: $after_files" >&3
@@ -283,9 +317,7 @@ build_default() {
             echo "# Lost $af" >&3
         fi
     done
-    #run make clean
-    #assert_success
-    run make distclean
+    run make clean
     assert_success
     after_clean_files=$(find . -type f)
     # Files which were there to begin with should