Properly set validation mode for interactive problems without validation: custom.

Author: meisterT

webapp/src/Service/ImportProblemService.php

@@ -1025,10 +1025,14 @@ public static function parseYaml(bool|string $problemYaml, array &$messages, str
             }
         }
 
+        $validationMode = 'default';
         if (isset($yamlData['type'])) {
             $types = explode(' ', $yamlData['type']);
             // Validation happens later when we set the properties.
             $yamlProblemProperties['typesAsString'] = $types;
+            if (in_array('interactive', $types)) {
+                $validationMode = 'custom interactive';
+            }
         } else {
             $yamlProblemProperties['typesAsString'] = ['pass-fail'];
         }
@@ -1037,7 +1041,6 @@ public static function parseYaml(bool|string $problemYaml, array &$messages, str
             $yamlProblemProperties['special_compare_args'] = $yamlData['validator_flags'];
         }
 
-        $validationMode = 'default';
         if (isset($yamlData['validation'])
             && ($yamlData['validation'] == 'custom' ||
                 $yamlData['validation'] == 'custom interactive' ||

webapp/tests/Unit/Service/ImportProblemServiceTest.php

@@ -294,7 +294,7 @@ public function testKattisExample()
         $this->assertEmpty($messages);
         $this->assertEquals('Guess the Number', $problem->getName());
         $this->assertEquals('pass-fail, interactive', $problem->getTypesAsString());
-        $this->assertEquals('default', $validationMode);
+        $this->assertEquals('custom interactive', $validationMode);
         $this->assertEquals(0, $problem->getTimelimit());
         $this->assertEquals(null, $problem->getMemlimit());
         $this->assertEquals(null, $problem->getOutputlimit());