Command is less risky

Shell opens a real shell and allowes shell features (piping etc.) but
command only runs the command prepared from the python shell

Also changed some of the services as we already assume systemd and now
we can use the reload directly to use less code.

Author: vmcj

icpc-wf/ansible/roles/cds/handlers/main.yml

@@ -1,11 +1,16 @@
 ---
 # Define here handlers associated to this role.
 
-- name: restart systemctl
-  shell: systemctl daemon-reload
-
 - name: restart cds
-  service: name=cds enabled=true state=restarted
+  systemd:
+    name: cds
+    enabled: true
+    state: restarted
+    daemon_reload: true
 
 - name: restart nginx
-  service: name=nginx enabled=true state=restarted
+  systemd:
+    name: nginx
+    enabled: true
+    state: restarted
+    daemon_reload: true

icpc-wf/ansible/roles/cds/tasks/main.yml

@@ -98,7 +98,6 @@
     src: cds.service
     dest: /etc/systemd/system/
   notify:
-    - restart systemctl
     - restart cds
 
 - name: Setup nginx

icpc-wf/ansible/roles/domjudge_build/handlers/main.yml

@@ -2,7 +2,7 @@
 # Define here handlers associated to this role.
 
 - name: fix permissions on domjudge inplace-install
-  shell: make -C {{ DJ_DIR }} inplace-postinstall-permissions
+  command: make -C {{ DJ_DIR }} inplace-postinstall-permissions
 
 - name: restart rsyslog
   service: name=rsyslog enabled=true state=restarted

icpc-wf/ansible/roles/icpc_fixes/tasks/main.yml

@@ -16,7 +16,7 @@
     state: absent
 
 - name: Re-order PXEboot
-  shell: efibootmgr -o {{ EFI_ORDER }}
+  command: efibootmgr -o {{ EFI_ORDER }}
   when: EFI_ORDER is defined
 
 - name: disable mumble,selfie services

icpc-wf/ansible/roles/judgedaemon/handlers/main.yml

@@ -1,23 +1,29 @@
 ---
 # Define here handlers associated to this role.
 
-- name: restart systemctl
-  shell: systemctl daemon-reload
-
 - name: enable and restart tune_cpu
-  service: name=tune_cpu enabled=true state=restarted
+  systemd:
+    name: tune_cpu
+    enabled: true
+    state: restarted
+    daemon_reload: true
 
 - name: enable and restart create-cgroups
-  service: name=create-cgroups enabled=true state=restarted
+  service:
+    name: create-cgroups
+    enabled: true
+    state: restarted
+    daemon_reload: true
 
 - name: enable and restart judgedaemon
   service:
-    name="domjudge-judgehost.target"
-    enabled=true
-    state=restarted
+    name: "domjudge-judgehost.target"
+    enabled: true
+    state: restarted
+    daemon_reload: true
 
 - name: update grub
-  shell: update-grub
+  command: update-grub
 
 - name: reboot
   reboot:

icpc-wf/ansible/roles/judgedaemon/tasks/main.yml

@@ -60,7 +60,6 @@
     src: tune_cpu.service
     dest: /etc/systemd/system/
   notify:
-    - restart systemctl
     - enable and restart tune_cpu
 
 - name: copy judgedaemon related systemd unit files
@@ -72,15 +71,13 @@
     - create-cgroups
     - domjudge-judgedaemon@
   notify:
-    - restart systemctl
     - enable and restart create-cgroups
 
 - name: template judgedaemon template systemd unit file
   template:
     src: domjudge-judgehost.target.j2
     dest: /etc/systemd/system/domjudge-judgehost.target
   notify:
-    - restart systemctl
     - enable and restart judgedaemon
 
 - name: disable systemd timers

icpc-wf/ansible/roles/system_fixes/handlers/main.yml

@@ -2,4 +2,4 @@
 # Define here handlers associated to this role.
 
 - name: update dconf
-  shell: dconf update
+  command: dconf update