Fix ansible linting issues

Author: vmcj

provision-contest/ansible/admin.yml

@@ -1,7 +1,7 @@
 ---
 # This playbook an admin machine with a dev DOMjudge instance
 
-- name: setup admin machines
+- name: Setup admin machines
   hosts: admin
   vars:
     host_type: admin
@@ -44,7 +44,7 @@
   handlers:
     - include: handlers.yml
   tasks:
-    - name: install common required/useful packages
+    - name: Install common required/useful packages
       tags: packages
       apt:
         state: present
@@ -54,32 +54,32 @@
           - makepasswd
           - mmv
 
-    - name: enable developer mode
+    - name: Enable developer mode
       lineinfile:
         regexp: 'APP_ENV='
         line: 'APP_ENV=dev'
         dest: "{{ DJ_DIR }}/webapp/.env.local"
         create: true
 
-    - name: add cds to hosts file
+    - name: Add cds to hosts file
       lineinfile:
         dest: /etc/hosts
         regexp: 'cds$'
         line: "10.3.3.207 cds"
 
-    - name: add kattis to hosts file
+    - name: Add kattis to hosts file
       lineinfile:
         dest: /etc/hosts
         regexp: 'kattis$'
         line: "10.3.3.212 kattis"
 
-    - name: add domjudge-laptop to hosts file
+    - name: Add domjudge-laptop to hosts file
       lineinfile:
         dest: /etc/hosts
         regexp: 'domjudge-laptop$'
         line: "10.3.3.200 domjudge-laptop"
 
-    - name: add nisprint to hosts file
+    - name: Add nisprint to hosts file
       lineinfile:
         dest: /etc/hosts
         regexp: 'printsrv$'
@@ -89,25 +89,25 @@
       set_fact:
         dj_git_repo_scripts: "{{ DJ_GIT_REPO_SCRIPTS_RESTRICTED if WF_RESTRICTED_NETWORK else DJ_GIT_REPO_SCRIPTS }}"
 
-    - name: create working copy of the domjudge-scripts repo
+    - name: Create working copy of the domjudge-scripts repo
       become: true
       become_user: domjudge
       # We use a different directory here to have one single 'upstream' and not have issues with it
       git: repo={{ dj_git_repo_scripts }} dest=/home/domjudge/domjudge-scripts-checkout version=main accept_hostkey=yes update=no
 
-    - name: create working copy of the wf2020 repo
+    - name: Create working copy of the wf2020 repo
       become: true
       become_user: domjudge
       git: repo=git@cds:wf2020 dest=/home/domjudge/wf2020 version=master accept_hostkey=yes update=no
 
-    - name: copy custom CSS file for admin machines
+    - name: Copy custom CSS file for admin machines
       copy:
         src: admin-machine.css
         dest: "{{ DJ_DIR }}/webapp/public/css/custom/admin-machine.css"
         owner: domjudge
         group: domjudge
         mode: 0644
-      notify: clear application cache
+      notify: Clear application cache
 
     - name: Install netrc file
       template:

provision-contest/ansible/cds.yml

@@ -1,7 +1,7 @@
 ---
 # This playbook installs the CDS
 
-- name: setup CDS
+- name: Setup CDS
   hosts: cds
   vars:
     host_type: cds

provision-contest/ansible/domserver.yml

@@ -1,7 +1,7 @@
 ---
 # This playbook installs the DOMjudge server(s)
 
-- name: setup domserver
+- name: Setup domserver
   hosts: domserver
   vars:
     host_type: domserver
@@ -50,27 +50,27 @@
   handlers:
     - include: handlers.yml
   tasks:
-    - name: install domserver required packages
+    - name: Install domserver required packages
       apt:
         state: present
         pkg:
           - python3-mysqldb
           - macchanger
           - molly-guard
 
-    - name: disable developer mode
+    - name: Disable developer mode
       lineinfile:
         regexp: '^APP_ENV=dev'
         state: absent
         dest: "{{ DJ_DIR }}/webapp/.env.local"
 
-    - name: install contest images
+    - name: Install contest images
       synchronize:
         src: files/domjudge-public/
         dest: "{{ DJ_DIR }}/webapp/public"
         owner: false
         use_ssh_args: true
-      notify: clear application cache
+      notify: Clear application cache
 
     - name: Add documentation in DOMjudge team interface
       copy:
@@ -79,9 +79,9 @@
         mode: 0644
         group: root
         owner: root
-      notify: clear application cache
+      notify: Clear application cache
 
-    - name: add autostart shortcuts
+    - name: Add autostart shortcuts
       copy:
         src: files/{{ item }}.desktop
         dest: /home/domjudge/.config/autostart/
@@ -92,7 +92,7 @@
         - htop
         - taillog-domserver-nginx-error
 
-    - name: add autostart shortcuts from template
+    - name: Add autostart shortcuts from template
       template:
         src: files/{{ item }}.desktop.j2
         dest: /home/domjudge/.config/autostart/{{ item }}.desktop

provision-contest/ansible/handlers.yml

@@ -1,21 +1,20 @@
 # Common definition of handlers
 ---
-- name: clear application cache
+- name: Clear application cache
   command: "{{ DJ_DIR }}/webapp/bin/console cache:clear"
   become: true
   become_user: domjudge
 
-- name: rebuild domjudge
+- name: Rebuild domjudge
   become: true
   become_user: domjudge
   make:
     chdir: "{{ DJ_DIR }}"
     target: inplace-install
-  notify: fix permissions on domjudge inplace-install
+  notify: Fix permissions on domjudge inplace-install
 
-- name: restart nginx
+- name: Restart nginx
   systemd:
     name: nginx
     enabled: true
     state: restarted
-

provision-contest/ansible/judgehost.yml

@@ -1,7 +1,7 @@
 ---
 # This playbook installs the DOMjudge judgehosts
 
-- name: setup judgehost
+- name: Setup judgehost
   hosts: judgehost
   # We always leave 2/3 of the judges online
   serial:
@@ -60,7 +60,7 @@
       with_sequence: start=0 end={{ ansible_processor_vcpus }} format=domjudge-judgedaemon@%1x
       when: service_file.stat.exists
   tasks:
-    - name: add autostart shortcuts
+    - name: Add autostart shortcuts
       template:
         src: files/{{ item }}.desktop
         dest: /home/domjudge/.config/autostart/
@@ -71,7 +71,7 @@
         - rotate
       when: GRAPHICAL
 
-    - name: add autostart shortcuts from template
+    - name: Add autostart shortcuts from template
       template:
         src: files/{{ item }}.desktop.j2
         dest: /home/domjudge/.config/autostart/{{ item }}.desktop

provision-contest/ansible/mgmt.yml

@@ -1,7 +1,7 @@
 ---
 # This playbook installs the Management machine
 
-- name: setup management
+- name: Setup management
   hosts: mgmt
   vars:
     host_type: mgmt

provision-contest/ansible/roles/base_packages/handlers/main.yml

@@ -1,4 +1,4 @@
 ---
-- name: run apt update
+- name: Run apt update
   apt:
     update_cache: true

provision-contest/ansible/roles/base_packages/tasks/install-local-package.yml

@@ -1,19 +1,19 @@
 # Install a single local DEB package.
 ---
-- name: create temp package directory
+- name: Create temp package directory
   file:
     path: /tmp/dj_ansible
     state: directory
     owner: root
     group: root
     mode: 0700
 
-- name: copy DEB package to remote
+- name: Copy DEB package to remote
   synchronize:
     src: "{{ item }}"
     dest: "/tmp/dj_ansible/{{ item | basename }}"
 
-- name: install DEB package {{ item | basename }}
+- name: Install DEB package {{ item | basename }}
   apt:
     deb: "/tmp/dj_ansible/{{ item | basename }}"
     state: present

provision-contest/ansible/roles/base_packages/tasks/main.yml

@@ -1,8 +1,9 @@
 ---
 # This task configures packaging and installs various system utilities
 
-- block:
-  - name: replace pc2.ecs.baylor.edu by packages in apt sources
+- name: World finals fixes for apt sources
+  block:
+  - name: Replace pc2.ecs.baylor.edu by packages in apt sources
     replace:
       dest: "/etc/apt/{{ item }}"
       regexp: 'pc2\.ecs\.baylor\.edu'
@@ -13,44 +14,44 @@
       - sources.list.d/mono.list
       - sources.list.d/vscode.list
       - sources.list.d/pypy-ubuntu-ppa-buster.list
-    notify: run apt update
+    notify: Run apt update
 
-  - name: add packages to hosts file
+  - name: Add packages to hosts file
     lineinfile:
       dest: /etc/hosts
       regexp: '^10\.3\.3\.209'
       line: "10.3.3.209 packages"
-    notify: run apt update
+    notify: Run apt update
 
-  - name: remove pycharm repo
+  - name: Remove pycharm repo
     replace:
       dest: /etc/apt/sources.list
       regexp: '^([^#].*pycharm.*)$'
       replace: '# \1'
-    notify: run apt update
+    notify: Run apt update
   when: ICPC_IMAGE and WF_RESTRICTED_NETWORK
 
-- name: check for dpkg architecture i386
+- name: Check for dpkg architecture i386
   command: dpkg --print-foreign-architectures
   register: dpkg_architectures
   changed_when: false
 
-- name: remove unused dpkg architecture i386
+- name: Remove unused dpkg architecture i386
   command: dpkg --remove-architecture i386
-  notify: run apt update
+  notify: Run apt update
   when: dpkg_architectures.stdout.find('i386') != -1
 
-- name: flush handlers
+- name: Flush handlers
   meta: flush_handlers
 
-- name: remove some packages
+- name: Remove some packages
   apt:
     state: absent
     pkg:
       - apport
       - ntp
 
-- name: install common required/useful packages
+- name: Install common required/useful packages
   apt:
     state: present
     pkg:
@@ -122,7 +123,7 @@
   command: php /root/composer-setup.php --install-dir=/usr/local/bin --filename=composer
   when: not composer_file.stat.exists
 
-- name: install local DEB packages
+- name: Install local DEB packages
   include: install-local-package.yml
   with_fileglob:
     - install-{{ host_type }}/*.deb

provision-contest/ansible/roles/cds/handlers/main.yml

@@ -1,5 +1,5 @@
 ---
-- name: restart cds
+- name: Restart cds
   systemd:
     name: cds
     enabled: true