Use loop instead of with_items in all the places.

Author: nickygerritsen

icpc-wf/ansible/domserver.yml

@@ -81,7 +81,7 @@
         owner: domjudge
         group: domjudge
         mode: 0755
-      with_items:
+      loop:
         - htop
         - taillog-domserver-nginx-error
 
@@ -92,5 +92,5 @@
         owner: domjudge
         group: domjudge
         mode: 0755
-      with_items:
+      loop:
         - taillog-domserver-symfony-error

icpc-wf/ansible/judgehost.yml

@@ -54,7 +54,7 @@
         owner: domjudge
         group: domjudge
         mode: 0755
-      with_items:
+      loop:
         - rotate
 
     - name: add autostart shortcuts from template
@@ -64,5 +64,5 @@
         owner: domjudge
         group: domjudge
         mode: 0755
-      with_items:
+      loop:
         - taillog

icpc-wf/ansible/roles/base_packages/tasks/main.yml

@@ -6,7 +6,7 @@
     dest: "/etc/apt/{{ item }}"
     regexp: 'pc2\.ecs\.baylor\.edu'
     replace: 'packages'
-  with_items:
+  loop:
     - sources.list
     - sources.list.d/microsoft.list
     - sources.list.d/mono.list

icpc-wf/ansible/roles/clusterssh/tasks/main.yml

@@ -24,7 +24,7 @@
     regexp: '^{{ item }}s'
     line: "{{item}}s {{ groups[item] | join(' ') }}"
     create: yes
-  with_items:
+  loop:
     - domserver
     - judgehost
     - admin

icpc-wf/ansible/roles/domjudge_user/tasks/main.yml

@@ -23,7 +23,7 @@
     value: "{{item.value}}"
     owner: domjudge
     group: domjudge
-  with_items:
+  loop:
     - { name: 'email', value: 'team@domjudge.org' }
     - { name: 'name', value: 'DOMjudge team' }
 

icpc-wf/ansible/roles/domserver/tasks/main.yml

@@ -43,7 +43,7 @@
   command: phpenmod {{item}}
   args:
     creates: /etc/php/7.4/fpm/conf.d/20-{{item}}.ini
-  with_items:
+  loop:
     - zip
     - intl
 
@@ -85,7 +85,7 @@
     dest: /etc/php/7.4/fpm/pool.d/domjudge.conf
     regexp: "{{item.regexp}}"
     line: "{{item.key}} = {{item.value}}"
-  with_items:
+  loop:
     - { key: 'pm.max_children', regexp: '^pm\.max_children', value: '{{PHP_FPM_MAX_CHILDREN}}' }
     - { key: 'pm.max_requests', regexp: '^pm\.max_requests', value: '{{PHP_FPM_MAX_REQUESTS}}' }
     - { key: 'php_admin_value[memory_limit]', regexp: '^php_admin_value\[memory_limit\]', value: '{{PHP_MEMORY_LIMIT}}' }

icpc-wf/ansible/roles/icpc_fixes/tasks/main.yml

@@ -24,6 +24,6 @@
     name: "{{ item }}"
     state: stopped
     enabled: no
-  with_items:
+  loop:
     - mumble-server
     - selfie

icpc-wf/ansible/roles/judgedaemon/handlers/main.yml

@@ -15,7 +15,7 @@
     name="domjudge-judgedaemon@{{item}}"
     enabled=yes
     state=restarted
-  with_items: "{{CPUCORE}}"
+  loop: "{{CPUCORE}}"
 
 - name: update grub
   shell: update-grub

icpc-wf/ansible/roles/judgedaemon/tasks/main.yml

@@ -3,7 +3,7 @@
 
 - name: create domjudge-run users
   user: name=domjudge-run-{{item}} createhome=no home=/nonexistent group=nogroup shell=/bin/false
-  with_items: "{{CPUCORE}}"
+  loop: "{{CPUCORE}}"
 
 - name: create domjudge-run group
   group: name=domjudge-run state=present
@@ -68,7 +68,7 @@
     remote_src: true
     src: "{{DJ_DIR}}/lib/judge/{{item}}.service"
     dest: /etc/systemd/system/
-  with_items:
+  loop:
     - create-cgroups
     - domjudge-judgedaemon@
   notify:
@@ -80,7 +80,7 @@
   command: systemctl mask {{item}}
   args:
     creates: /etc/systemd/system/{{item}}
-  with_items:
+  loop:
     - apt-daily-upgrade.timer
     - apt-daily.timer
     - systemd-tmpfiles-clean.timer

icpc-wf/ansible/roles/ssh/tasks/main.yml

@@ -16,7 +16,7 @@
     owner: domjudge
     group: domjudge
     mode: 0600
-  with_items:
+  loop:
     - config
     - id_rsa
     - id_rsa.pub
@@ -26,7 +26,7 @@
     src: "{{ item }}"
     dest: /root/.ssh/
     mode: 0600
-  with_items:
+  loop:
     - config
     - id_rsa
     - id_rsa.pub
@@ -36,6 +36,6 @@
     user: "{{ item }}"
     state: present
     key: "{{ lookup('file', 'id_rsa.pub') }}"
-  with_items:
+  loop:
     - domjudge
     - root