Test ansible scripts with default linter

We first ignore all errors and fix those in separate commits.

Author: vmcj

.github/linting.sh

@@ -0,0 +1,14 @@
+#!/usr/bin/bash
+
+set -euxo pipefail
+
+# shellcheck disable=SC2044
+for book in $(find ./ -maxdepth 1 -name "*.yml"); do
+    if [ "$book" != "./handlers.yml" ]; then
+        ansible-lint "$book" -x braces,line-length
+    fi
+done
+# shellcheck disable=SC2044
+for dir in $(find ./roles -maxdepth 1 -type d); do
+    ansible-lint "$dir" -x braces,line-length
+done

.github/workflows/ansible-linting.yml

@@ -0,0 +1,22 @@
+name: Test contest deployment (ansible scripts) [PIP]
+
+on: [push,pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+      - name: Install ansible lint tools
+        run: sudo apt update; sudo pip install ansible-lint
+      - name: Lint the different scripts 
+        run: |
+          set -eux
+          ansible-lint --version
+          ansible-lint .
+        working-directory: icpc-wf/ansible
+      - name: Lint the different scripts (Via the script)
+        run: ../../.github/linting.sh
+        working-directory: icpc-wf/ansible
+

icpc-wf/ansible/.ansible-lint

@@ -0,0 +1,10 @@
+parseable: true
+skip_list:
+  - no-handler     # TODO: this might break existing playbooks
+  - 503            # TODO: this might break existing playbooks
+  - meta-no-info   # We don't publish to galaxy (yet)
+  - 701            # We don't publish to galaxy (yet)
+  - fqcn-builtins  # I see no benefit as we dont use custom roles
+  - 204            # The long line should be re-evaluated
+use_default_rules: true
+verbosity: 1

icpc-wf/ansible/judgehost.yml

@@ -41,11 +41,14 @@
       tags: prometheus_target_all
       when: GRAFANA_MONITORING
   pre_tasks:
+    - name: Get current services
+      service_facts:
     - name: Disable all cores
       service:
         name="domjudge-judgedaemon@{{item}}"
         state=stopped
       with_sequence: start=0 end={{ ansible_processor_vcpus }} format=domjudge-judgedaemon@%1x
+      when: '"domjudge-judgedaemon@0.service" in services'
   tasks:
     - name: add autostart shortcuts
       template: