Configure phpstan and fix the errors

Author: DEVizzent

Makefile

@@ -19,9 +19,6 @@ debug:  ## Start application containers and required services
 down:  ## Stop application containers and required services
 	@docker-compose down
 
-console:  ## Execute php container console
-	@docker exec -it ${PHP_CONTAINER_NAME} bash
-
 test:  ## Execute all phpunit test
 	@docker-compose exec ${PHP_CONTAINER_NAME} ./vendor/bin/phpunit
 

composer.json

@@ -25,6 +25,8 @@
   "require-dev": {
     "phpmd/phpmd": "2.*",
     "phpstan/phpstan": "1.*",
+    "phpstan/phpstan-deprecation-rules": "^1.0",
+    "phpstan/phpstan-strict-rules": "^1.4",
     "squizlabs/php_codesniffer": "3.*"
   }
 }

phpstan.neon.dist

@@ -0,0 +1,16 @@
+parameters:
+    level: 8
+
+    treatPhpDocTypesAsCertain: false
+    reportUnmatchedIgnoredErrors: true
+
+    paths:
+        - src/
+
+    excludePaths:
+
+    ignoreErrors:
+
+includes:
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
+    - vendor/phpstan/phpstan-deprecation-rules/rules.neon

src/MockServerHelper.php

@@ -2,6 +2,7 @@
 
 namespace DEVizzent\CodeceptionMockServerHelper;
 
+use Codeception\Lib\ModuleContainer;
 use Codeception\Module;
 use GuzzleHttp\Client;
 use GuzzleHttp\Psr7\Request;
@@ -11,18 +12,22 @@ class MockServerHelper extends Module
 {
     private Client $mockserverClient;
 
-    public function __construct()
+    /**
+     * @param array<string, string> $config
+     */
+    public function __construct(ModuleContainer $moduleContainer, ?array $config = null)
     {
+        parent::__construct($moduleContainer, $config);
         $this->mockserverClient = new Client(['base_uri'  => 'http://mockserver:1080']);
     }
-
     public function seeMockRequestWasCalled(string $expectationId, ?int $times = null): void
     {
-        $body = [
+        $body = json_encode([
             'expectationId' => ['id' => $expectationId],
             'times' => ['atLeast' => $times ?? 1, 'atMost' => $times ?? 1000]
-        ];
-        $request = new Request('PUT', '/mockserver/verify', [], json_encode($body));
+        ]);
+        Assert::assertNotFalse($body);
+        $request = new Request('PUT', '/mockserver/verify', [], $body);
         $response = $this->mockserverClient->sendRequest($request);
         Assert::assertEquals(
             202,
@@ -36,7 +41,7 @@ public function seeMockRequestWasNotCalled(string $expectationId): void
         $this->seeMockRequestWasCalled($expectationId, 0);
     }
 
-    public function resetMockServerLogs()
+    public function resetMockServerLogs(): void
     {
         $request = new Request('PUT', '/mockserver/clear?type=log');
         $response = $this->mockserverClient->sendRequest($request);