[core] Minor fixes for SFX

Author: DC-SWAT

applications/games_menu/modules/preset.c

@@ -1507,7 +1507,7 @@ void ShowPresetMenu(int game_index)
 				&menu_data.border_color, &menu_data.control_top_color, &body_color, &menu_data.control_bottom_color,
 				&OnViewIndexChangedEvent);
 
-			char sfx_path[50];
+			char sfx_path[NAME_MAX];
 			int volume = GetVolumeFromSettings();
 			if (ds_sfx_is_enabled(DS_SFX_CLICK2))
 			{

applications/games_menu/modules/system_menu.c

@@ -160,7 +160,7 @@ void ShowSystemMenu()
 		, true, true, form_font, &menu_data.border_color, &menu_data.control_top_color, &body_color, &menu_data.control_bottom_color,
 		&OnSystemViewIndexChangedEvent);
 
-		char sfx_path[50];
+		char sfx_path[NAME_MAX];
 		int volume = GetVolumeFromSettings();
 		if (ds_sfx_is_enabled(DS_SFX_CLICK2))
 		{

include/sfx.h

@@ -25,6 +25,7 @@ typedef enum {
 
 int ds_sfx_play(ds_sfx_t sfx);
 int ds_sfx_is_enabled(ds_sfx_t sfx);
-void ds_sfx_get_wav(char sfx_path[], int sfx_sel);
+void ds_sfx_get_wav(char sfx_path[], ds_sfx_t sfx_sel);
+
 
 #endif /* _DS_SFX_H */

src/sfx.c

@@ -178,8 +178,8 @@ static int ds_sfx_get_volume() {
 	return settings->audio.volume;
 }
 
-void ds_sfx_get_wav(char sfx_path[], int sfx_sel) {
-	if (sfx_sel >= 0) {
+void ds_sfx_get_wav(char sfx_path[], ds_sfx_t sfx_sel) {
+	if (sfx_sel >= 0 && sfx_sel < DS_SFX_LAST) {
 		snprintf(sfx_path, NAME_MAX, "%s/sfx/%s.wav", getenv("PATH"), sys_sfx_name[sfx_sel]);
 	}
 	else {