Fix for mocking Exec with custom []string datatype

Benjamin Rupp · Benjamin Rupp · commit 327ae5dcb6eb · 2019-09-25T09:13:06.000-04:00
diff --git a/expectations_go18.go b/expectations_go18.go
@@ -4,7 +4,6 @@ package sqlmock
 
 import (
 	"database/sql"
-	"database/sql/driver"
 	"fmt"
 	"reflect"
 )
@@ -54,10 +53,6 @@ func (e *queryBasedExpectation) argsMatches(args []namedValue) error {
 			return fmt.Errorf("could not convert %d argument %T - %+v to driver value: %s", k, e.args[k], e.args[k], err)
 		}
 
-		if !driver.IsValue(darg) {
-			return fmt.Errorf("argument %d: non-subset type %T returned from Value", k, darg)
-		}
-
 		if !reflect.DeepEqual(darg, v.Value) {
 			return fmt.Errorf("argument %d expected [%T - %+v] does not match actual [%T - %+v]", k, darg, darg, v.Value, v.Value)
 		}

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ package sqlmock`
`4`	`4`
`5`	`5`	`import (`
`6`	`6`	`"database/sql"`
`7`		`- "database/sql/driver"`
`8`	`7`	`"fmt"`
`9`	`8`	`"reflect"`
`10`	`9`	`)`
`@@ -54,10 +53,6 @@ func (e *queryBasedExpectation) argsMatches(args []namedValue) error {`
`54`	`53`	`return fmt.Errorf("could not convert %d argument %T - %+v to driver value: %s", k, e.args[k], e.args[k], err)`
`55`	`54`	`}`
`56`	`55`
`57`		`- if !driver.IsValue(darg) {`
`58`		`- return fmt.Errorf("argument %d: non-subset type %T returned from Value", k, darg)`
`59`		`- }`
`60`		`-`
`61`	`56`	`if !reflect.DeepEqual(darg, v.Value) {`
`62`	`57`	`return fmt.Errorf("argument %d expected [%T - %+v] does not match actual [%T - %+v]", k, darg, darg, v.Value, v.Value)`
`63`	`58`	`}`