Skip to content

Commit 7db43ac

Browse files
committed
Refactor and README.md changes
1 parent 38cee47 commit 7db43ac

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ React Firebase Admin is our in-house admin dashboard boilerplate, used in many o
8888
- [Format.js](https://formatjs.io/) (★ 11.7k) libraries for internationalization (see [docs](https://formatjs.io/docs/basic-internationalization-principles)).
8989
- [date-fns](https://date-fns.org/) (★ 22.3k) date utility library (see [docs](https://date-fns.org/docs/Getting-Started)).
9090
- [cross-env](https://github.com/kentcdodds/cross-env) (★ 4.9k) run scripts that set and use environment variables across platforms (see [docs](https://www.npmjs.com/package/cross-env)).
91+
- [React Hook Form](https://github.com/react-hook-form/react-hook-form) (★ 14.6k) Performant, flexible and extensible forms with easy to use validation.
92+
- [yup](https://github.com/jquense/yup) (★ 11k) schema builder for value parsing and validation.
9193

9294
### Unit Testing
9395

src/components/UserForm/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const UserForm = ({ isEditing, isProfile, user, onSubmitHandler, schema }) => {
3636
setValue('file', null);
3737
}
3838
return () => dispatch(usersCleanUp());
39-
}, [dispatch, success]);
39+
}, [dispatch, success, setValue]);
4040

4141
const invalidEmailMessage = useFormatMessage('UserForm.invalidEmail');
4242

src/pages/Login/index.jsx

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -155,17 +155,18 @@ const Login = () => {
155155
ref={register}
156156
/>
157157
</div>
158-
{isEmailLink ? (
159-
errors.password ? (
160-
<ErrorMessage text={unsafePasswordMessage} />
161-
) : (
162-
isValidPassword && (
163-
<p className="is-success">{safePasswordMessage}</p>
164-
)
165-
)
158+
{errors.password ? (
159+
<ErrorMessage
160+
text={
161+
isEmailLink
162+
? unsafePasswordMessage
163+
: invalidPasswordMessage
164+
}
165+
/>
166166
) : (
167-
errors.password && (
168-
<ErrorMessage text={invalidPasswordMessage} />
167+
isEmailLink &&
168+
isValidPassword && (
169+
<p className="is-success">{safePasswordMessage}</p>
169170
)
170171
)}
171172
</div>

src/pages/Users/index.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ const Users = () => {
160160
delete clonedElem.id;
161161
delete clonedElem.isAdmin;
162162
delete clonedElem.logoUrl;
163-
delete clonedElem.teams;
164163
return Object.values(clonedElem).some((field) =>
165164
field.toLowerCase().includes(search.toLowerCase())
166165
);

0 commit comments

Comments
 (0)