New replicator config

[jayant-dhingra-cb]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jayant-dhingra-cb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant update to the Replicator Configuration API, shifting towards a more explicit collection-based setup. It ensures that both the new and old API configurations are supported, particularly within the native iOS module, and provides dedicated test screens for each. The changes also include routine dependency updates and a new logging utility, though a current build failure in the cbl-reactnative module is noted.

Highlights

• Replicator Configuration API Update: The core replicator configuration mechanism has been updated. Instead of initializing ReplicatorConfiguration with just an endpoint and then adding collections, it now accepts a list of CollectionConfiguration objects directly in its constructor. This change is reflected in custom-bug-fix.tsx and createReplicatorFromConfig.ts.
• New and Old API Test Screens: New test screens have been added to demonstrate both the updated (new) and the previous (old) replicator configuration APIs. replication-new.tsx and replicator-listeners-new.tsx showcase the new API, while replicator-listeners-old.tsx is specifically for the old API, ensuring backward compatibility or comparison.
• Native Module Adaptation for Dual API: The CblReactnative.swift native module has been enhanced to support both the new and old replicator configuration API formats from JavaScript. It now automatically detects the format of the incoming configuration JSON string and processes it accordingly.
• Build System and Dependency Updates: The expo-example/android/build.gradle file updates the Kotlin version to 1.9.25, and expo-example/android/settings.gradle modifies the React Native Gradle plugin resolution. Several submodules (cblite-js-tests, cbl-js-swift, cblite-js) have also been updated to newer commits.
• Build Log and Logging Script Added: A build-log.txt file has been added, which currently indicates a compilation failure in the cbl-reactnative module. Additionally, a view-logs.sh script is included to facilitate monitoring Android replicator-related logs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the replicator configuration to use a new API across the application, including test files and services. It also adds new test screens for both the new and old replicator APIs. My review has identified several issues, including two critical security vulnerabilities due to hardcoded credentials in test files. I've also pointed out a bug in error handling, some code style and formatting inconsistencies, and the accidental commit of a build log file. I recommend addressing the critical security issues before merging.

[gemini-code-assist]

Hardcoded credentials found. Storing secrets like usernames and passwords directly in the source code is a major security risk. These credentials can be easily extracted from the compiled application, even from test files. It's highly recommended to use a secure method for managing secrets, such as environment variables or a secrets management service.

[velicuvlad]

Although this is not going into a release branch, I think it would be good to not publish/expose credentials at all on remote.

[gemini-code-assist]

Hardcoded credentials and connection strings are present. This is a significant security risk, even in test files. These values should be externalized from the code, for example using environment variables or a configuration management system.

[velicuvlad]

same about creds here. You can make a patch file with this and hold it somewhere locally and can apply it every time you refresh your repo. Or by using stash and pop before and after committing on remote. I use both depending on how much custom is the config I need.

[gemini-code-assist]

There's a reference to an undefined variable error inside the catch block. The caught exception is named e, so you should use e.message instead. The // @ts-ignore comment is hiding this compilation error and should be removed.

Suggested change

	// @ts-ignore
	return [error.message];
	return [e.message];

[gemini-code-assist]

For better readability and to adhere to standard coding practices, each import statement should be on its own line.

Suggested change

	} from 'cbl-reactnative';import getFileDefaultPath from '@/service/file/getFileDefaultPath';
	} from 'cbl-reactnative';
	import getFileDefaultPath from '@/service/file/getFileDefaultPath';

[gemini-code-assist]

This check for null or undefined can be simplified. Using !database is more concise and idiomatic in TypeScript for this purpose.

Suggested change

	if(database === null || database === undefined) {
	if(!database) {

[gemini-code-assist]

The comments explaining the API change can be removed as the code is now straightforward. Also, there are extra blank lines and an extra space in the constructor call that can be cleaned up for better readability.

Suggested change

	//Create CollectionConfiguration
	const collectionConfig = new CollectionConfiguration(defaultCollection);
	const listOfCollectionConfig = [collectionConfig]
	// Pass array of configs and endpoint to constructor
	const replicatorConfig = new ReplicatorConfiguration(listOfCollectionConfig , endpoint);
	const collectionConfig = new CollectionConfiguration(defaultCollection);
	const listOfCollectionConfig = [collectionConfig];
	const replicatorConfig = new ReplicatorConfiguration(listOfCollectionConfig, endpoint);

[gemini-code-assist]

Using // @ts-ignore to suppress TypeScript errors in catch blocks is not ideal as it can hide real issues. A better practice is to type the error object, for example with any. This pattern is repeated throughout the file and should be corrected in all occurrences.

    } catch (error: any) {
      setErrorLogs(prev => [...prev, `Error opening database: ${error.message}`]);
    }

[gemini-code-assist]

This build log file appears to have been accidentally committed. Log files and build artifacts are typically excluded from version control using .gitignore. Please remove this file from the repository.

[gemini-code-assist]

Using a floating-point number for an id can be brittle and may lead to precision issues in some cases. It's generally better to use integers or strings for unique identifiers. If the goal is to insert an item, consider renumbering the subsequent integer IDs.

[gemini-code-assist]

There is a typo in the variable name listOfCollectionConfigrations. It should be listOfCollectionConfigurations.

Suggested change

	const listOfCollectionConfigrations = cols.map((col) => new CollectionConfiguration(col))
	const config = new ReplicatorConfiguration(listOfCollectionConfigrations, target);
	const listOfCollectionConfigurations = cols.map((col) => new CollectionConfiguration(col));
	const config = new ReplicatorConfiguration(listOfCollectionConfigurations, target);

[velicuvlad]

With small comments and a couple of copilot 👍🏻 , looks good. These are mostly test app changes so not very strict on logging etc.

[velicuvlad]

Although this is not going into a release branch, I think it would be good to not publish/expose credentials at all on remote.

[velicuvlad]

same about creds here. You can make a patch file with this and hold it somewhere locally and can apply it every time you refresh your repo. Or by using stash and pop before and after committing on remote. I use both depending on how much custom is the config I need.