Remove Deref impl for Checksum

Author: chipshort

contracts/virus/src/contract.rs

@@ -60,11 +60,9 @@ pub fn execute_spread(
 
         attributes.push(Attribute::new(format!("path{i}"), path.clone()));
 
-        // clippy produces a false positive here, see https://github.com/rust-lang/rust-clippy/issues/9841
-        #[allow(clippy::explicit_auto_deref)]
-        let address = deps
-            .api
-            .addr_humanize(&instantiate2_address(&*checksum, &creator, &salt)?)?;
+        let address =
+            deps.api
+                .addr_humanize(&instantiate2_address(checksum.as_ref(), &creator, &salt)?)?;
         attributes.push(Attribute::new(
             format!("predicted_address{i}"),
             address.clone(),

packages/std/src/checksum.rs

@@ -1,5 +1,4 @@
 use core::fmt;
-use core::ops::Deref;
 
 use schemars::JsonSchema;
 use serde::{de, ser, Deserialize, Deserializer, Serialize};
@@ -53,19 +52,6 @@ impl From<[u8; 32]> for Checksum {
     }
 }
 
-/// Just like Vec<u8>, Checksum is a smart pointer to [u8].
-/// This implements `*data` for us and allows us to
-/// do `&*data`, returning a `&[u8]` from a `&Checksum`.
-/// With [deref coercions](https://doc.rust-lang.org/1.22.1/book/first-edition/deref-coercions.html#deref-coercions),
-/// this allows us to use `&data` whenever a `&[u8]` is required.
-impl Deref for Checksum {
-    type Target = [u8; 32];
-
-    fn deref(&self) -> &Self::Target {
-        self.as_ref()
-    }
-}
-
 impl AsRef<[u8; 32]> for Checksum {
     fn as_ref(&self) -> &[u8; 32] {
         &self.0
@@ -210,9 +196,6 @@ mod tests {
     #[test]
     fn ref_conversions_work() {
         let checksum = Checksum::generate(&[12u8; 17]);
-        // deref
-        let _: &[u8; 32] = &checksum;
-        let _: &[u8] = &*checksum;
         // as_ref
         let _: &[u8; 32] = checksum.as_ref();
         let _: &[u8] = checksum.as_ref();