Merge pull request #1967 from CosmWasm/1760-remove-backtrace-feature

Remove backtraces feature

Author: chipshort

CHANGELOG.md

@@ -58,6 +58,12 @@ and this project adheres to
   `AnalysisReport::required_capabilities` a `BTreeSet`. ([#1949])
 - cosmwasm-std: Add `Checksum` type and change type of
   `CodeInfoResponse::checksum` to that. ([#1944])
+- cosmwasm-std: Removed `backtraces` feature, use the `RUST_BACKTRACE=1` env
+  variable instead. Error variants that previously only contained a `backtrace`
+  field with the feature enabled now always contain it. ([#1967])
+- cosmwasm-vm: Removed `backtraces` feature, use the `RUST_BACKTRACE=1` env
+  variable instead. All `VmError` variants now have a `backtrace` field.
+  ([#1967])
 
 [#1874]: https://github.com/CosmWasm/cosmwasm/pull/1874
 [#1876]: https://github.com/CosmWasm/cosmwasm/pull/1876
@@ -73,6 +79,7 @@ and this project adheres to
 [#1941]: https://github.com/CosmWasm/cosmwasm/pull/1941
 [#1944]: https://github.com/CosmWasm/cosmwasm/pull/1944
 [#1949]: https://github.com/CosmWasm/cosmwasm/pull/1949
+[#1967]: https://github.com/CosmWasm/cosmwasm/pull/1967
 
 ### Removed
 

MIGRATING.md

@@ -21,7 +21,9 @@ major releases of `cosmwasm`. Note that you can also view the
 
   If you were using cosmwasm-std's `ibc3` feature, you can remove it, as it is
   the default now. Depending on your usage, you might have to enable the
-  `stargate` feature instead, since it was previously implied by `ibc3`.
+  `stargate` feature instead, since it was previously implied by `ibc3`. Also
+  remove any uses of the `backtraces` feature. You can use a `RUST_BACKTRACE=1`
+  env variable for this now.
 
 - `ContractInfoResponse::new` now takes all fields of the response as
   parameters:
@@ -125,6 +127,14 @@ major releases of `cosmwasm`. Note that you can also view the
   +CosmosMsg::Any(AnyMsg { type_url, value })
   ```
 
+- Replace all direct construction of `StdError` with use of the corresponding
+  constructor:
+
+  ```diff
+  -StdError::GenericErr { msg }
+  +StdError::generic_err(msg)
+  ```
+
 ## 1.4.x -> 1.5.0
 
 - Update `cosmwasm-*` dependencies in Cargo.toml (skip the ones you don't use):

contracts/burner/Cargo.toml

@@ -27,9 +27,7 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# for quicker tests, cargo test --lib
-# for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
+
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/crypto-verify/Cargo.toml

@@ -27,9 +27,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# for quicker tests, cargo test --lib
-# for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/crypto-verify/src/contract.rs

@@ -317,12 +317,13 @@ mod tests {
 
         let res = query(deps.as_ref(), mock_env(), verify_msg);
         assert!(res.is_err());
-        assert_eq!(
+        assert!(matches!(
             res.unwrap_err(),
             StdError::VerificationErr {
-                source: VerificationError::InvalidPubkeyFormat
+                source: VerificationError::InvalidPubkeyFormat,
+                ..
             }
-        )
+        ))
     }
 
     #[test]
@@ -605,12 +606,13 @@ mod tests {
         };
         let res = query(deps.as_ref(), mock_env(), verify_msg);
         assert!(res.is_err());
-        assert_eq!(
+        assert!(matches!(
             res.unwrap_err(),
             StdError::VerificationErr {
                 source: VerificationError::InvalidPubkeyFormat,
+                ..
             }
-        )
+        ))
     }
 
     #[test]
@@ -670,12 +672,13 @@ mod tests {
         };
         let res = query(deps.as_ref(), mock_env(), verify_msg);
         assert!(res.is_err());
-        assert_eq!(
+        assert!(matches!(
             res.unwrap_err(),
             StdError::VerificationErr {
-                source: VerificationError::InvalidPubkeyFormat
+                source: VerificationError::InvalidPubkeyFormat,
+                ..
             }
-        )
+        ))
     }
 
     #[test]

contracts/cyberpunk/Cargo.toml

@@ -25,8 +25,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# For quicker tests, cargo test --lib. for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/empty/Cargo.toml

@@ -27,9 +27,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# for quicker tests, cargo test --lib
-# for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/floaty/Cargo.toml

@@ -27,8 +27,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# For quicker tests, cargo test --lib. for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/hackatom/Cargo.toml

@@ -27,8 +27,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# For quicker tests, cargo test --lib. for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }

contracts/ibc-reflect-send/Cargo.toml

@@ -27,9 +27,6 @@ overflow-checks = true
 default = []
 # Use cranelift backend instead of singlepass. This is required for development on 32 bit or ARM machines.
 cranelift = ["cosmwasm-vm/cranelift"]
-# for quicker tests, cargo test --lib
-# for more explicit tests, cargo test --features=backtraces
-backtraces = ["cosmwasm-std/backtraces", "cosmwasm-vm/backtraces"]
 
 [dependencies]
 cosmwasm-schema = { path = "../../packages/schema" }