Reduce code formatter collection occurrences

Author: reda-alaoui

core/src/main/java/com/cosium/code/format/AbstractFormatMojo.java

@@ -1,5 +1,6 @@
 package com.cosium.code.format;
 
+import com.cosium.code.format.formatter.CodeFormatters;
 import java.io.IOException;
 import java.nio.file.FileSystems;
 import java.nio.file.FileVisitResult;
@@ -26,12 +27,13 @@ protected final void doExecute() throws MojoExecutionException, MojoFailureExcep
     getLog().debug("Using pattern '" + pattern + "'");
     PathMatcher pathMatcher = FileSystems.getDefault().getPathMatcher("glob:" + globPattern);
 
+    CodeFormatters codeFormatters = collectCodeFormatters();
     for (Path sourceDir : sourceDirs()) {
-      walk(sourceDir, pathMatcher);
+      walk(codeFormatters, sourceDir, pathMatcher);
     }
   }
 
-  private void walk(Path directoryToWalk, PathMatcher pathMatcher)
+  private void walk(CodeFormatters codeFormatters, Path directoryToWalk, PathMatcher pathMatcher)
       throws MojoExecutionException, MojoFailureException {
     Path targetDir = targetDir();
     try {
@@ -48,7 +50,7 @@ public FileVisitResult visitFile(Path path, BasicFileAttributes attrs) {
                 return FileVisitResult.CONTINUE;
               }
               try {
-                process(path);
+                process(codeFormatters, path);
               } catch (MojoExecutionException | MojoFailureException e) {
                 throw new MavenGitCodeFormatException(e);
               }
@@ -75,5 +77,5 @@ public FileVisitResult visitFileFailed(Path file, IOException exc) {
     }
   }
 
-  protected abstract void process(Path path) throws MojoExecutionException, MojoFailureException;
+  protected abstract void process(CodeFormatters codeFormatters, Path path) throws MojoExecutionException, MojoFailureException;
 }

core/src/main/java/com/cosium/code/format/AbstractMavenGitCodeFormatMojo.java

@@ -77,7 +77,7 @@ protected final String artifactId() {
     return currentProject.getArtifactId();
   }
 
-  protected final CodeFormatters codeFormatters() {
+  protected final CodeFormatters collectCodeFormatters() {
     return new CodeFormatters(createCodeFormatters());
   }
 

core/src/main/java/com/cosium/code/format/FormatCodeMojo.java

@@ -1,5 +1,6 @@
 package com.cosium.code.format;
 
+import com.cosium.code.format.formatter.CodeFormatters;
 import com.cosium.code.format_spi.CodeFormatter;
 import com.cosium.code.format_spi.FileExtension;
 import com.cosium.code.format_spi.LineRanges;
@@ -19,8 +20,8 @@
 public class FormatCodeMojo extends AbstractFormatMojo {
 
   @Override
-  protected void process(Path path) {
-    codeFormatters()
+  protected void process(CodeFormatters codeFormatters, Path path) {
+    codeFormatters
         .forFileExtension(FileExtension.parse(path))
         .forEach(formatter -> format(path, formatter));
   }

core/src/main/java/com/cosium/code/format/OnPreCommitMojo.java

@@ -25,7 +25,7 @@ protected void doExecute() throws MojoExecutionException {
   }
 
   private void onPreCommit() throws IOException, GitAPIException {
-    GitStagedFiles.read(getLog(), gitRepository(), this::isFormattable).format(codeFormatters());
+    GitStagedFiles.read(getLog(), gitRepository(), this::isFormattable).format(collectCodeFormatters());
   }
 
   private boolean isFormattable(Path path) {

core/src/main/java/com/cosium/code/format/ValidateCodeFormat.java

@@ -1,5 +1,6 @@
 package com.cosium.code.format;
 
+import com.cosium.code.format.formatter.CodeFormatters;
 import com.cosium.code.format_spi.CodeFormatter;
 import com.cosium.code.format_spi.FileExtension;
 import java.io.IOException;
@@ -16,15 +17,15 @@
 @Mojo(name = "validate-code-format", defaultPhase = LifecyclePhase.VERIFY, threadSafe = true)
 public class ValidateCodeFormat extends AbstractFormatMojo {
   @Override
-  protected void process(Path path) throws MojoFailureException {
-    if (validate(path)) {
+  protected void process(CodeFormatters codeFormatters, Path path) throws MojoFailureException {
+    if (validate(codeFormatters, path)) {
       return;
     }
     throw new MojoFailureException(path + " is not correctly formatted !");
   }
 
-  private boolean validate(Path path) {
-    return codeFormatters().forFileExtension(FileExtension.parse(path)).stream()
+  private boolean validate(CodeFormatters codeFormatters, Path path) {
+    return codeFormatters.forFileExtension(FileExtension.parse(path)).stream()
         .map(formatter -> doValidate(path, formatter))
         .filter(valid -> !valid)
         .findFirst()