When no formatter dependency is declared, the plugin should fail

Author: reda-alaoui

README.md

@@ -6,6 +6,10 @@
 A maven plugin that automatically deploys code formatters as `pre-commit` git hook.
 On commit, the hook will automatically format staged files.
 
+# Breaking changes between 4.x and 5.x
+
+* If the plugin runs without any formatter dependency, it will fail. This is done to prevent silent misconfiguration from happening.
+
 # Breaking changes between 3.x and 4.x
 
 * `Google Java Format` is not enabled by default anymore. `com.cosium.code:google-java-format` must be added as a dependency to the plugin to keep using it.

core/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.cosium.code</groupId>
     <artifactId>git-code-format-maven-plugin-parent</artifactId>
-    <version>4.4-SNAPSHOT</version>
+    <version>5.0-SNAPSHOT</version>
   </parent>
 
   <artifactId>git-code-format-maven-plugin</artifactId>

core/src/main/java/com/cosium/code/format/AbstractMavenGitCodeFormatMojo.java

@@ -85,6 +85,12 @@ private List<CodeFormatter> createCodeFormatters() {
 
     List<CodeFormatterFactory> formatterFactories = new ArrayList<>();
     ServiceLoader.load(CodeFormatterFactory.class).forEach(formatterFactories::add);
+    if (formatterFactories.isEmpty()) {
+      throw new IllegalStateException(
+          "No "
+              + CodeFormatter.class
+              + " instance found. You probably forgot to declare a code formatter as a plugin's dependency. You can use https://github.com/Cosium/git-code-format-maven-plugin#automatic-code-format-and-validation-activation as an example.");
+    }
 
     CodeFormatterConfigurationFactory formatterConfigurationFactory =
         new CodeFormatterConfigurationFactory(

google-java-format/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.cosium.code</groupId>
     <artifactId>git-code-format-maven-plugin-parent</artifactId>
-    <version>4.4-SNAPSHOT</version>
+    <version>5.0-SNAPSHOT</version>
   </parent>
 
   <artifactId>google-java-format</artifactId>

pom.xml

@@ -3,7 +3,7 @@
 
   <groupId>com.cosium.code</groupId>
   <artifactId>git-code-format-maven-plugin-parent</artifactId>
-  <version>4.4-SNAPSHOT</version>
+  <version>5.0-SNAPSHOT</version>
   <packaging>pom</packaging>
 
   <name>Git Code Format Maven Plugin Parent</name>

spi/pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>com.cosium.code</groupId>
     <artifactId>git-code-format-maven-plugin-parent</artifactId>
-    <version>4.4-SNAPSHOT</version>
+    <version>5.0-SNAPSHOT</version>
   </parent>
 
   <artifactId>git-code-format-maven-plugin-spi</artifactId>