Skip to content

Commit 3317bcc

Browse files
Remove module Copilot.Core.Type.Uninitialized. Refs #302.
The function Copilot.Core.Type.Uninitialized.uninitialized was deprecated in Copilot 3.6. The function was incomplete, and it was only used in one example, so what was needed from it was moved directly there. As per our internal policy of waiting 3 versions from deprecation until a public interface declaration can be removed, this type can now be removed completely. Since it is the only definition in the module Copilot.Core.Type.Uninitialized, the whole module can be removed. The following demonstrates that the module is unused within Copilot: ``` $ grep -nHre 'Uninitialized' --include='*.hs' | grep -ve '^{-#' | grep -ve '--.*Uninitialized' | grep -ve '"[^"]*Uninitialized[^"]*"' copilot-core/src/Copilot/Core/Type/Uninitialized.hs:10:module Copilot.Core.Type.Uninitialized copilot-core/src/Copilot/Core.hs:33: , module Copilot.Core.Type.Uninitialized copilot-core/src/Copilot/Core.hs:45:import Copilot.Core.Type.Uninitialized ``` We use the module and not the function because a function with the same name is used in an example. The result obtained are three lines: the module, its re-import from Copilot.Core, and it being exported. The function uninitialized is not required by Copilot's requirements, and therefore should not be published. This commit removes the module, and removes its declaration as a re-exported module both in Copilot.Core and directly in the cabal package. Using the method above shows no results.
1 parent 50039ba commit 3317bcc

File tree

3 files changed

+0
-38
lines changed

3 files changed

+0
-38
lines changed

copilot-core/copilot-core.cabal

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ library
6464
Copilot.Core.Type.Dynamic
6565
Copilot.Core.Type.Equality
6666
Copilot.Core.Type.Show
67-
Copilot.Core.Type.Uninitialized
6867
Copilot.Core.PrettyPrint
6968
Copilot.Core.PrettyDot
7069

copilot-core/src/Copilot/Core.hs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ module Copilot.Core
3030
, module Copilot.Core.Spec
3131
, module Copilot.Core.Type
3232
, module Copilot.Core.Type.Array
33-
, module Copilot.Core.Type.Uninitialized
3433
, module Data.Int
3534
, module Data.Word
3635
) where
@@ -42,6 +41,5 @@ import Copilot.Core.Operators
4241
import Copilot.Core.Spec
4342
import Copilot.Core.Type
4443
import Copilot.Core.Type.Array
45-
import Copilot.Core.Type.Uninitialized
4644
import Data.Int
4745
import Data.Word

copilot-core/src/Copilot/Core/Type/Uninitialized.hs

Lines changed: 0 additions & 35 deletions
This file was deleted.

0 commit comments

Comments
 (0)