Make polls modifiable by removing Reveal

Polls that are hidden really shouldn't be revealed

Author: mxmeinhold

README.md

@@ -46,6 +46,6 @@ gofmt -w -s *.go logging sse database
 
 - [ ] Don't let the user fuck it up
 - [ ] Show E-Board polls with a higher priority
-- [ ] Move Hide Vote to create instead of after you vote :skull:
+- [x] Move Hide Vote to create instead of after you vote :skull:
 - [ ] Display the reason why a user is on the results page of a running poll
 - [ ] Display minimum time left that a poll is open

main.go

@@ -230,9 +230,6 @@ func main() {
 		}
 
 		canModify := containsString(claims.UserInfo.Groups, "active_rtp") || containsString(claims.UserInfo.Groups, "eboard") || poll.CreatedBy == claims.UserInfo.Username
-		if poll.Gatekeep {
-			canModify = false
-		}
 
 		c.HTML(200, "poll.tmpl", gin.H{
 			"Id":               poll.Id,
@@ -400,9 +397,6 @@ func main() {
 		}
 
 		canModify := containsString(claims.UserInfo.Groups, "active_rtp") || containsString(claims.UserInfo.Groups, "eboard") || poll.CreatedBy == claims.UserInfo.Username
-		if poll.Gatekeep {
-			canModify = false
-		}
 
 		c.HTML(200, "result.tmpl", gin.H{
 			"Id":               poll.Id,
@@ -455,43 +449,6 @@ func main() {
 		c.Redirect(302, "/results/"+poll.Id)
 	}))
 
-	r.POST("/poll/:id/reveal", csh.AuthWrapper(func(c *gin.Context) {
-		cl, _ := c.Get("cshauth")
-		claims := cl.(cshAuth.CSHClaims)
-
-		poll, err := database.GetPoll(c, c.Param("id"))
-		if err != nil {
-			c.JSON(500, gin.H{"error": err.Error()})
-			return
-		}
-
-		if poll.CreatedBy != claims.UserInfo.Username {
-			c.JSON(403, gin.H{"error": "Only the creator can reveal a poll result"})
-			return
-		}
-
-		err = poll.Reveal(c)
-		if err != nil {
-			c.JSON(500, gin.H{"error": err.Error()})
-			return
-		}
-		pId, _ := primitive.ObjectIDFromHex(poll.Id)
-		action := database.Action{
-			Id:     "",
-			PollId: pId,
-			Date:   primitive.NewDateTimeFromTime(time.Now()),
-			User:   claims.UserInfo.Username,
-			Action: "Reveal Results",
-		}
-		err = database.WriteAction(c, &action)
-		if err != nil {
-			c.JSON(500, gin.H{"error": err.Error()})
-			return
-		}
-
-		c.Redirect(302, "/results/"+poll.Id)
-	}))
-
 	r.POST("/poll/:id/close", csh.AuthWrapper(func(c *gin.Context) {
 		cl, _ := c.Get("cshauth")
 		claims := cl.(cshAuth.CSHClaims)

templates/result.tmpl

@@ -52,13 +52,6 @@
         {{ end }}
       </div>
       {{ end }}
-      {{ if and (.CanModify) (.IsHidden) }}
-      <br />
-      <br />
-      <form action="/poll/{{ .Id }}/reveal" method="POST">
-        <button type="submit" class="btn btn-success">Reveal Votes</button>
-      </form>
-      {{ end }}
       {{ if and (.CanModify) (not .IsHidden) }}
       <br />
       <br />