Removing magic packet number from logic

Author: mbillow

conditional/blueprints/intro_evals.py

@@ -62,7 +62,7 @@ def get_fid_cm_count(member_id):
             'name': fid.name,
             'uid': fid.id,
             'eval_date': fid.eval_date.strftime("%Y-%m-%d"),
-            'signatures_missed': 65535,
+            'signatures_missed': -1,
             'committee_meetings': get_fid_cm_count(fid.id),
             'committee_meetings_passed': get_fid_cm_count(fid.id) >= 10,
             'house_meetings_missed':

conditional/templates/intro_evals.html

@@ -31,12 +31,12 @@ <h6 class="eval-uid">{{ m['uid'] }}</h6>
                     <div class="col-sm-5 col-md-6 col-lg-5 vcenter">
                         <div class="row">
                             <div class="text-center">
-                                {% if m['signatures_missed'] == 65535 %}
-                                <div class="eval-info-label warning"><span class="glyphicon glyphicon-hourglass white"></span> Packet in Progress</div>
+                                {% if m['signatures_missed'] == 0 %}
+                                    <div class="eval-info-label success">Signatures Missed: {{m['signatures_missed']}}</div>
                                 {% elif m['signatures_missed'] > 0 %}
-                                <div class="eval-info-label danger">Signatures Missed: {{m['signatures_missed']}}</div>
+                                    <div class="eval-info-label danger">Signatures Missed: {{m['signatures_missed']}}</div>
                                 {% else %}
-                                <div class="eval-info-label success">Signatures Missed: {{m['signatures_missed']}}</div>
+                                    <div class="eval-info-label warning"><span class="glyphicon glyphicon-hourglass white"></span> Packet in Progress</div>
                                 {% endif %}
                             </div>
                             <div class="text-center">